This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The Next button in CVS profile wizard doesn't change state (enabled/disabled) until the Repository Path text field loses focus. I think it should get enabled when something is typed in the text field. To reproduce: - open Versioning|Versioning Manager - click Add button - select CVS profile - type something in working directory text field - type something in repository path text field - now Next button should be enabled but it is NOT. You have to focus another component and then the next button is enabled. It is a usability issue but also a testability issue. Tested in build 20040708-0120, JDK1.5.0-b56, WindowsXP.
The problem is, that all validators act on focus lost. All filled values are assigned on focus lost. We would have to add some special mode into VariableInputDialog, that would provide notifications on key typed events.
Started to work on this. A listener on the document of the JTextListener works better then the key typed listener. The update of wizard works well, with the exception of Working Directory textfield. The problem is, that the directory that is written there is corrected to the proper form by the VcsFileSystem (e.g. ending slashes are removed). This leads to loosing of the ability to write into the textfield until explicitely clicking with a mouse. We need to somehow prevent from these auto-correction.
Fixed in trunk. The state of the wizard is updated immediately. /cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java,v <-- VariableInputDialog.java new revision: 1.88; previous revision: 1.87 /cvs/vcsgeneric/src/org/netbeans/modules/vcs/advanced/wizard/mount/AbstractWizardPanel.java,v <-- AbstractWizardPanel.java new revision: 1.8; previous revision: 1.7 /cvs/vcsgeneric/src/org/netbeans/modules/vcs/advanced/wizard/mount/MountWizardData.java,v <-- MountWizardData.java new revision: 1.15; previous revision: 1.14 /cvs/vcsgeneric/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java,v <-- VcsCustomizer.java new revision: 1.134; previous revision: 1.133
After the fix the following NPE appears in automated tests. Not reproducable manually: java.lang.NullPointerException at org.netbeans.modules.vcs.advanced.VcsCustomizer.updateConditionalValues(VcsCustomizer.java:2117) at org.netbeans.modules.vcs.advanced.VcsCustomizer.changeRootDir(VcsCustomizer.java:2449) at org.netbeans.modules.vcs.advanced.VcsCustomizer.access$5700(VcsCustomizer.java:69) at org.netbeans.modules.vcs.advanced.VcsCustomizer$9.run(VcsCustomizer.java:2434) at org.openide.util.Task.run(Task.java:136) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:330) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:686)
Hmm, this should not happen. What the automated test does when the exception is thrown? Does it invoke Add in Versioning Manager and starting to write into the wizard, or does it customize an existing VCS filesystem?
It happens when automated test selects CVS profile. In detail: - open versioning manager - click Add button - type PROJECT_HOME>/src in workdir text field - select CVS profile - type PROJECT_HOME>/src in repository workdir Sometime after selecting CVS profile (but before we try to click the next button) the exception is thrown (look at the screen shot).
Created attachment 16265 [details] Screen shot after NPE was thrown.
Verified in Netbeans IDE 200407222055.