[custom build 20040615, JDK 1.5.0, Metal L&F]
See attached screenshot, it shows strange spacing
of components on Main Window toolbars. Mainly
icons are not centered vertically nor
horizontally. Icons (and memory meter) touch
tollbar handles. Toolbar handles are not centered
Partially applies for small icons toolbar too.
It's not P3 by definition, but Main Window is
highly visible component, so please leave as P3.
Created attachment 15705 [details]
Passing to Marek.
Icons contain shadow. Together with shadow icon pictures should be
centered. You can discuss with HIE if it is real or just fake effect.
Impl does not do any shift of icon position in toolbar button. I would
take screenshot put axis and measure exactly how big is margin in pixels.
I would try to shift icons by one pixel to lower right corner. As
shadow is just shadow it looks like icons are not centered. What do
Ok, let's try to move it 1 pixel to lower right corner and we will
I will attach 2 toolbar screenshots:
toolbar24 is original toolbar.
toolbar24-1 is toolbar with icons shifted by 1 pixel to right and to
bottom. (Icons in Editor toolbar are shifted: Cut, Copy, Paste, Undo
Created attachment 16000 [details]
Original toolbar snapshot
Created attachment 16001 [details]
Toolbar snapshot with shifted icons in Editor toolbar
Dusan anything new with this issue?
I showed it to Leos (graphic expert) and he agreed with moving it 1
pixel to lower right corner.
Ok. Shall I do the same shift also with 16x16 icons? Shall I attach
snaphots for 16x16 icons?
Dusan it is nice but when there will be new icons I do not want to
shift it again and again. (Actually I did shift in gimp. I do not know
if it is possible to make such operation from command line ie. without
GUI). It would be better to make shift at source. Again what to do
with 16x16 icons?
Yes, there will be new icons according to the new brand but it will
not be so soon (My assumption is half of year at least). Try to
commit that improved bigger icons into trunk and I will check that
small ones (16x16) by our graphic expert.
Too late for NB 4.0. Reassigning to Dafe: It is necessary to shift new
24x24 icons (used in toolbar) by 1 pixel to right and 1 pixel to
bottom. I did it in gimp manually. I will attach list of icons (24x24
icons have suffix 24)
Created attachment 18549 [details]
List of icons
i move all icon's in marek's list one pixel to the right and one pixel
down. see the attachement for the list of modified icons
Created attachment 20093 [details]
cvs check-in log
dusan, pls check the new icons and close the issue if you think
everything is alright. (or reassign back to me and i'll close it)
btw, what the other icons that may appear in the main toolbar?
Still waiting for Dusan's confirmation, but the icons positions have been fixed
and look ok to me now.
Note that the Memory toolbar position hasn't changed and still touches the
toolbar handle on Metal L&F. It looks fine on XP L&F. This is a minor issue as
Memory toolbar is off by default in a released product -> P4.
Standard icons (Build, Debug, Edit, File, Versioning) look ok now.
What do you mean by ...the other icons that may appear in the main toolbar?...
Which ones concretely?
well, any. in the tools/options dialog you can put any declared action into the
toolbar. it's icon will be used. Thus we have the look for the default actions
tuned, but any 3rd party action's icon will not be shifted. Do I understand it
There is a suggestion what should happened with 3d party icons in the following
spec in the chapter Additional behavior:
There should exist placeholder icon used for merging with other small icons:
icons don't have a shadow anymore, closing