This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 44779 - Favorites tab removes critical actions from Ant build scripts
Summary: Favorites tab removes critical actions from Ant build scripts
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Favorites (show other bugs)
Version: 4.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: mslama
URL: http://ui.netbeans.org/nonav/docs/ui/...
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2004-06-12 01:56 UTC by Jesse Glick
Modified: 2008-12-22 18:49 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-06-12 01:56:22 UTC
Favorites.ProjectFilterNode.createActionsForFile
silently deletes unrecognized actions, e.g. Run
Targets from Ant build scripts. Must never remove
actions from the original node unless you are sure
what you are doing. Should have an assert that the
returned actions are a superset of the original
actions.

Even deletes actions like Run from *subnodes*,
which is completely gratuitous - should not touch
nodes beneath a file's node delegate, there is no
need to have a special FilterNode for anything
beneath the data node level.

Bug makes it impossible to run any Ant scripts via
the Favorites tab, i.e. any scripts not inside a
project.

Only known workaround: install apisupport and Bean
Browse Node on an Ant script, get the original
node, and run the actions from there.
Comment 1 mslama 2004-06-14 08:57:51 UTC
I have list of actions which should be on nodes in Favorites tab in UI
spec => all other actions are now filtered out. Jano what to do? Shall
I not filter any actions on Folder and File nodes in Favorites tab?
(Tools action is present.)
Comment 2 Jesse Glick 2004-06-14 17:13:01 UTC
IMHO: do not filter out any actions unless specifically instructed to
do so by the UI spec. The context menu in the UI spec should be
considered an illustration only.
Comment 3 mslama 2004-06-15 16:40:41 UTC
Fixed in main trunk. No actions from undelying nodes are filtered out.
Only actions 'Add to Favories' or 'Remove from Favorites' are added.

Modified:
core/favorites/src/org/netbeans/modules/favorites/Favorites.java r.1.12
Comment 4 Tomas Danek 2005-07-07 09:37:05 UTC
Verified on trunk 4.2:

>Log Session: Thursday, July 7, 2005 10:34:42 AM CEST                          
                                                >System Info:                  
                                                                               
                  Product Version       = NetBeans IDE Dev (Build 2.1)         
                                                                  Operating
System      = SunOS version 5.9 running on sparc                               
                                      Java; VM; Vendor      = 1.5.0_03; Java
HotSpot(TM) Client VM 1.5.0_03-b07; Sun Microsystems Inc.