This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 43470 - "Process All Files" unchecked in new CVS mount yet behaved as if checked
Summary: "Process All Files" unchecked in new CVS mount yet behaved as if checked
Status: RESOLVED WONTFIX
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 4.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-18 17:52 UTC by Jesse Glick
Modified: 2009-12-21 07:17 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2004-05-18 17:52:38 UTC
I made a new CVS mount for a working dir with a
local repository (the project already existed on
disk and was in CVS). I added a JFrame to the
source dir. I then right-clicked the file (in the
All Files view I think; does it matter?) and
selected CVS -> Add and chose to commit immediately.

It added and committed both the .java and the
.form file.

This is fine - what I wanted - but in the
customizer for the mount, "Process All Files" is
unchecked. So it is apparently not behaving
according to the GUI.

Suggest that this option be checked by default and
be honored if unchecked. Or remove the option
entirely and always process all files in a
DataObject - I cannot think of any reason why a NB
4.0 user would want this off, since *.class files
are no longer in the source dir and are not in
fact recognized as part of a JavaDataObject. The
only DataObject types in the NB IDE that use
secondary files are form and properties; for both
of these cases, you certainly would want to apply
VCS operations to all the files in the DO.

dev-040516, Linux, 1.5.0b51.
Comment 1 Martin Entlicher 2004-05-18 18:07:50 UTC
The semantics is a little bit different that you expected.
"Process All Files" = false means to process all files in a data
object, but ignore "unimportant" files (== not sharable in 4.0
terminology).
"Process All Files" = true means to process really all files including
unimportant.

But now data objects contain only "important" files, this is why the
behavior is the same. The "important" flag was replaced by
SharabilityQuery, therefore "Process All Files" = true will add
actions also on non-sharable files and process them. If someone would
really like to version *.class files, this is the only way to do it.

So, we should probably rename the option to something like "Process
Non Sharable Files" (not sure this is descriptive enough for end
users). Comments?
Comment 2 Jesse Glick 2004-05-18 18:33:01 UTC
Ah, I see. Adjusting priority to reflect that the problem is only the
odd configuration UI. ... Sorry, no idea what the best labelling would
be for this. Might be better to remove the option entirely, readd the
CVS submenu (or whatever) to "nonsharable" files or folders, but warn
the user before proceeding with any VCS actions on such files that
they probably shouldn't do it unless they know what they are doing.
(And continue to exclude nonsharable files and folders from recursive
directory operations?)
Comment 3 Jiri Kovalsky 2004-05-19 10:07:29 UTC
I am almost sure that "Process Non Sharable Files" name won't be
understood and I have serious doubts we even need to keep this
functionality. I agree with Jesse to remove this option entirely.
People will still have a chance to do it in Versioning view, right ?
Comment 4 Martin Entlicher 2004-05-19 12:34:59 UTC
Non-sharable files/folders are not presented in Versioning view at all
(they can not be versioned, thus it does not have sense to show them).

The Jesse's suggestion to add the VCS actions everywhere and warn the
user on non-sharable files/folders is nice, but that would imply that
we would have to display the status information always. And a special
dialog will have to be added.
I prefer the option, but it's hard to find descriptive enough wording.
Comment 5 Jiri Kovalsky 2004-05-19 14:16:44 UTC
Well, what is the scenario when you need to add non-sharable
files/folders into VCS ? As far as I know we had this requirement in
QE dept. when compiled tests used to be checked in to repository but I
can't recall for what reason. I still prefer to remove that option.
Anybody else with own opinion ?
Comment 6 _ pkuzel 2005-01-13 10:49:01 UTC
It's hard conceptional issue. My opinion is that it should go away.
It's reposnsibility of SharabilityQuery providers. VCSFS should not
try be smarter than providers.
Comment 7 _ pkuzel 2005-01-13 10:53:21 UTC
Also note that SharabilityQuery concept duplicates (and causes
confusion) ignore lists concept known from versioning systems.
Comment 8 Martin Entlicher 2005-01-13 12:00:53 UTC
Perhaps we could try to join these two somehow....
We should perhaps add an action, that would synchronize the VCS ignore
list with the current definition of sharability query.
But the problem is, that we do not know what will be unsharable in
advance (e.g. before the project is built). The problem is, that the
sharability query is dynamic, but the ignore list is static (almost,
if not changed externally).
Perhaps it's desired to modify the ignore list (== modification of
.cvsignore files in CVS) every time there's some new unsharable file?

This concept will be less restrictive, since it's possible to add an
ignored file/folder into VCS. Without any special warnings.
After that this option would be obsolete.
Comment 9 Quality Engineering 2009-12-21 07:17:22 UTC
This bug was reported against NetBeans IDE 6.0 or an older release, or against a non-maintained module. NetBeans team does not have enough resources to get to this issue, therefore we are closing the issue as a WONTFIX. If you are interested in providing a patch for this bug, please see our NetFIX guidelines for how to proceed. 

We apologize for any inconvenience.


Thank you.
The NetBeans Team