This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 41756 - Show All Details action is performed in AWT thread
Summary: Show All Details action is performed in AWT thread
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 4.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@utilities
URL:
Keywords: PERFORMANCE, THREAD
Depends on:
Blocks:
 
Reported: 2004-04-06 16:51 UTC by Antonin Nebuzelsky
Modified: 2006-03-24 09:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonin Nebuzelsky 2004-04-06 16:51:07 UTC 
Show All Details action in the Search Results
window does its job in AWT thread, blocking the
IDE. This must be changed to do the population of
Output-Search Results window in a separate thread,
not freezing the IDE.
Comment 1 Marian Petras 2004-04-06 18:16:03 UTC 
Accepted.
Comment 2 Marian Petras 2004-07-29 10:12:08 UTC 
Fixed in the trunk. Bugs #41756 and #41789 were fixed at once.

Modified/added/removed files:
openidex/src/org/openidex/search/SearchGroup.java   (1.10)
utilities/nbproject/project.properties   (1.3)
utilities/src/org/netbeans/modules/search/Bundle.properties   (1.27)
utilities/src/org/netbeans/modules/search/CleanTask.java   (new file)
utilities/src/org/netbeans/modules/search/Manager.java   (new file)
utilities/src/org/netbeans/modules/search/PrintDetailsTask.java   (new file)
utilities/src/org/netbeans/modules/search/RemoveFromSearchAction.java   (1.2)
utilities/src/org/netbeans/modules/search/ResultModel.java   (1.45)
utilities/src/org/netbeans/modules/search/ResultTreeChildren.java   (new file)
utilities/src/org/netbeans/modules/search/ResultView.java   (1.21)
utilities/src/org/netbeans/modules/search/SearchEngine.java  (deleted, last 1.2)
utilities/src/org/netbeans/modules/search/SearchPerformer.java   (1.32)
utilities/src/org/netbeans/modules/search/SearchTask.java   (1.11)
utilities/src/org/netbeans/modules/search/Utils.java   (1.3)
utilities/src/org/netbeans/modules/search/doc-files/manager-state-diagram.png
                                                           (new file)
Comment 3 Antonin Nebuzelsky 2004-07-29 15:55:15 UTC 
Reopening. Show All Details does not work for me at all for large set
of found results.
Comment 4 Marian Petras 2004-07-29 15:59:16 UTC 
It works for me even when searching for a single character in a huge
set of files. I will need to look into the source code to find the cause.
Comment 5 Marian Petras 2004-07-30 16:57:55 UTC 
Fixed in the trunk.

It seems there were two remaining problems with the previous version
of the fix:
 - some painting were not redirected back to the AWT thread
 - remaining problem from previous versions: all computation was done
   prior to printing the details

The lines are now printed in batches, and a computation is done fore
each batch separately, just before the lines are printed.

Modified files:
utilities/src/org/netbeans/modules/search/Manager.java (1.2)
utilities/src/org/netbeans/modules/search/PrintDetailsTask.java (1.2)
utilities/src/org/netbeans/modules/search/SearchDisplayer.java (1.14)
Comment 6 Antonin Nebuzelsky 2004-08-02 12:05:57 UTC 
Verified in trunk build 200408011800.