This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 40674 - Wasting space in diff window
Summary: Wasting space in diff window
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: diff-issues@utilities
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-02 09:34 UTC by Milan Kubec
Modified: 2005-12-07 15:54 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (5.13 KB, image/png)
2004-03-02 09:34 UTC, Milan Kubec
Details
screenshot (5.05 KB, image/png)
2004-03-02 09:35 UTC, Milan Kubec
Details
screenshot1 (29.97 KB, image/png)
2004-11-15 15:29 UTC, Milan Kubec
Details
screenshot2 (30.50 KB, image/png)
2004-11-15 15:30 UTC, Milan Kubec
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kubec 2004-03-02 09:34:11 UTC
When using graphical diff editor shows 2 toolbars
above the text area. IMHO it's wasting space. See
screenshots, one showing the problem and second
possible solution.
Comment 1 Milan Kubec 2004-03-02 09:34:59 UTC
Created attachment 13767 [details]
screenshot
Comment 2 Milan Kubec 2004-03-02 09:35:35 UTC
Created attachment 13768 [details]
screenshot
Comment 3 Milan Kubec 2004-03-02 09:37:06 UTC
Blank space shown on second screenshot should be removed of course.
Comment 4 Martin Entlicher 2004-03-02 10:40:53 UTC
I agree that the second approach would be better, but it would be
harder to implement, since the "Previous" and "Next" icons are part of
the "Graphical Diff Viewer". They disappear when "Textual Diff Viewer"
is selected.

We would have to add a possibility to viewers to provide a toolbar.
That toolbar would be then displayed separately from the viewer component.
Comment 5 Milan Kubec 2004-11-15 15:29:01 UTC
Attaching another screenshots that show how much space is wasted
comparing to java editor.
Comment 6 Milan Kubec 2004-11-15 15:29:37 UTC
Created attachment 18900 [details]
screenshot1
Comment 7 Milan Kubec 2004-11-15 15:30:43 UTC
Created attachment 18901 [details]
screenshot2
Comment 8 Martin Entlicher 2004-11-15 16:24:58 UTC
Hmm, we can remove the extra spaces around the Engine a Visualizer.
Then we would have to create some mechanism how to put the toolbar
next to Visualizer...
Comment 9 Martin Entlicher 2005-01-11 17:59:55 UTC
Not a functional defect -> P4. More an enhancement then a defect.
Comment 10 Martin Entlicher 2005-03-24 16:17:48 UTC
Too late for 4.1. But it might be necessary to have a mechanism to plug other
components into diff window in promotion F.
Comment 11 _ pkuzel 2005-11-15 16:24:57 UTC
Looks promising, I'm able to hack in.
Comment 12 _ pkuzel 2005-11-15 16:55:15 UTC
Not award winning UI but IMHO better then before:

Checking in DiffPresenter.form;
/shared/data/ccvs/repository/diff/src/org/netbeans/modules/diff/builtin/DiffPresenter.form,v
 <--  DiffPresenter.form
new revision: 1.5; previous revision: 1.4
done
Checking in DiffPresenter.java;
/shared/data/ccvs/repository/diff/src/org/netbeans/modules/diff/builtin/DiffPresenter.java,v
 <--  DiffPresenter.java
new revision: 1.21; previous revision: 1.20
done
Checking in visualizer/DiffPanel.form;
/shared/data/ccvs/repository/diff/src/org/netbeans/modules/diff/builtin/visualizer/DiffPanel.form,v
 <--  DiffPanel.form
new revision: 1.6; previous revision: 1.5
done
Checking in visualizer/DiffPanel.java;
/shared/data/ccvs/repository/diff/src/org/netbeans/modules/diff/builtin/visualizer/DiffPanel.java,v
 <--  DiffPanel.java
new revision: 1.29; previous revision: 1.28
done
Checking in visualizer/DiffComponent.java;
/shared/data/ccvs/repository/diff/src/org/netbeans/modules/diff/builtin/visualizer/DiffComponent.java,v
 <--  DiffComponent.java
new revision: 1.18; previous revision: 1.17
done
Comment 13 Milan Kubec 2005-12-07 15:54:11 UTC
Verified in dev-200512061900.