This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Submitted for vcscore component, since the problem is likely in VariableInputDialog or the associated logic in variables setting. The problem can be reproduced on CVS filesystem with a pserver connection. Mount the FS with a command-line client. Invoke the Customizer, command-line client should be selected correctly. Do not change anything and close the Customizer. Invoke the Customizer the second time. Now Built-In client will be mistakenly selected. This problem was originally reported by mkleint@netbeans.org
I can't reproduce this with build 200402191900, it is probably fixed with issues related to VariableInput.
Well, the problem is still there :-(( Reopening. I thought that it's the same problem as issue #40728, but unfortunately not. It seems like this bug have origin in updating of variable values in VariableInputDialog. The change is performed in following thread stack: org.netbeans.modules.vcs.advanced.CommandLineVcsFileSystem.setVariables(CommandLineVcsFileSystem.java:1105) at org.netbeans.modules.vcs.advanced.VcsCustomizer.variablesChanged(VcsCustomizer.java:2038) at org.netbeans.modules.vcs.advanced.VcsCustomizer.access$5500(VcsCustomizer.java:63) at org.netbeans.modules.vcs.advanced.VcsCustomizer$7.propertyChange(VcsCustomizer.java:1836) at javax.swing.event.SwingPropertyChangeSupport.firePropertyChange(SwingPropertyChangeSupport.java:264) at javax.swing.event.SwingPropertyChangeSupport.firePropertyChange(SwingPropertyChangeSupport.java:232) at javax.swing.JComponent.firePropertyChange(JComponent.java:3819) at org.netbeans.modules.vcscore.util.VariableInputDialog.updateVariableValues(VariableInputDialog.java:760) at org.netbeans.modules.vcscore.util.VariableInputDialog.updateVariableValues(VariableInputDialog.java:631) at org.netbeans.modules.vcs.advanced.VcsCustomizer.initAdditionalComponents(VcsCustomizer.java:1988) at org.netbeans.modules.vcs.advanced.VcsCustomizer.setObject(VcsCustomizer.java:2613)
Added "fix-in-36" into Status Whiteboard, we should fix this into 3.6 release.
The problem is fixed in trunk: /cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java,v <-- VariableInputDialog.java new revision: 1.74; previous revision: 1.73 Since similar problem in PVCS was P1 priority (issue #40728), increasing the priority to P1. Milos, can you please verify the fix? Thanks.
Created attachment 13868 [details] The contextual diff of the patch.
seems ok now..
The fix is simple - processes radio button only once. Reviewed without objections.
QA, please, verify the fix in trunk build. Thanks.
This is already verified by Milos. It should be sufficient, right? I've posted the notification to reviewers@netbeans.org and I'm waiting 24 hours...
I've checked it on Build 200403071900 and it seems fine. (the only spot is that the textfield "CVS Executable: " is disabled even though the CMD-line client is selected. You must first click on this radio-button, but it used to be there for a long time. And on JDK1.5 it's enough to hover the mouse over it)
Milos did review of source code, didn't he? Dan will verify functionality. QE must aprove such fixes by verifying functionality on trunk build.
nope, I just verified that it works for me now..
Thanks for the verification and review, the fix is merged into release36 branch: /shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java,v <-- VariableInputDialog.java new revision: 1.73.6.1; previous revision: 1.73