This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39583 - Add possibility to delegate get/setValue calls to FilterNode
Summary: Add possibility to delegate get/setValue calls to FilterNode
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Nodes (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: apireviews
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2004-02-04 10:08 UTC by Petr Nejedly
Modified: 2008-12-22 21:04 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
The diff of FilterNode (2.22 KB, patch)
2004-02-04 10:32 UTC, Petr Nejedly
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2004-02-04 10:08:35 UTC
FilterNode allows forwarding selected methods to
its delegate, and filtering the others.
The filtering can be selected on a method basis
for most of important methods, but not for
get/setValue methods. The Node's value is used
throughout the IDE for some sideband communication
and when a Node is wrapped in FilterNode, this
sideband is broken.

I propose to allow forwarding these two methods as
well, by means of providing forwarding masks for
these two methods and by overriding the methods in
FilterNode to perform forwarding.

The API change consists solely of adding two
protected constants:
FilterNode.DELEGATE_SET_VALUE = 1 << 9;
FilterNode.DELEGATE_GET_VALUE = 1 << 10;

The constants will be stable and the behaviour of
the get/setValue will be driven by the value of
provided mask. The default mask will contain the
above flags set, which means change in behaviour
(after this change, the FilterNode will delegate
the get/setValue calls, which it didn't before).

The issue itself is tracked as issue #31006 and
blocks issue 9940
Comment 1 Jaroslav Tulach 2004-02-04 10:22:30 UTC
1. You could reuse the original issue, if you wanted. 
2. Please attach the diffs.
Comment 2 Petr Nejedly 2004-02-04 10:32:43 UTC
Created attachment 13238 [details]
The diff of FilterNode
Comment 3 Petr Nejedly 2004-02-04 10:33:29 UTC
of cource the final diff will contain @since tags for the constants,
but I don't know the version yet ;-)
Comment 4 Jesse Glick 2004-02-04 15:41:54 UTC
Diff looks fine to me. Unit test coverage?
Comment 5 Petr Nejedly 2004-02-12 11:47:40 UTC
I'll write the tests.
I'm going to commit the change together with tests tomorrow.
Comment 6 Petr Nejedly 2004-02-13 15:19:02 UTC
Implemented, see issue 31006 for commit log.