This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39463 - [win classic] Wrong color of editor tabs
Summary: [win classic] Wrong color of editor tabs
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: _ tboudreau
URL:
Keywords: L&F, UI
Depends on:
Blocks:
 
Reported: 2004-02-02 11:20 UTC by klosels
Modified: 2008-12-22 19:59 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Netbeans Build 20031211 - active editor tab (15.96 KB, image/png)
2004-02-02 14:00 UTC, Marian Mirilovic
Details
Netbeans Build 20040120 - active editor tab (15.86 KB, image/png)
2004-02-02 14:02 UTC, Marian Mirilovic
Details
Build 040218 - Active tab, only partly visible (13.26 KB, image/jpeg)
2004-02-18 15:55 UTC, _ mruflin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description klosels 2004-02-02 11:20:44 UTC
In Q-Build 20031211 the editor tabs used the
colors for active/inactive windows as defined in
Win2K settings just like for the
filesystems/runtime tabs.

With Q-Build 20040120 this doesn't work any more -
editor tabs are always painted in light/dark gray
for inactive/active state.

See attached sreenshots for both builds to compare.
Comment 1 klosels 2004-02-02 11:38:48 UTC
Sorry, I cannot add any PNG as attachment, neither using Mozilla nor 
IE, request screenshots by mail if needed.
Comment 2 Marian Mirilovic 2004-02-02 11:44:43 UTC
Ok, send me screenshots by email, thanks.
Comment 3 David Simonek 2004-02-02 11:47:39 UTC
Passing to Tim - perhaps user has customized color scheme set?
Comment 4 Marian Mirilovic 2004-02-02 14:00:09 UTC
Created attachment 13190 [details]
Netbeans Build 20031211 - active editor tab
Comment 5 Marian Mirilovic 2004-02-02 14:02:14 UTC
Created attachment 13191 [details]
Netbeans Build 20040120 - active editor tab
Comment 6 _ tboudreau 2004-02-02 16:36:33 UTC
The change happened when we switched over to using less intrusive gradients for the 
tabs - at the moment it is drawing a gradient between...dark gray and dark gray.

I'll see what I can do to switch over to deriving the base color from a system color in a 
better way. 
Comment 7 klosels 2004-02-06 17:13:14 UTC
Just tried 3.6 beta - obviously the way to determine those colours has
changed again - but's it still doesn't conform to the way it's
supposed to work on Windows :-( 
Active windows now have a gradient from grey to the second gradient
color that Windows uses for _inactive_ windows. 

Please have a look at any native windows App with MDI interface to see
what it's supposed to be.

Why not change it simply to what it was in Q-Build 20031211 which was
correct?! 

Don't get me wrong, I don't want to be picky and I'm _really_ _very_
happy with the new windows system - I just don't get it why this
particular point should be so difficult when somebody's at it anyway...
I'd rather have blue instead of yellow folder icons again (changed in
3.6 beta) than having to look twice to see which windows has the focus.
Comment 8 _ tboudreau 2004-02-06 20:57:31 UTC
I will fix this for 3.6.
Comment 9 _ mruflin 2004-02-18 15:51:32 UTC
There is another bug on Win2k Lnf, showing up in today's source build 
(was surely there before too)

Not completely showing tabs are painted using the old darkblue color 
instead of a gradient.
Comment 10 _ mruflin 2004-02-18 15:55:22 UTC
Created attachment 13509 [details]
Build 040218 - Active tab, only partly visible
Comment 11 _ tboudreau 2004-02-27 00:42:41 UTC
Fixed in trunk.  To set expectations correctly:  This will now use a 
color based on the active window title color supplied by the OS.  The 
gradient should not look exactly like the gradients on Windows window 
titles, because according to the UI spec, the color at the other end 
of the gradient is the standard gray tab background color.

How it works:  It is passed the standard window title background 
color and the gradient color from the spec.  It splits these into HSB 
values.  It then applies the difference in HSB colorspace between the 
default title color and the default spec color to the actual color 
the OS returned.

Checking in ui/tabcontrol/WindowsViewTabUI.java;
/cvs/core/windows/src/org/netbeans/core/windows/view/ui/tabcontrol/Win
dowsViewTa
bUI.java,v  <--  WindowsViewTabUI.java
new revision: 1.15; previous revision: 1.14
done
Processing log script arguments...
More commits to come...
Checking in ui/tabcontrol/plaf/AbstractTabRenderer.java;
/cvs/core/windows/src/org/netbeans/core/windows/view/ui/tabcontrol/pla
f/Abstract
TabRenderer.java,v  <--  AbstractTabRenderer.java
new revision: 1.16; previous revision: 1.15
done
Checking in ui/tabcontrol/plaf/WinClassicTabRenderer.java;
/cvs/core/windows/src/org/netbeans/core/windows/view/ui/tabcontrol/pla
f/WinClass
icTabRenderer.java,v  <--  WinClassicTabRenderer.java
new revision: 1.8; previous revision: 1.7
done
Checking in ui/tabcontrol/plaf/WinClassicTabsUI.java;
/cvs/core/windows/src/org/netbeans/core/windows/view/ui/tabcontrol/pla
f/WinClass
icTabsUI.java,v  <--  WinClassicTabsUI.java
new revision: 1.8; previous revision: 1.7
done
Checking in ui/tabcontrol/plaf/WinXPTabRenderer.java;
/cvs/core/windows/src/org/netbeans/core/windows/view/ui/tabcontrol/pla
f/WinXPTab
Renderer.java,v  <--  WinXPTabRenderer.java
new revision: 1.6; previous revision: 1.5
done
Processing log script arguments...
Mailing the commit message to cvs@core.netbeans.org (from 
tboudreau@netbeans.org
)
Comment 12 Zdenek Konecny 2005-07-12 12:18:01 UTC
I've marked it closed. The look of tabs is absolutely different in current
version. (NetBeans 4.2 Build 200507110943)