This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39247 - Nothing to copy after commit
Summary: Nothing to copy after commit
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on: 39383
Blocks:
  Show dependency tree
 
Reported: 2004-01-27 06:55 UTC by Jaroslav Tulach
Modified: 2004-02-03 11:12 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2004-01-27 06:55:54 UTC
The netbeans.org law is to put result of commit
message into the issue resolution. I've just
commited NbKeymapTest.java rev. 1.13 and all I see
is output in form of table. There is nothing I
could copy! This is prevents the internal client
to be used for development of netbeans.

My simplest suggestion is to add action Copy to
popup menu of the output.

My enhancement request is to generate nice output
connected to NetBeans WebCVS that would use links
to diffs:

#39221: Must be executed in AWT eq thread
http://www.netbeans.org/source/browse/core/test/unit/src/org/netbeans/core/NbKeymapTest.java.diff?r1=1.2&r2=1.3
Comment 1 Martin Entlicher 2004-01-27 12:31:51 UTC
The table there because of the UI unification with JavaCVS. JavaCVS
had there a "View Log" button, but this button was not a part of UI
specification.

I understand that this is a problem for users that need to copy the
commit logs somewhere. This is "Save To File..." popup menu item, but
it's not much comfortable for this purpose.

I use a text output from "Commit Command" from Runtime tab as a
workaround, but this is something that ordinary user can not find out.

Gabo, do you have any objections agains adding the "Copy" popup menu item?
Comment 2 Martin Entlicher 2004-01-29 16:33:28 UTC
This is actually considered as a regression and it's suggested to
solve it by adding back "View Log" action. There is no natural place
for a button, so it's suggested to put it on a popup menu.
Copy action upon a table, that would copy the whole log output, is
considered to be confusing. In the log dialog you will be able to copy
just what you need.

A better solution is desired for promotion D.
Comment 3 Martin Entlicher 2004-01-29 17:04:59 UTC
Some more observations:
1) I'll name the action "View Text", which is more intuitive IMHO.
2) The action should be present only on GUI visualizer. Otherwise it's
strange when the same text output that is already visible in the text
output can be viewed in another window.
3) "Save To File..." does not actually work on GUI visualizers. It
needs to be reimplemented anyway to save the *whole* output, not just
what's visible.
Comment 4 Martin Entlicher 2004-01-29 17:32:50 UTC
It's necessary to fix issue #39383 first.
Comment 5 Martin Entlicher 2004-01-30 12:34:09 UTC
The "View Text" action implemented:

Checking in AbstractOutputPanel.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/AbstractOutputPanel.java,v
 <--  AbstractOutputPanel.java
new revision: 1.6; previous revision: 1.5
done
Checking in Bundle.properties;
/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/Bundle.properties,v 
<--  Bundle.properties
new revision: 1.18; previous revision: 1.17
done

and enabled on Add, Commit and Update:

Checking in add/AddInfoPanel.java;
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/add/AddInfoPanel.java,v
 <--  AddInfoPanel.java
new revision: 1.3; previous revision: 1.2
done
Checking in commit/CommitInfoPanel.java;
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/commit/CommitInfoPanel.java,v
 <--  CommitInfoPanel.java
new revision: 1.2; previous revision: 1.1
done
Checking in update/UpdateInfoPanel.java;
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/visualizers/update/UpdateInfoPanel.java,v
 <--  UpdateInfoPanel.java
new revision: 1.14; previous revision: 1.13
Comment 6 Jaroslav Tulach 2004-02-03 09:31:52 UTC
View Text is available in popup menu on table, but not on the rest of
the gray area.
Comment 7 Martin Entlicher 2004-02-03 10:07:47 UTC
I know. Is it a problem? It's technically very hard to display the
action outside of the table.
Perhaps the table component can be expanded if it wouldn't look bad.
Comment 8 Jaroslav Tulach 2004-02-03 10:38:22 UTC
I think it is a problem, but small. Why it is hard to display the
popup there? I can see "save to file" in popup on gray area and that
has to be provided by vcs, is it not?
Comment 9 Martin Entlicher 2004-02-03 11:08:59 UTC
The popup was added also on the scroll pane. It should be visible
correctly now:

/cvs/vcscore/src/org/netbeans/modules/vcscore/ui/AbstractOutputPanel.java,v
 <--  AbstractOutputPanel.java
new revision: 1.7; previous revision: 1.6
Comment 10 Martin Entlicher 2004-02-03 11:11:14 UTC
> Why it is hard to display the popup there?

I was afraid that when I add the popup on the scroll pane, the "View
Text" action will be visible even when it should not be. But
apparently it seems to work good.
Comment 11 Martin Entlicher 2004-02-03 11:11:51 UTC
It should be "RESOLVED FIXED".
Reopening...
Comment 12 Martin Entlicher 2004-02-03 11:12:11 UTC
Fixed.