This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 39155 - I18N - Deployment Progress Monitor displays garbaged message
Summary: I18N - Deployment Progress Monitor displays garbaged message
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2004-01-23 06:28 UTC by mtsuruta
Modified: 2006-06-05 00:38 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
attached dialog image(jpg). (14.88 KB, image/jpeg)
2004-01-23 06:31 UTC, mtsuruta
Details
corrapted message which is not red text and upper side of status bar (4.52 KB, image/gif)
2004-02-12 04:25 UTC, mtsuruta
Details
image in C locale on w2k (15.44 KB, image/jpeg)
2004-02-18 07:17 UTC, mtsuruta
Details
war file - web module and jsp simply created with no modification (1.37 KB, application/octet-stream)
2004-02-20 08:35 UTC, mtsuruta
Details
TomcatManagerImpl.class (10.43 KB, application/octet-stream)
2004-02-20 09:19 UTC, Milan Kuchtiak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mtsuruta 2004-01-23 06:28:46 UTC
Deployment monitor dialog has garbaged message on
win20.Please see attached image file.  
This message may be trying to display directory
path using red text.
This issue occurs on win20 only when launching ide
in C locale, not only ja locale.

nb-trunk - build 200401181900
loale: win2k - ja/ide - C and ja

to display the message:
1. Create web module
2. Create a JSP
3. Execute the JSP
Comment 1 mtsuruta 2004-01-23 06:31:08 UTC
Created attachment 13042 [details]
attached dialog image(jpg).
Comment 2 _ tboudreau 2004-02-03 11:38:11 UTC
Reassigning to web, this is not a core bug.
Comment 3 Nam Nguyen 2004-02-04 16:41:05 UTC
Mtsuruta:
I can't read Japanese yet :-) so please help me understand the issue.
 Red text is because it's an error message.  Other than that, whats
wrong with the Japanese text?
Also, can I try the same test case to see the equivalent English text.
 It seems to me the test case is too simple to cause a deployment error.
Comment 4 mtsuruta 2004-02-05 09:24:50 UTC
Previous attached image shows red text which is not readable Japanese.
Excuse me that I could not point out exact test case in last comment.

- Occurs only on nb36 build 040118: ja and C locale
- Confirmed only on win2k(Checked by 040119 on Sol9/Linux not by build
040118):

1. mount a dir for web module in explorer
2. create a web module using the mounted dir
3. Create a simple JSP with no modification.
4. Right click on the JSP icon and select Execute from contexture
menu.
5. With build 0401181900, deployment error occurs with execution of
JSP by steps above - C locale also.
(Please execute with new user dir, never executed jsp, and no running
tomcat.)

With later build than 040119 on windows, this red corrupted message is
not able to reproduce with stability. 
Comment 5 Petr Jiricka 2004-02-09 14:00:55 UTC
Changing component to j2eeserver.
Comment 6 mtsuruta 2004-02-12 04:20:11 UTC
This issue can be reproduce on RedHat7 with nb3.6beta in ja locale
stably. Checked with additional test steps. Please see the results
following. It seems JSP encoding type reflect the message appearance, 
but could not confirm the original ja or en message because there is
no log or any output except on dialog.

1. Changed jsp page tags encoding to EUC-JP from UTF-8
Result: Not occurred corrupted red message
(Not able to execute JSP)

2. Delete .netbeans dir, and launch ide.
   Execute jsp again with page tag encoding of UTF-8.
Result: Displays red text corrupted message.
(Not able to execute JSP)

3. Execute JSP in c locale with UTF-8
Able to execute JSP with no corrupted message.

Sol9
Result 1.2.
- Message placed on status bar is corrupted. Please see attached
image. Not occurs red text corrupted message by step 1 and 2 above.
Result 3. 
- Able to execute JSP with no corrupted message.

win2k
Result 1.2.
- Message placed on status bar is not able to be confirmed visibly.
Not occurs red text corrupted message by step 1 and 2 above.
Result 3.
- Not able to execute JSP.
Comment 7 mtsuruta 2004-02-12 04:25:36 UTC
Created attachment 13384 [details]
corrapted message which is not red text and upper side of status bar
Comment 8 Petr Jiricka 2004-02-13 15:02:10 UTC
Milan, could you please look at this? Petr.
Comment 9 Milan Kuchtiak 2004-02-16 14:42:26 UTC
I was able to reproduce the issue in NB3.6 BETA.

In the latest build, however, the behaviour is different :

Step 2:
The error message appears, which says that the Japanese Language Pack
need to be installed : this error message comes from the browser,
because it is trying to open the page from the cache. Then if you
click the Refresh/Reload button the page opens correctly.

As the execution in the step 2 isn't stopped any more in latest build,
I would consider this issue as WORKSFORME.

Please, check (with the latest build) whether I am correct.
Thank You.

Milan
Comment 10 mtsuruta 2004-02-18 07:15:12 UTC
I could not see any error message for Ja Package on recent trunk
040216, but as Milan said jsp execution is no longer stopped at test
step2 with red corrupted message on Deployment Progress Monitor, and I
agree with the behavior on recent build is different from beta.
However, there are still garbaged status messages as attached image
which is appeared before launching browser.

locale | Sol9  RdHt7  W2k
--------------------------
 C        1*    2*    O 
 ja       O     3*    4*
 
 O = Still occurs(Not able to deploy the web modue)
 Please see the attached image appeared on C locale, win2k.

 1*, 2* = Could not confirm all message on dep monitor visibly..
 - JSP was able to execute. 

 3*, 4* = Could not confirm all message on dep monitor visibly..
 - JSP was not able to execute. Could not deploy the web module.
 (Able to execute jsp at the first time only after mounting dir and
creating jsp - will report this issue separately)
 
Comment 11 mtsuruta 2004-02-18 07:17:39 UTC
Created attachment 13484 [details]
image in C locale on w2k
Comment 12 Milan Kuchtiak 2004-02-18 14:40:57 UTC
Should be fixed now.
The execution process relied that the output from Tomcat Manager appl.
was written in English. 
This caused those strange error messages in progress bar.

Please verify the fix.
Comment 13 _ rkubacki 2004-02-19 08:41:30 UTC
I don't think the fix is correct. How you will catch failures now?

Maybe you need to ask Tomcat developers for help. Or better yet to
write a patch for Tomcat to send part of response as nonlocalized
message (like number for error code or special header line).
Comment 14 Petr Jiricka 2004-02-19 09:20:00 UTC
Why do you think the fix is not "correct"? It does solve the main I18N
issue. If you think that another problem (visible by the user) was
introduced by this fix, please file a separate bug. Reopening an issue
because you just don't like the code is poor behavior. Please close
this issue and file a separate one for the problem you feel was
introduced. 
Comment 15 Martin Grebac 2004-02-19 09:28:10 UTC
Well, actually, I have to agree with Radim here. The fix doesn't seem
to be correct to me, either. I didn't have time to communicate this
with Milan, though. 
 As Radim says - how errors are presented now? If the dialog fails,
there should be red error description in it, which is not with this
fix, I believe. Milane? Did we miss something?
Comment 16 mtsuruta 2004-02-19 10:40:50 UTC
This issue is still reproducible on latest nb trunk of 040218.
Visibly confirmed on Sol9 and w2k, but could not visibly check the
message on RedHat7 because of the appearance speed.
There is no red currupted message occured when jsp execution was
stopped by issue 40205, but the message might have been visibly
appeared on not current trunk just because of the fixed issue. 
Could you please check messages come from tomcat for this dialog if
there are.

Thank you in advance.
Comment 17 Milan Kuchtiak 2004-02-19 10:59:04 UTC
The problem is that the test for the response content :
=========================================
if (!line.startsWith("OK -")) { // NOI18N
=========================================
was not correct - so it should have been be fixed. (I118N reason)

The test for HTTP status can be included there instead. 

Is it satisfactory ? 
Is there a use-case for HTTP status 200 that
manager/list will still fail ?
Comment 18 Milan Kuchtiak 2004-02-19 11:33:34 UTC
Unfortutately, I don't see any issues with executing the japanese JSPs
in Japanese environment now.
I am not able to reproduce the given steps.

Could you possibly write the steps again as I am a little lost.
The best would be to reproduce the issue with the new web module and
new JSP.

Please, could yo attach your web module as well.

The Radim's objection is not related to the original i18N problem.
It must be solved separately.
Comment 19 _ rkubacki 2004-02-19 12:46:24 UTC
No, you will get HTTP status 200 even if the command fails. The
problem is that it is not guaranted that success is indicated by OK at
the begining of response content in localized environment. Again I am
afraid that this is a Tomcat problem. 

BTW: What Tomcat's Ant tasks do in this case? They can fail in the
same way or they can read the localized message from jar and compare
it correctly.
Comment 20 mtsuruta 2004-02-20 08:35:58 UTC
Created attachment 13538 [details]
war file - web module and jsp simply created with no modification
Comment 21 mtsuruta 2004-02-20 08:50:03 UTC
One of the corrupted message, appears as image 13384, comes from
following tomcat property.

/org/apache/catalina/manager/LocalStrings_ja.properties
jakarta-tomcat-5.0.18/server/webapps/manager/WEB-INF/lib/catalina-manager.jar

Could you please try to execute the jsp using attached war file and
see the messages on Deployment Progress Monitor..? 
Comment 22 Milan Kuchtiak 2004-02-20 09:18:04 UTC
The attached module works fine for me.
Except of index.jsp located in WEB-INF directory.
The WEB-INF directory is unavailable for http client - just for Tomcat
server.
(I am working with the patch)

Yes I know that manager application is localized to Japanese.

Please check the last build with the switch

org.netbeans.modules.tomcat5=-1

Command line:
runide.exe -J-Dorg.netbeans.modules.tomcat5=-1

Then apply the patch attached :

Replace the TomcatManagerImpl.class in 
Tomcat5.jar (ide_home/modules)
org.netbeans.modules.tomcat5 package

and start the IDE again with the switch.

Then, please attach the output from console.

The important is to find out whether the red message still appears in
prograss bar.
Comment 23 Milan Kuchtiak 2004-02-20 09:19:11 UTC
Created attachment 13541 [details]
TomcatManagerImpl.class
Comment 24 mtsuruta 2004-02-20 11:36:43 UTC
Both messages, image id 13384 and 13042, are now properly displayed
with attached TomcatManagerImpl.class.
Able to check the black exception ja message which had been corrupted
whether jsp was in WEB-INF or not, but it is good to know the issue.
Thank you. Please let me now report the result on sol9 only.
Comment 25 Milan Kuchtiak 2004-02-20 13:00:43 UTC
Could we consider the issue fixed after checking in the patch ?
Comment 26 Milan Kuchtiak 2004-02-23 13:06:44 UTC
Radim's objection took into account.
Accepting Japanese OK now from Manager application.

As the Manager is localized to Japanese, German and French for Tomcat
5.0, the fix is suficient.

German and French localizations use "OK" prefix as well.

Set "UTF-8" parameter for InputStreamReader in order not to transform
Japanese characters correctly to strings. 
Comment 27 mtsuruta 2004-02-26 10:43:34 UTC
This issue is verified on sol9, RedHat7, and win2k using trunk build
040224.