This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 38012 - Consider Output - Versioning existence/behavior
Summary: Consider Output - Versioning existence/behavior
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC All
: P1 blocker (vote)
Assignee: Richard Gregor
URL:
Keywords:
Depends on:
Blocks: 37507 37621
  Show dependency tree
 
Reported: 2003-12-11 10:31 UTC by Richard Gregor
Modified: 2004-02-19 10:06 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Gregor 2003-12-11 10:31:12 UTC
There is still Output-Versioning opened when
command fails with message:e.g.:

The Check Out command failed.
Check the full output of the command on the
Runtime tab in Explorer. The error output follows:
No error output is available.

So there are two components with vcs output -
standard output with changed name to "output -
versioning" and new vcs output.Consider whether we
need to write something to output-versioning.
Comment 1 Tomas Pavek 2003-12-12 15:02:02 UTC
Why the message refers to Runtime tab? Isn't the info in the VCS
output window of just executed command, so the user should see it
immediately? Or are there commands that can run without showing the
output, so it can be found *only* in Runtime?
Comment 2 Gabriel Tichy 2003-12-12 16:18:49 UTC
Output/Versioning tab should be removed, it has no purpose anymore.
Comment 3 Martin Entlicher 2003-12-12 16:49:21 UTC
Output/Versioning can not be simply removed without appropriate
replacement.

To answer Tomas' question:
The message refers to Runtime tab, because from the command node in
Runtime tab you can open the _complete_ output of the command. In
Output/Versioning is only error output (if any).

There are many commands that do not open any output by default (e.g.
Refresh, Commit (commit probably should open a GUI output in Output
Window! to be consistent with original JavaCVS; the output format is
similar to update), Edit, Unedit and possibly more.

The most important is probably Refresh. If Refresh fails, the user
need to know the reason. And therefore the output of the executed
commands is necessary to be visible. The error output is usually
enough in many cases and is likely not to be so large as standard
output can be. This is the reason why just error output was printed by
default.
Comment 4 Martin Entlicher 2003-12-12 17:01:33 UTC
Also many commands, that normally produce some GUI output, do not
present anything when they fail. They can not build the output.
Therefore it's necessary to inform the user somehow what has happened.
Comment 5 Tomas Pavek 2003-12-15 09:35:23 UTC
So we really cannot simply abandon the std. IDE's Output/Versioning
window. But we have now a dedicated VCS Output window so why not to
use it also for these kinds of error outputs? I.e.:

(1) If the command fails and does not produce any output, show a new
tab in the VCS Output window with simple text informing about this.

(2) In case the command produces some (std. error) output into the VCS
Output window, I think no additional tab or text needs to be printed
to any output window. Just a message in status line could say the
command failed, but the details should be available in the Std. Error
tab of the VCS Output at the same time.

(3) For commands that don't open any output by default I think they
should do that if they fail. Then rule (1) or (2) can be applied. To
me it looks like we need not any message reminding the Runtime tab -
if some errors happened, show them simply immediately.

Just my thoughts. Does this make sense? And is it doable?
Comment 6 Martin Entlicher 2003-12-17 10:07:16 UTC
I have discussed this with Gabo, and we basically agreed with Tomas
proposal. The only problem can be, that if we do not refer to the
Runtime tab, the user might not be able to find the execution string
of the command. This might be necessary in order to understand what
actually went wrong. The solution can be to dump the execution string
into the "Standard Output", but it's not really nice.

Comment 7 Tomas Pavek 2003-12-17 10:18:04 UTC
So then in (1) could could we advise the user to check also the
execution string and print it there immediately? Possibli with a note
that it can be always found in Runtime tab.

I guess errors produced by command itself in (2) are not typically
caused by wrong execution string (i.e. if they run)...
Comment 8 Richard Gregor 2004-01-05 16:38:23 UTC
Fixed except execution string. Exec string could be seen in runtime in
properties so I don't think we need to display it, I hope we don't
release commands with incorrect exec string. If you disagree I'll
change that.

Checking in src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v
 <--  UserCommandTask.java
new revision: 1.12; previous revision: 1.11
done
Comment 9 Richard Gregor 2004-01-08 10:10:42 UTC
Exec string in.

Checking in src/org/netbeans/modules/vcscore/cmdline/Bundle.properties;
/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.12; previous revision: 1.11
done
Checking in src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/UserCommandTask.java,v
 <--  UserCommandTask.java
new revision: 1.14; previous revision: 1.13
done
Comment 10 dmladek 2004-02-17 21:24:51 UTC
Well, what was the bug about and what was really fixed?
I'm little bit confused wit this issue.

I found following things which IMHO in contrast with here specified
behaviour:

(I mount CVS-INT FS which had badly defined port to simualte failing
of commands)

1) Status.... throws NPE (issue #40192) and don't open any output 
        infoming why it fails
2) Log...don't open any output too
3) Update on file...same as Log
4) Update on root of FS... never finish (issue #40193) and doesn't   
      open anything


Thus I'm reopening... If you disagree, please be more specific and
describe me what exactly I should verify.

thanks
Comment 11 Richard Gregor 2004-02-19 10:06:54 UTC
Are you supposed to verify Task? This one was implemented and worked
well at that time. If you see any problem then file a Defect. This
task is here only for tracking - planing and code was implemented so
signing as fixed - task has been done (of course now it could be
broken somehow)