This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 37789 - JSR-88 clients cannot provide sufficient icon support
Summary: JSR-88 clients cannot provide sufficient icon support
Status: RESOLVED WONTFIX
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Sherold Dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-05 13:24 UTC by Petr Jiricka
Modified: 2005-09-18 10:42 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2003-12-05 13:24:54 UTC
ConfigBeanNode does not override
'AbstractNode.getOpenedIcon()' so JSR-88 clients
cannot provide sufficient icon support.

Solution suggested by Peter Williams
(pete.williams@sun.com) : Add the following method
to
org.netbeans.modules.j2ee.deployment.config.ui.ConfigBeanNode.java

Index: ConfigBeanNode.java
===================================================================
RCS file:
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ui/ConfigBeanNode.java,v
retrieving revision 1.1.2.5
diff -b -r1.1.2.5 ConfigBeanNode.java
71a72,79
>
>       public Image getOpenedIcon(int type) {
>               if(info != null) {
>                       Image icon =
info.getIcon(type);
>                       if(icon != null) return icon;
>               }
>               return super.getOpenedIcon(type);
>       }

Note: java.beans.BeanInfo does not support the
concept of an "OpenedIcon".  I'm open to
suggestions as to how to enhance this in a
suitable manner so that JSR-88 clients can provide
both closed and open icons.  However, the above
method is required regardless, as the treeview
uses it's own default icon (a white box) if an
opened icon is not provided.
Comment 1 Nam Nguyen 2003-12-23 01:43:56 UTC
Checked in the fix as suggested. 
As for support for opened/closed types icon, if needed we can use the
netbeans-deployments file mechanism as we did with config bean helpid.
Comment 2 Nam Nguyen 2004-01-06 07:20:27 UTC
Reduced to P3 since the remaining issue item is just support for
different icons b/w opened/closed.
Comment 3 Nam Nguyen 2004-02-02 16:10:12 UTC
With introduction ConfigBeanProperties API specifying of the opened
icon could be specified as a property like "openedIcon".  Will put in
support for it in future release.
Comment 4 Pavel Buzek 2004-09-09 23:10:34 UTC
Nam plans to add this into DConfigBeanProperties.
Comment 5 Nam Nguyen 2004-10-27 19:24:40 UTC
The fix is ready, but it would affect existing AS plugin.  The
functionality is not needed for 4.0.  Will checkin the fix for 4.1.
Comment 6 _ ludo 2005-01-31 04:59:24 UTC
Nam:

Do we have the fix now integrated in 4.1?

Comment 7 Nam Nguyen 2005-01-31 15:28:17 UTC
I did not get a chance.  This will now need API changes review.  I
don't think it worth the trouble?
Comment 8 Pavel Buzek 2005-02-21 21:41:59 UTC
I agree with Nam - this is not critical for 4.1.
Comment 9 _ ludo 2005-02-25 01:59:10 UTC
P4 as what we have in 4.1 is ok for the AS plugin. Could improve in 4.2.
Comment 10 Sherold Dev 2005-09-18 10:42:31 UTC
closing as WONTFIX since the j2eeserver does no longer have control over server
specific data objects.