This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 37433 - ContextAwareAction impl of ToolsAction not quite correct
Summary: ContextAwareAction impl of ToolsAction not quite correct
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Actions (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords:
Depends on: 35827
Blocks:
  Show dependency tree
 
Reported: 2003-11-22 19:14 UTC by Jesse Glick
Modified: 2008-12-22 22:42 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Suggested patch to make it unnecessary to impl Presenter.Popup on context-aware instances in ToolsAction popup submenu (2.27 KB, patch)
2003-11-22 19:15 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2003-11-22 19:14:30 UTC
Some problems I noticed w/ ToolsAction & using
plain Action's w/ ContextAwareAction.

1. The context submenu uses CAA, but skips plain
Action's which are not Presenter.Popup's. Probably
it should create a default menu item for them, as
all other menu code does. Patch included.

2. The inline menu in the main Tools menu appears
to not use CAA correctly. If you have a
SystemAction in the ToolsAction list which is a
CAA, the menu item seems to be from the
SystemAction, when you really you want it to be
from the current global context. (Or maybe it is
that it is the context-aware action but from the
context in effect when the menu was created during
startup, rather than from when the menu was last
posted. For that, dep on issue #35827.)
Comment 1 Jesse Glick 2003-11-22 19:15:14 UTC
Created attachment 12269 [details]
Suggested patch to make it unnecessary to impl Presenter.Popup on context-aware instances in ToolsAction popup submenu
Comment 2 Peter Zavadsky 2004-01-08 14:18:34 UTC
Applied the patch into [trunk]

Checking in openide/src/org/openide/actions/ToolsAction.java;
/cvs/openide/src/org/openide/actions/ToolsAction.java,v  <-- 
ToolsAction.java
new revision: 1.47; previous revision: 1.46
done
Processing log script arguments...
Mailing the commit message to cvs@openide.netbeans.org (from
pzavadsky@netbeans.org)
Comment 3 Marian Mirilovic 2005-07-13 13:24:23 UTC
closed