This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 37396 - Metal L&F - wrong tab border
Summary: Metal L&F - wrong tab border
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC All
: P4 blocker (vote)
Assignee: _ tboudreau
URL:
Keywords: L&F
Depends on:
Blocks:
 
Reported: 2003-11-21 08:21 UTC by jrojcek
Modified: 2008-12-22 21:51 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
A gif with some questions in text in it (5.21 KB, image/gif)
2003-12-06 22:12 UTC, _ tboudreau
Details
Screen shot of case where there's only room for two tabs and both must be clipped (920 bytes, image/gif)
2003-12-07 10:51 UTC, _ tboudreau
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2003-11-21 08:21:37 UTC
3) the tab border is not precisely the same as in
the spec

http://ui.netbeans.org/nonav/docs/ui/ws_issues/ws_issues-metal.html
Comment 1 David Simonek 2003-11-26 14:27:43 UTC
Prioritizing.
Comment 2 David Simonek 2003-12-01 18:47:38 UTC
Passing to Tim, Tim please look at this. Thx.
Comment 3 _ tboudreau 2003-12-06 22:11:29 UTC
I've got a couple questions re the screenshots, and which ones I
should be following.  There are differences between a few of them, and
it appears that a couple are dithered gifs, so I'm not sure if the
differences are because they were dithered and some colors were lost,
or if they really are the way they were.

I'll attach a gif with some circles and my questions.  Please respond
ASAP.

Also:  Is it correct that you do not ever want to show text on clipped
tabs in Metal?
Comment 4 _ tboudreau 2003-12-06 22:12:05 UTC
Created attachment 12453 [details]
A gif with some questions in text in it
Comment 5 _ tboudreau 2003-12-06 23:14:00 UTC
Another thing unspecified:

How does a selected, clipped tab paint its background?

I know when something is selected, it should become fully shown, but
the user can still produce this situation by scrolling.  Some sort of
edge that indicates continuation is needed - otherwise it will just be
a block of color missing one edge.
Comment 6 _ tboudreau 2003-12-07 10:50:23 UTC
Also an issue:

It is impossible to have *both* the left clipped tab and the right
clipped tab appear to have no text or icon and always be a fixed size.
 One of them must be able to stretch.  

I'll attach a screenshot for why - but basically, the problem is:  If
the window is small enough that only two tabs will fit, and both must
be clipped, if you can't stretch one or the other, what do you put in
the middle?

(ignore the fact that there's empty space to thr right of the tab -
I'm in the middle of completely reimplementing the editor tabs UI to
work with the revised spec, and the control buttons haven't been
reimplemented yet).
Comment 7 _ tboudreau 2003-12-07 10:51:05 UTC
Created attachment 12454 [details]
Screen shot of case where there's only room for two tabs and both must be clipped
Comment 8 jrojcek 2003-12-08 10:53:44 UTC
Answers:

1. Missing border pixel is not intentional. It is a mistake.
2. One pixel skipped in not intentional. It is a mistake.
3. Images with 3d highlight are correct. I don't know why is the 3d
effect missing in screenshot showing the clipped tabs. For correct
borders of tabs, please look at the main tabbed pain images in the
spec. (Lets treat the clipped images as an illustration of clipped state).

> Also:  Is it correct that you do not ever want to show text on 
> clipped tabs in Metal?

No, it is not. You should show the text (icon and close button) in
clipped tabs according the spec for tabs behavior.

> How does a selected, clipped tab paint its background?

I think as this is not very often situation, lets just keep it without
any border, indicating end of tab. I checked that, it doesn't look
very good, but I think it is acceptable. I will consult it with Dusan,
though. (He seems to have a different opinion ;-).

> It is impossible to have *both* the left clipped tab and the right
> clipped tab appear to have no text or icon and always be a fixed 
> size. One of them must be able to stretch.

As I said above, even the clipped tabs should show the icons and text.
Comment 9 _ tboudreau 2003-12-08 15:56:04 UTC
Rewrite of UI classes for metal has been merged.
Comment 10 Marian Mirilovic 2004-03-16 17:25:24 UTC
verified in [nb 3.6 rc1](200403141830)