This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 36820 - (No Property Editor) shown for compilers and executors in IDE run by XTest
Summary: (No Property Editor) shown for compilers and executors in IDE run by XTest
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 3.x
Hardware: PC Windows XP
: P1 blocker (vote)
Assignee: Jiri Skrivanek
URL:
Keywords: T9Y
Depends on:
Blocks: 28536
  Show dependency tree
 
Reported: 2003-10-24 14:42 UTC by Jiri Skrivanek
Modified: 2008-12-23 08:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screen shot (51.47 KB, image/gif)
2003-10-24 15:24 UTC, Jiri Skrivanek
Details
Diagnostic patch for use in conjunction with 28536.jar (969 bytes, patch)
2003-10-24 19:37 UTC, Jesse Glick
Details | Diff
ide.log with 28536.jar and diagnostic patch (39.67 KB, text/plain)
2003-10-27 09:43 UTC, Jiri Skrivanek
Details
Possible patch (1.06 KB, patch)
2003-10-27 16:31 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2003-10-24 14:42:48 UTC
(No Property Editor) is shown for compilers and
executors in property sheets when IDE is run by
XTest harness. It seems it is a regression of
issue 28536. It happens only in IDE build with new
window system. To reproduce:

cd java/test
ant -Dxtest.run.singletest=dummy
-Dxtest.ide.exit=false -Dnetbeans.home=<new winsys
IDE home>

Then open Tools|Options and navigate to
Editing|Java Sources and you will see (No Property
Editor) message instead of value of some properties.

It is important to fix it because it blocks
automated tests.
Comment 1 Peter Zavadsky 2003-10-24 14:45:41 UTC
It can't be fixed.

Options are now dialog, not TopComponent...thus changing the nodes
there doesn't influence the global activated nodes... which listens
the global properties window on.

Change the test. It is needless now.
Comment 2 Jiri Skrivanek 2003-10-24 15:22:00 UTC
I think it is misunderstanding. Please, look at screen shot where is
the problem.
Comment 3 Jiri Skrivanek 2003-10-24 15:24:54 UTC
Created attachment 11964 [details]
Screen shot
Comment 4 Jiri Skrivanek 2003-10-24 15:26:24 UTC
Reassigning to Jesse because he fixed 28536 and 35740 and he could
know where is the problem.
Comment 5 Jesse Glick 2003-10-24 19:08:50 UTC
Issue #35470, not 35740.

I can't reproduce any problem in my winsys build. I will check that
all sources are updated any try again.
Comment 6 Jesse Glick 2003-10-24 19:10:34 UTC
BTW I was using:

ant -f java/test/build.xml -Dxtest.run.singletest=dummy
-Dxtest.ide.exit=false
-Dnetbeans.home=/space/src/winsys_29836/nbbuild/netbeans
-Dxtest.jvmargs=-Xbootclasspath/p:/tmp/28536.jar

The context loader was always getting set to the NB loader, and the
property editors were there.

I am using Linux, JDK 1.4.2.

BTW the screenshot shows a problem in the editor for NbClassPath too.
Comment 7 Jesse Glick 2003-10-24 19:36:11 UTC
Sorry, I still can't reproduce.

Try running with the attached diagnostic patch to Main.java as well as
the bootcp patch JAR I mentioned and see when the bad call to
setContextClassLoader occurs (if that is indeed the problem). Might be
that #28536's hack has to be moved even earlier in startup, since it
seems that o.n.m.javahelp.HelpSetProcessor and
o.n.m.java.environment.LibraryProcessor use EQ early.
Comment 8 Jesse Glick 2003-10-24 19:37:52 UTC
Created attachment 11968 [details]
Diagnostic patch for use in conjunction with 28536.jar
Comment 9 Jiri Skrivanek 2003-10-27 09:42:18 UTC
I run it with 28536.jar and diagnostic patch. Jesse, could you please
look at ide.log?
Comment 10 Jiri Skrivanek 2003-10-27 09:43:27 UTC
Created attachment 11981 [details]
ide.log with 28536.jar and diagnostic patch
Comment 11 Jesse Glick 2003-10-27 13:47:19 UTC
Yeah, hack needs to be pushed further back in o.n.c.Main, I guess. No
idea why it would only cause a problem under winsys2, other than that
it may be stochastic - could depend on timing or GC changes.
Comment 12 Jesse Glick 2003-10-27 16:31:23 UTC
Created attachment 11987 [details]
Possible patch
Comment 13 Jesse Glick 2003-10-27 16:32:18 UTC
Please try the attached patch and see if it fixes the problem for you.
Since I cannot reproduce the bug I cannot tell if it is going to help.
In theory it should solve the problem.
Comment 14 Jiri Skrivanek 2003-10-29 13:31:35 UTC
Great! It fixed the problem.
Comment 15 Jesse Glick 2003-10-29 14:17:23 UTC
Good. Feel free to commit it yourself (after the usual clean build +
validation tests) or reassign to me and I will.
Comment 16 Jiri Skrivanek 2003-10-29 15:46:28 UTC
Patch integrated both to trunk and winsys_29836 branch:

/cvs/core/src/org/netbeans/core/Main.java,v  <--  Main.java
new revision: 1.173; previous revision: 1.172

/cvs/core/src/org/netbeans/core/Main.java,v  <--  Main.java
new revision: 1.157.2.12; previous revision: 1.157.2.11

Comment 17 Jiri Skrivanek 2003-10-30 07:59:29 UTC
Verified in winsys build where it failed before.