This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 36513 - [2003-11-12] Adapt search results window for the new window system
Summary: [2003-11-12] Adapt search results window for the new window system
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: Marian Petras
URL:
Keywords:
Depends on:
Blocks: 36118
  Show dependency tree
 
Reported: 2003-10-09 17:25 UTC by Tomas Pavek
Modified: 2003-12-11 14:27 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Pavek 2003-10-09 17:25:23 UTC 
Review how the ResultViewTopComponent should work
with the new window system. Floating TopComponents
will no more be supported, they will appear in the
editor area by default (that's a suggestion of
HIE). However we should consider also the
possibility to have the results as non-modal dialog.

See also issue 36119 which provides some
suggestions. Issue 36489 lists some problems
discovered so far (VCS outputs are mentioned).
General guidelines are summarized in issue 36487.
Comment 1 Tomas Pavek 2003-10-09 17:26:42 UTC 
See also issue 29836.
Comment 2 Tomas Pavek 2003-10-23 17:08:04 UTC 
For the winsys2 merge to trunk I suggest to make the results window a
dialog. Issue 36119 suggest to put it to editor, but I think it looks
quite ugly there as it is designed now, neither it is very comfortable
to use. I think floating non-modal dialog will work best for now.

That's all what should be done for the merge. After the merge we will
consider redesign of the results in accordance with possible redesign
of the whole search feature.
Comment 3 Marian Petras 2003-11-05 09:09:50 UTC 
Putting contents of the Search Results window into a floating
non-modal dialog has been approved by Jano Rojcek
(jrojcek@netbeans.org) which cares about UI changes of NetBeans. He
also suggested that the buttons at the bottom of the window be not
expanded along the whole bottom margin, but aligned to the right side
of the margin.
Comment 4 Marian Petras 2003-11-07 12:52:29 UTC 
Done in the trunk.

ResultViewTopComponent was renamed to ResultView as it is not a
subclass of TopComponent any more. It is a subclass of JPanel now. It
is presented in the form of a non-modal dialog using method
org.openide.DialogDisplayer.createDialog(...).
Comment 5 Tomas Pavek 2003-11-10 14:04:50 UTC 
Would be nice to remember bounds of the dialog so the user need not
move/resize it each time the search is performed. E.g. instead of
having weak ref. to the results component the whole dialog could be held.
Comment 6 Tomas Pavek 2003-11-11 17:43:54 UTC 
forgot to reopen, please consider what I wrote above
Comment 7 Marian Petras 2003-11-12 07:44:50 UTC 
OK, I am already working on it.
Comment 8 Tomas Pavek 2003-11-12 17:59:59 UTC 
Quick fix applied as I suggested. Look at:

/cvs/utilities/src/org/netbeans/modules/search/SearchPerformer.java
new revision: 1.23; previous revision: 1.22