This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 35816 - Strange FileSystemRefreshAction menu label
Summary: Strange FileSystemRefreshAction menu label
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: rmatous
URL:
Keywords: T9Y, UI
Depends on:
Blocks:
 
Reported: 2003-08-28 08:04 UTC by Jiri Skrivanek
Modified: 2008-12-22 21:22 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2003-08-28 08:04:32 UTC 
If you run IDE to show bundle properties annotation

runide.exe -nosplash
-J-Dorg.openide.util.NbBundle.DEBUG=true

and invoke popup menu on a folder, you see
"Refresh Folder" label there. BUT if you run IDE
regularly, you see only "Refresh". I wonder where
is that "Refresh" label from. In class
org.openide.actions.FileSystemRefreshAction there
is the following

NbBundle.getBundle(org.openide.loaders.DataObject.class).getString
("LAB_Refresh");

so, one could expect that there should "Refresh
Folder" from
org.openide.loaders.Bundle.properties. What is the
magic?
Comment 1 Jiri Skrivanek 2003-08-28 08:38:34 UTC 
Jesse, you may know what's wrong because it starts in build 20030826,
i.e. after your changes in actions.
Comment 2 Jesse Glick 2003-08-28 14:24:38 UTC 
I have no idea why anything would have changed as a result of my
actions work, but anyway the label "Refresh" is from the special
refresh action (org.netbeans.core.ExFsRefreshAction) put on
ExLocalFileSystem's - the kind of FS you get when you mount a
directory explicitly - or JAR files. If you have a plain
LocalFileSystem, you get "Refresh Folder". Has nothing to do with
bundle debug mode AFAIK.

One or the other label should be chosen for consistency.
Comment 3 Jiri Skrivanek 2003-08-28 15:08:21 UTC 
I am sorry for blaming you for that :-) Anyway, in bundle debug mode
there is "Refresh Folder" and in regular IDE there is "Refresh" (both
for the sampledir FS).
Would it be a solution "ExFsRefreshAction extend
FileSystemRefreshAction" and do not override getName() method? Just a
guess.
Comment 4 Jesse Glick 2003-08-28 15:25:37 UTC 
"I am sorry for blaming you for that" - well, certainly something I
did might have caused a change in some action. The code is behaving
the way it is written if it shows "Refresh" for ExLFS (e.g. a regular
mount you added) and "Refresh Folder" for LFS (e.g. sampledir), as it
does for me; no idea why it would have behaved otherwise *before* now,
since "Refresh" on ExLFS has been in place for a while.

"Anyway, in bundle debug mode there is "Refresh Folder" and in regular
IDE there is "Refresh" (both for the sampledir FS)." - I just tried a
dev build with a fresh userdir and sampledir has "Refresh Folder".
With bundle debugging, sampledir shows "R. F." from loaders.Bundle as
expected; another mount shows "R." from core.Bundle as expected.

I just tried with an Aug 21st dev build, and the behavior is the same.
Maybe your tests were somehow broken before.
Comment 5 rmatous 2003-09-30 16:16:00 UTC 
Fixed in trunk:
/cvs/core/src/org/netbeans/core/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.372; previous revision: 1.371
Comment 6 Jiri Skrivanek 2003-10-01 08:12:30 UTC 
Verified.