This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34902 - "Apply Patch..." should have a better name
Summary: "Apply Patch..." should have a better name
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jiri Kovalsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-12 01:48 UTC by Thomas Preisler
Modified: 2003-12-11 14:20 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Preisler 2003-07-12 01:48:29 UTC
The cvs module adds a menu item called "Apply
Patch..." to the Tools menu. The name "Apply
Patch..." doesn't mean anything to users who are
not familiar with the cvs module. Not even to
regular cvs users. I suggest renaming it to for
instance "Apply CVS Patch..." to indicate it is a
cvs action and also to be consistent with other
cvs actions that all have CSV in their names.

We would like this fixed in the Rainier release
(release35R) although it is not a very high
priority to us.
Comment 1 Jiri Kovalsky 2003-07-14 08:52:53 UTC
Actually this is a feature of Diff module although I agree that it has
very strong relation to CVS. First of all we need HIE's point of view.
Gabo, please provide your decision as soon as possible. This one is
hurrying ...
Comment 2 Gabriel Tichy 2003-07-14 10:15:15 UTC
Maybe it's not very self-explanatory menu item, but which one really
is? User simply needs to know what does term "patch" mean.
HIE suggests to leave it as it is. "CVS" in the name cannot really
improve anything, it can even confuse.
Comment 3 Richard Gregor 2003-07-14 10:44:21 UTC
Closed as wontfix based on Gabriel comment.
Comment 4 Jiri Kovalsky 2003-07-14 12:41:52 UTC
Okay, verifying then.
Comment 5 David-john Burrowes 2003-08-11 20:39:42 UTC
Actually, I do agree a with Thomas, who filed the issue.  I don't
think it is clear what "patch" means, in this case.  Does this install
an OS patch?  Does it install a patch to NetBeans?  Or a patch to a
source file?  Or some other kind of patch?  With no other explanation,
I personally would assume it would be used to patch NetBeans in some
way.  But, the online help tells me it is used to apply a patch to one
or more files in the filesystems.  Perhaps giving it a name like
"Apply Diff Patch..." would at least make it clearer.  For folks that
don't use the diff/patch mechanism (and those folks definitely exist),
this menu item doesn't give enough information to help someone
understand whether they should ignore the item or not. 
Comment 6 _ gordonp 2003-08-13 16:48:32 UTC
On 2003-07-14 Gabriel Tichy said "HIE suggests to leave it as it is".
This bug was filed by HIE so I don't see
how that can be true.

We feel this is VERY confusing to our C/C++ developers
who know nothing about netbeans except what we tell
them. Please fix soon so we can get this in our EA
release.
Comment 7 Gabriel Tichy 2003-08-14 10:12:38 UTC
Actually, David is right, I didn't consider the confusion with other
kind of patches. "Apply Diff Patch..." seems to be clearer.
Comment 8 Jiri Kovalsky 2003-08-14 15:23:51 UTC
Okay, this is exceptional. I am gonna take it ...
Comment 9 Jiri Kovalsky 2003-08-14 16:03:37 UTC
Fixed in the main trunk and release35R branches.

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.19; previous revision: 1.18
done

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.15.4.2.16.1; previous revision: 1.15.4.2
done

Could you Gordon or David verify the fix in next build of your product
? Thanks.
Comment 10 Martin Entlicher 2003-09-01 16:13:28 UTC
Thanks Jiri for fixing this. I've merged your changes to the
prj40_prototype branch:

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.17.8.2; previous revision: 1.17.8.1
Comment 11 dmladek 2003-09-02 12:09:23 UTC
Well,
actually I tested on NBdev40-2003-09-02-0100 and I must confirm this
fix as good;-)

But OTOH if this should be realy perfect fix, I suggest also change
accordingly Dialog Title name from current one:
"Select The Patch For Files ....." to
"Select The Diff Patch For Files ....." too.

What do you think? I'm reopening
Comment 12 dmladek 2003-09-02 12:12:02 UTC
but anyway...
Thank you Jiri for quick and proper reaction;-)
Comment 13 Martin Entlicher 2003-09-02 14:44:27 UTC
O.K. that makes sense.

Fixed in the main trunk and prj40_prototype branch:

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.20; previous revision: 1.19

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.17.8.3; previous revision: 1.17.8.2


Should this go to the release35R branch as well?
Comment 14 Jiri Kovalsky 2003-09-02 16:04:06 UTC
I am afraid it's only up to Gordon's decision.
Comment 15 _ gordonp 2003-09-02 19:08:33 UTC
Please fix in release35R as well.
Comment 16 Martin Entlicher 2003-09-03 15:23:45 UTC
Fixed in release35R branch as well:

Checking in Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.15.4.2.16.2; previous revision: 1.15.4.2.16.1
Comment 17 Jiri Kovalsky 2003-10-08 13:08:46 UTC
Perfect, verified in projects development build #200309190000 and
trunk build #200310010100 of NetBeans 4.0.