This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34069 - Branding JARs must be colocated with base JARs even w/ netbeans.dirs
Summary: Branding JARs must be colocated with base JARs even w/ netbeans.dirs
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: API, ARCH
Depends on:
Blocks:
 
Reported: 2003-05-30 22:18 UTC by _ gordonp
Modified: 2008-12-23 08:35 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ gordonp 2003-05-30 22:18:03 UTC 
The Rainier release is using the netbeans.dirs
property so we can have a netbeans directory
containing
JUST netbeans files and a SUNWspro directory
containing
the Rainer added value modules.

For the most part this works fine. The area it doesn't
work is branding. If my branding module is in
SUNWspro/modules and I call runide.sh with -branding
and the appropriate netbeans.dirs flag my branding
module isn't used.
Comment 1 Jesse Glick 2003-06-02 16:29:34 UTC 
As (currently) designed - branding files must be located in locale/
subdirs relative to the location of the master files - just like
localization. This means that to brand a NB platform or IDE dir, you
must add branding files within that directory hierarchy. If all your
files are "owned" by some native package, this is no more than an
aesthetic problem; the packaging system "knows" which file is which.

I made this clear some time ago on tools-arch and no one seemed to
care much at the time. So treating this as an enhancement to permit
localization & branding JARs to be located in other areas for
aesthetic reasons.
Comment 2 Jesse Glick 2003-06-02 16:30:33 UTC 
Would be an API change too.
Comment 3 Jesse Glick 2003-06-27 00:40:24 UTC 
Have a working patch that implements this RFE.
Comment 4 Jesse Glick 2003-06-27 15:36:49 UTC 
committed   * Up-To-Date  1.12       
core/bootstrap/src/org/netbeans/Main.java
committed   * Up-To-Date  1.23       
core/src/org/netbeans/core/modules/Util.java
committed   * Up-To-Date  1.7        
openide/api/doc/org/openide/doc-files/i18n-branding.html
Comment 5 _ gordonp 2003-07-08 16:10:32 UTC 
Please merge this fix into the release35R branch. The
fix is needed for the Rainier release which uses that
branch.
Comment 6 Jesse Glick 2003-07-08 16:14:47 UTC 
Fine, but don't reopen it just for that; it is still FIXED for 4.0.
Comment 7 Jesse Glick 2003-07-08 16:19:29 UTC 
Merged to branch release35R:

Checking in bootstrap/src/org/netbeans/Main.java;
/cvs/core/bootstrap/src/org/netbeans/Main.java,v  <--  Main.java
new revision: 1.8.2.1.16.1; previous revision: 1.8.2.1
done
Checking in src/org/netbeans/core/modules/Util.java;
/cvs/core/src/org/netbeans/core/modules/Util.java,v  <--  Util.java
new revision: 1.20.44.1; previous revision: 1.20
done