This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33884 - I18N - Some parts of xslt window do not fully appear in other locales
Summary: I18N - Some parts of xslt window do not fully appear in other locales
Status: VERIFIED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: XSL (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: issues@xml
URL:
Keywords: I18N
Depends on:
Blocks: 33246
  Show dependency tree
 
Reported: 2003-05-24 17:47 UTC by Ken Frank
Modified: 2007-09-25 01:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
xslt window (9.87 KB, image/gif)
2003-05-24 17:49 UTC, Ken Frank
Details
The patch (14.58 KB, patch)
2003-05-28 10:04 UTC, _ pkuzel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-24 17:47:20 UTC
Using pseudo localized product, with each message
or label
having additional multibyte text, and using
-fontsize 16
option, running in Chinese locale,
create xml file; in editor choose xslt
transformation and look at attachment of that
window - there are several places where there are
resizing issues - words process overlap does not
show completely, xml source and xslt script areas
overlap and the word "overwrite" dors not show
completely.Chinese localization will use a larger
font than default
one now used so these issues will be more visible
to them,
but this can also be viewed as a general or a11y
issue
since may be visible to users in english locale
who use
larger fonts.

Assumption is that user should be able to see
all items in a given window when it appears and
should
not need to resize it to see those things.

That is, the UI area or window should dynamically
resize
itself to show the needed contents.
(this does not apply to contents of textfields,
areas
controlled by scrollbars or vertical resizing
controls
like in options window)

To emulate in non multibyte locale without
multibyte
in messages or longer messages, you may need to
run
with fontsize 18 or 20 to see what we are seeing
with
fontsize 16. Even with larger sizes, it may not be
seen
exactly the same due to the effect of multibyte
and longer
strings.

This issue is marked with the FONTSIZE keywork;
bugs so
marked will not appear on quality dashboards and
will not
need to be waived or fixed for English FCS
products of this
release.

For Netbeans issues, this will be marked as
blocking 33246
Comment 1 Ken Frank 2003-05-24 17:49:54 UTC
Created attachment 10428 [details]
xslt window
Comment 2 _ pkuzel 2003-05-26 10:22:28 UTC
TransformPanel invokes:
  setPreferredSize(new java.awt.Dimension(600, 155));
what is plain wrong. pack() should be called instead and all componets
should use abstract sizing hints (like number of columns for text fields).
Comment 3 _ pkuzel 2003-05-26 13:44:18 UTC
in prj40_prototype branch.
Comment 4 _ pkuzel 2003-05-28 10:04:35 UTC
Created attachment 10482 [details]
The patch
Comment 5 Martin Roskanin 2003-06-13 14:57:42 UTC
I would like to propose the following fix into the [release35]:

Index: src/org/netbeans/modules/xsl/ui/TransformPanel.java
===================================================================
RCS file:
/cvs/xml/xsl/src/org/netbeans/modules/xsl/ui/TransformPanel.java,v
retrieving revision 1.10
diff -r1.10 TransformPanel.java
89a90,92
> 
>         // fix of #33884
>         setPreferredSize(null);


Mila could you please to review it? Thanks.
Comment 6 Miloslav Metelka 2003-06-13 15:12:00 UTC
I approve the fix.
Comment 7 Martin Roskanin 2003-06-13 15:36:35 UTC
fixed in [release35]

/cvs/xml/xsl/src/org/netbeans/modules/xsl/ui/TransformPanel.java,v 
<--  TransformPanel.java
new revision: 1.10.2.1; previous revision: 1.10
Comment 8 Keiichi Oono 2003-07-23 11:53:37 UTC
Verified in nevada build030721.