This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33790 - I18N - Some parts of an autoupdate window do not fully appear in other locales when translated and/or using larger font sizes
Summary: I18N - Some parts of an autoupdate window do not fully appear in other locale...
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Autoupdate (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: _ tboudreau
URL:
Keywords: I18N
Depends on:
Blocks: 33246 37578
  Show dependency tree
 
Reported: 2003-05-20 19:47 UTC by Ken Frank
Modified: 2004-04-02 16:28 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
panel of update center wizard (27.62 KB, image/gif)
2003-05-20 19:49 UTC, Ken Frank 		Details
update center wizard - another resize issue (10.01 KB, image/gif)
2003-05-23 21:04 UTC, Ken Frank 		Details
update center wizard -another resize issue (30.42 KB, image/gif)
2003-05-23 21:06 UTC, Ken Frank 		Details
another view of the issue, before resizing (24.25 KB, image/gif)
2003-05-27 23:32 UTC, Ken Frank 		Details
different view of issue,after resize (14.56 KB, image/gif)
2003-05-27 23:34 UTC, Ken Frank 		Details
remainder of the fixes (14.38 KB, patch)
2003-06-20 11:49 UTC, _ tboudreau 		Details | Diff
s1s5-fcs autoupdate screenshot (20.95 KB, image/png)
2003-07-24 16:22 UTC, Lukas Hasik 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-20 19:47:27 UTC 
Using pseudo localized product, with each message
or label
having additional multibyte text, and using
-fontsize 16 option,
running in chinese locale, part
of the window in attached gif, at botton,
a line does not show fully without it needing 
to be resized.
Chinese localization will use a larger font than
default
one now used so these issues will be more visible
to them,
but this can also be viewed as a general or a11y
issue
since may be visible to users in english locale
who use larger
fonts.

Assumption is that user should be able to see
all items in a given window when it appears and
should
not need to resize it to see those things.

That is, the UI area or window should dynamically
resize itself
to show the needed contents.
(this does not apply to contents of textfields,
areas controlled
by scrollbars or vertical resizing controls like
in options wind
ow)

If this issue also mentions that a message or
label
is shown in a smaller font than the rest of the
messages,
its just to ask if the setting of that font's size
was done
relative to the global font vs being hardcoded.
Please let me
know if so and I'll file separate issue.

To emulate in non multibyte locale without
multibyte
in messages or longer messages, you may need to
run
with fontsize 18 or 20 to see what we are seeing
with
fontsize 16. Even with larger sizes, it may not be
seen exactly
the same due to the effect of multibyte and longer
strings.

This issue is marked with the FONTSIZE keywork;
bugs so marked
will not appear on quality dashboards and will not
need
to be waived or fixed for English FCS products of
this release.

For Netbeans issues, this will be marked as
blocking 33246.
Comment 1 Ken Frank 2003-05-20 19:49:34 UTC 
Created attachment 10357 [details]
panel of update center wizard
Comment 2 Ken Frank 2003-05-23 21:04:39 UTC 
Created attachment 10410 [details]
update center wizard - another resize issue
Comment 3 Ken Frank 2003-05-23 21:06:06 UTC 
Created attachment 10411 [details]
update center wizard -another resize issue
Comment 4 Ken Frank 2003-05-23 21:06:49 UTC 
please ignore attachment shot_0520_01.gif, that is not
related to this area.
ken.frank@sun.com
Comment 5 Ken Frank 2003-05-27 23:28:02 UTC 
Sometimes, the line that needs resizing is not visible
at all, as in 2 additional gifs; this seems
to vary somewhat on platform and length of strings,
but this is same issue as originally filed.
Comment 6 Ken Frank 2003-05-27 23:32:50 UTC 
Created attachment 10475 [details]
another view of the issue, before resizing
Comment 7 Ken Frank 2003-05-27 23:34:03 UTC 
Created attachment 10476 [details]
different view of issue,after resize
Comment 8 David Simonek 2003-06-12 18:47:28 UTC 
Tim, please could you take a look on some of these panels. Big thanks!
Note, I made some changes to general wizard sizing policy that may
solve some of mentioned problems, so please first checkout from main
trunk and go through the wizards to see what left. Thx.
Comment 9 _ tboudreau 2003-06-13 10:46:42 UTC 
Fixed in trunk.  

Note the AutoResizeTable class - it is a JTable which checks
the font size the first time it is painted, and adjusts its
row height if it's too small for the font.  May be useful
elsewhere.  I don't know why JTable doesn't do this to
begin with - it would be nice.

Dafe: note one problem with the revisions to the wizard sizing policy:
 The window needs to be re-centered.  On panel 3
of this wizard, at 1280x1024, the wizard panel becomes larger,
and the right edge is off the screen.
Comment 10 _ tboudreau 2003-06-16 02:06:25 UTC 
Committed to 3.5 branch.
Comment 11 Lukas Hasik 2003-06-18 13:39:47 UTC 
have to reopen.
this are still not fixed...
run with fontsize 18. and the end of notice is hidden and user even
doesn't notice that something is missing...

<a
href="http://www.netbeans.org/issues/showattachment.cgi?attach_id=10475&file=step1">before
resize</a>
<a
href="http://www.netbeans.org/issues/showattachment.cgi?attach_id=10476&file=step1.afterresize.gif">after
resize</a>
Comment 12 David Simonek 2003-06-18 18:30:43 UTC 
Trying to advice - check if JTextAreas have their preferred column and
row number property set correctly, this affects their computed
preferred size. Will check the resizing policy.
Comment 13 _ tboudreau 2003-06-19 17:35:50 UTC 
The content of the panel in the problem screenshot is plugged
in by the S1S closed source branding - they are providing a 
"customizer" component which supplies the content.

I would be happy to work with the author of this component to ensure
that it is set up correctly, but I do not know where the source 
code to the component that is displayed lives - it is not part of
NetBeans.  You probably want to file a bug in BugTraq for this
particular panel.

Closing this issue as fixed - as far as I know, it is fixed on the
NetBeans side of things.  If the supplied component returns
a correct preferred size scaled based on font size, it should 
be sized correctly - this is the case with all of the other
panels in the wizard now, so I don't think it's the sizing
policy causing the problem.

Again, I'll be happy to help with it on the closed source side,
but I don't know how to find the source code for this first
panel's inner component.
Comment 14 David Simonek 2003-06-20 10:11:32 UTC 
Tim, I searched and dig around and I found that autoupdate wizard
panels still return strange preferred sizes - (550, 400) for all all
three first panels (don't know for others).
This causes resizing policy not to be invoked, which means centering
is not done. On other wizards (Setup Wizard, New Wizard) it works
well, so I assume there is something strange with autoupdate panels.

Here is my debug messages, as I pressed next button to get from first
panel to second, third and fourth. "prev size" is actual size of panel
which is being left by clicking "next" button, "cur pref size" is
preferred size of newly appeared panel. You can see that preferred
size and actual size in next round differ, which is a mistake IMO.

Trying to resize...
prev size: java.awt.Dimension[width=550,height=400]
cur pref size: java.awt.Dimension[width=550,height=400]
parent window is null? false
Trying to resize...
prev size: java.awt.Dimension[width=676,height=400]
cur pref size: java.awt.Dimension[width=550,height=400]
parent window is null? false
Trying to resize...
prev size: java.awt.Dimension[width=917,height=400]
cur pref size: java.awt.Dimension[width=550,height=400]
Comment 15 _ tboudreau 2003-06-20 11:49:14 UTC 
Created attachment 10752 [details]
remainder of the fixes
Comment 16 David Simonek 2003-06-23 10:37:17 UTC 
patch reviewed, OK. Sorry for the delay, I was out of office.
Comment 17 gautham mudra 2003-06-29 21:51:20 UTC 
still could not see one of the fix(as in gif file step1).

Configuration:
Build:Nevada0615
OS:Solaris9
JDK:jdk1.4.1_02
Locale:zh_CN
Comment 18 _ tboudreau 2003-06-29 23:34:01 UTC 
That is the screen I was referring to when I commented earlier
that there was one screen which is part of the commercial
product, but which is not part of the NetBeans codebase.

I do not have a copy of the source code for the panel in this
screenshot, as I work on NetBeans, not the commercial product.
There is a LoginPanel.java in the source base, but it is not
used in NetBeans - and it is just a container for a component
supplied from elsewhere.  I have a suspicion that the 
component being supplied is returning an incorrect 
preferred size, and that's the source of the problem.

At the same time, I am not the author or maintainer of
the autoupdate module, so I don't know the intricacies
of how the branding layer for the commercial product
supplies this customizer.  There is no code in LoginPanel
that explicitly sets the size of this step in the wizard,
so I'm assuming the inner component is doing that.  You
may want to have a conversation with whoever handles
engineering for autoupdate in the commercial product.
Comment 19 Lukas Hasik 2003-07-24 16:22:24 UTC 
Created attachment 11117 [details]
s1s5-fcs autoupdate screenshot
Comment 20 Lukas Hasik 2004-04-02 16:28:18 UTC 
v