This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33698 - I18N - hardcoded font sizes in source code not relative to global font
Summary: I18N - hardcoded font sizes in source code not relative to global font
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Javadoc (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: issues@java
URL:
Keywords: I18N
Depends on:
Blocks: 33246
  Show dependency tree
 
Reported: 2003-05-18 17:34 UTC by Ken Frank
Modified: 2003-07-01 07:45 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
diff solving this issue, was tested (1.40 KB, patch)
2003-05-29 17:29 UTC, David Simonek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-18 17:34:40 UTC
Analysis of source code of current product shows
some some calls to setFont that hardcode a certain
font
size that isn't relative to global font size.

Usually, fonts are obtained from the global font
size
value of the product. But sometimes specific font
sizes
are wanted, and if so, they should be assigned
based on
a relative offset from the default font size
instead of
as a specific size.

This is because the localized products will soon
be able
to set the default font size needed for proper
appearance
of their character sets, and hardcoded fonts may
be too
small for meeting those requirements.

If there are other parts of code where hardcoded
font size
might be set other than setFont, can you also
review it?

Issue will be marked with FONTSIZE keyword which
means it
will not be placed on dashboards for 3.5 or nevada
as
needing waiving but fixes still need to be for the
ML
release of 3.5 and Nevada. Mark as P2 since for
current
l10n.

Also will mark as blocking 33246, general task on
resizing of windows, which deals also with font
size
setting.

Specific calls to setFont seen in source code:

jTextField2.setFont(new Font("Dialog", 0, 11));
jLabel1.setFont(new Font("Dialog", 0, 11));
Comment 1 David Simonek 2003-05-29 17:29:59 UTC
Created attachment 10513 [details]
diff solving this issue, was tested
Comment 2 David Simonek 2003-05-30 14:15:55 UTC
fixed in main trunk.

cvs output:

/cvs/javadoc/src/org/netbeans/modules/javadoc/DocSourcesManager.java,v
 <--  DocSourcesManager.java
new revision: 1.10; previous revision: 1.9
Comment 3 Ken Frank 2003-06-10 19:29:15 UTC
If verification should be in ide itself,
can you tell us which actual windows are
the ones related to the 2 code lines below
that were fixed ?

ken.frank@sun.com
Comment 4 Vitezslav Stejskal 2003-06-12 10:21:22 UTC
I reviewed the diff and fix seems to be ok.
Comment 6 Vitezslav Stejskal 2003-06-12 15:30:27 UTC
Merged to release35 branch.
Comment 7 naveen 2003-07-01 07:45:40 UTC
Build : 0625 Zh ML Build
JDK : 1.4.1_02
OS : Win2K Zh Locale
Pseudolocalized : Yes

Verified the fix using above configuration, hence marking the bug as
verified.

Thanks
Naveen