This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33672 - I18N - hardcoded font sizes in source code not relative to global font
Summary: I18N - hardcoded font sizes in source code not relative to global font
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: I18N
Depends on:
Blocks: 33246
  Show dependency tree
 
Reported: 2003-05-15 23:23 UTC by Ken Frank
Modified: 2007-01-04 17:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The contextual diff of the fix. (3.75 KB, patch)
2003-06-11 10:06 UTC, Martin Entlicher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2003-05-15 23:23:24 UTC
Analysis of source code of current product shows
some some calls to setFont that hardcode a certain
font
size that isn't relative to global font size.

Usually, fonts are obtained from the global font
size
value of the product. But if specific font sizes
are needed, they should be assigned based on a
relative
offset from the default font size instead of as a
specific
size.

This is because the localized products will soon
be able t
o
set the default font size needed for proper
appearance
of their character sets, and hardcoded fonts may
be too
small for meeting those requirements.

If there are other parts of code where hardcoded
font size
might be set other than setFont, can you also
review
that ?

Tim Boudreau can provide information also on
general
issue.

Issue will be marked with FONTSIZE keyword which
means it
will not be placed on dashboards for 3.5 or nevada
as
needing waiving but fixes still need to be for the
ML
release of 3.5 and Nevada.

Specific calls to setFont seen in source code:
txStatus.setFont(new java.awt.Font("Dialog", 1,
12));
Comment 1 Martin Entlicher 2003-05-16 10:10:03 UTC
I've found following classes that set the font size:

vcscore/src/org/netbeans/modules/vcscore/ui/views/types/LogInfoPanel.java
and
javacvs/src/org/netbeans/modules/cvsclient/commands/status/StatusInfoPanel.java

It needs to be found how to replace that. Font.deriveFont() is
probably the right way to go.
Comment 2 Martin Entlicher 2003-05-19 10:15:35 UTC
Fixed in the main trunk in javacvs module:

/cvs/javacvs/src/org/netbeans/modules/cvsclient/commands/status/StatusInfoPanel.java,v 
<--  StatusInfoPanel.java
new revision: 1.37; previous revision: 1.36
/cvs/javacvs/src/org/netbeans/modules/cvsclient/commands/status/StatusInfoPanel.form,v 
<--  StatusInfoPanel.form
new revision: 1.15; previous revision: 1.14
Comment 3 Ken Frank 2003-06-10 19:27:31 UTC
If this needs verification in running ide,
can you tell us which specific window is the
one related to the code line fixed ?

ken.frank@sun.com
Comment 4 Martin Entlicher 2003-06-11 09:41:02 UTC
Mount a Built-in CVS filesystem and do CVS -> Status on an arbitrary
file. A dialog will be opened. The affected text is the bold status
text.
Comment 5 Martin Entlicher 2003-06-11 10:06:40 UTC
Created attachment 10647 [details]
The contextual diff of the fix.
Comment 6 Martin Entlicher 2003-06-11 14:41:51 UTC
Fixed in release35 branch:

Checking in StatusInfoPanel.form;
/cvs/javacvs/src/org/netbeans/modules/cvsclient/commands/status/StatusInfoPanel.form,v 
<--  StatusInfoPanel.form
new revision: 1.13.8.2; previous revision: 1.13.8.1
done
Checking in StatusInfoPanel.java;
/cvs/javacvs/src/org/netbeans/modules/cvsclient/commands/status/StatusInfoPanel.java,v 
<--  StatusInfoPanel.java
new revision: 1.35.2.2; previous revision: 1.35.2.1
done
Comment 7 hiroshiy 2003-06-20 09:32:01 UTC
I've verified the fixing in followings.

  - S1S Nevada Build (Build 030617).
  - Solaris 9 Chinese, Win2000 Chinese
  - fontsize: 16

Thank you for your fixing.

Hiroshi
Comment 8 Jiri Kovalsky 2003-07-22 10:25:57 UTC
Confirming as fixed in Sun ONE Studio 5.0 Standard Edition build
#030528 patched with fontsize-fixes NBMs build #030716.