This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33149 - Names for annotation type are odd
Summary: Names for annotation type are odd
Status: VERIFIED WONTFIX
Alias: None
Product: javaee
Classification: Unclassified
Component: Debugger (show other bugs)
Version: 3.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: Martin Grebac
URL:
Keywords: UI
: 34681 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-04-23 08:08 UTC by _ rkubacki
Modified: 2005-12-14 14:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2003-04-23 08:08:47 UTC
Tools | Options | Editing | Annotation Types: 
'Pink JSP breakpoint' and 'Disabled pink JSP
breakpoint' are not very descriptive and it is not
clear what they mean.
Comment 1 Martin Grebac 2003-06-30 09:02:11 UTC
*** Issue 34681 has been marked as a duplicate of this issue. ***
Comment 2 Martin Grebac 2003-06-30 09:06:11 UTC
OK, let's come up with suggestions.
Comment 3 Ann Sunhachawee 2003-07-08 20:00:27 UTC
There are a few other priorities to attend to at the moment, but just
wanted to capture some of the discussion i've had with Martin on this
subject for future reference. This isn't the final solution, and will
have to be worked on more. 

My first suggestion is that in the Tools | Options window, that only
one Breakpoint should show up under the Editing category. All the
other breakpoints (e.g. the underlying implementation is Java
breakpoint, JSP breakpoint, JSP/Servlet Breakpoint) should just use
the same representation. (For example, I have a preference to show the
breakpoint foreground as neon blue. So i change the foreground of
"Breakpoint" to blue.  All breakpoints should use neon blue) I'm not
sure if this is a major implementation issue, but it would be a very
nice UI win for the user, in that users don't have to scratch their
head figuring out what each type of breakpoint means.

Here's more info from Martin:
>I'd like to remove the JSP/Servlet breakpoint, but there >are some
problems with this. My perspective is that JSP >Breakpoint stays as it
is now, but it's presence in the Add >breakpoint window will be: 
'JSP' and type 'Line' - to be >consistent with other (java)
breakpoints. I'm trying to use >the Java breakpoints instead of
JSP/Servlet, but I'm still >not sure if that will be possible and will
not lead to any >future problems. As a possible part-solution, I think
we >could use the JSP category for both JSP and JSP/Servlet, >and for
JSP the type would be 'JSP Line' or 'JSP line >breakpoint', and for
servlet it would be 'Servlet line'.
>
>> Also, in S1S5, I see "JSP Breakpoint" and "Pink JSP >>Breakpoint".
Not sure why both exist.
>
>Well, I didn't choose the names, I used the old ones ;O) >because I
couldn't find anything more reasonable and less >confusing than 'pink'
;O).
>The Pink JSP breakpoint is an annotation of placeholder for >servlet
breakpoint - when you place a breakpoint into a >servlet, it is shown
in corresponding jsp, too. And that's >what pink jsp breakpoint
annotations are for (their pink is >more pink than the other
breakpoints' pink ;O) ). I assume >that pink JSP breakpoint annotation
will have to stay, >unless we want to stop showing the breakpoint
placeholders. >But we certainly have to choose some other annotation name.
>
> Martin 
Comment 4 Martin Grebac 2003-07-09 08:55:09 UTC
Well, the suggestion is doable and easy - all our breakpoints would
just use 'Breakpoint' and 'Disabled breakpoint' annotations provided
by debuggercore. 

 But I think it would be confusing to the user - currently - user
places a breakpoint into the servlet, and it is shown also in the
corresponding jsp as a 'light' breakpoint (because it is removed when
the jsp changes).

 With the suggested change, all the breakpoints in the jsp would look
the same, but only some of them (and the user can't see which ones)
will be removed magically when the jsp is changed.
Comment 5 _ tboudreau 2003-07-14 06:19:24 UTC
Well, if the breakpoints are going to disappear when the
servlet is changed anyway, that's the confusing part, not
what name/color they have.  Just call its
"Servlet breakpoint in JSP" or something like that if you
have to call it something.  

Suggestion:  
 - Remove/hide the system option for the "Pink" breakpoints
 - Use whatever color is specified for the servlet breakpoint
   for the JSP, but do something like Color.brighter() to
   make it visibly different.  The point is the user 
   shouldn't need to decide
Comment 6 Martin Grebac 2004-01-12 18:10:51 UTC
we don't have pink jsp breakpoints in 3.6
Comment 7 Jiri Skrivanek 2005-12-14 14:44:15 UTC
Verified assuming reporter agrees with resolution.