This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32760 - VCS Refresh action does not check for external modifications of files in the refreshed folder.
Summary: VCS Refresh action does not check for external modifications of files in the ...
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-09 12:41 UTC by Martin Entlicher
Modified: 2003-04-10 13:58 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
The context diff, that fix this problem. (3.80 KB, patch)
2003-04-09 13:14 UTC, Martin Entlicher 		Details | Diff
The binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder. (74.55 KB, application/octet-stream)
2003-04-09 13:17 UTC, Martin Entlicher 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2003-04-09 12:41:54 UTC 
There's a problem, that the refresh action does
not fully replace the periodic refresh
functionality.

My original impression was, that the periodic
refresh refreshes only the content of folders, but
to my surprise it refreshes also the content of
individual files (even though the name of the
appropriate method in
org.openide.filesystems.RefreshRequest is
"existingFolders", it collects both folders and
data).

Thus for the VCS refresh action to be compatible
with this approach, the data FileObjects should be
refreshed as well.

BTW: similar P1 defect should be perhaps also
filed for org.openide.filesystems.RefreshAction.
I'm ccing Radek Matous because of that.
Comment 1 Martin Entlicher 2003-04-09 12:43:42 UTC 
This problem was originally discussed in issue #28352. See the
description of that issue for why is this important.
Comment 2 Martin Entlicher 2003-04-09 13:12:15 UTC 
The problem is fixed in the main trunk. The refresh action now refresh
the content of all files in the given folder:

/cvs/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCache.java,v 
<--  VcsCache.java
new revision: 1.58; previous revision: 1.57
/cvs/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java,v 
<--  VcsFileSystem.java
new revision: 1.219; previous revision: 1.218
Comment 3 Martin Entlicher 2003-04-09 13:14:18 UTC 
Created attachment 9802 [details]
The context diff, that fix this problem.
Comment 4 Martin Entlicher 2003-04-09 13:17:40 UTC 
Created attachment 9803 [details]
The binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder.
Comment 5 rmatous 2003-04-09 13:34:33 UTC 
This patch seems to be OK.
Comment 6 dmladek 2003-04-09 18:05:27 UTC 
The patch was tested on Sun ONE Studio 5, Standard Edition (Build
030406), and it is correct, thus marking this bug as verified
Comment 7 _ ttran 2003-04-10 12:36:13 UTC 
approved for 3.5
Comment 8 Martin Entlicher 2003-04-10 13:58:05 UTC 
Thanks for the review, verification and approval. The fix is merged
into release35 branch:

Checking in src/org/netbeans/modules/vcscore/VcsFileSystem.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java,v 
<--  VcsFileSystem.java
Checking in src/org/netbeans/modules/vcscore/caching/VcsCache.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/caching/VcsCache.java,v 
<--  VcsCache.java