This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32731 - Recursion in VCS cache
Summary: Recursion in VCS cache
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-08 15:23 UTC by tboerkel
Modified: 2004-02-13 11:57 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Thread dump (110.72 KB, text/plain)
2003-04-08 15:24 UTC, tboerkel
Details
Errors during startup. (423.06 KB, text/plain)
2003-04-09 08:01 UTC, tboerkel
Details
The binary patch. To apply, copy into <NB-install>\modules\autoload\patches\org-netbeans-modules-vcscore\ folder and copy Patch32731.jar into it. Verify in ide.log, that the patch was applied. (74.78 KB, application/octet-stream)
2003-04-10 16:38 UTC, Martin Entlicher
Details
New thread dump. (110.24 KB, text/plain)
2003-05-30 11:29 UTC, tboerkel
Details
The new binary patch, that should work with NetBeans 3.5 RC3. (57.27 KB, application/octet-stream)
2003-06-05 11:51 UTC, Martin Entlicher
Details
The contextual diff that fixes this issue. (9.38 KB, patch)
2003-07-24 17:22 UTC, Martin Entlicher
Details | Diff
An additional file, that is necessary for this fix. (879 bytes, text/plain)
2003-07-24 17:23 UTC, Martin Entlicher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tboerkel 2003-04-08 15:23:52 UTC
After upgrading a 3.4.1 installation to 3.5
(q-build
NetBeansIDE-release35-QBE200303252350-200304031325.zip),
running refresh recursively, quitting and
restarting NB, a background thread always ran. NB
consumed 100% CPU time, was usable, but slow.
Restarting NB several times did not help. Deleting
the VCS cache directory solved the problem.
This only happened on one machine so far.
Using JDK 1.4.2 Beta.
Attaching thread dump from the situation.
Comment 1 tboerkel 2003-04-08 15:24:43 UTC
Created attachment 9771 [details]
Thread dump
Comment 2 Martin Entlicher 2003-04-08 15:53:05 UTC
This looks like a serious problem. Thanks for the thread dump!
Comment 3 tboerkel 2003-04-09 07:59:52 UTC
New problem on the same PC. Starting takes again very long and then
there is an exception. After that, working is possible with NB.
Attaching the error text.
Comment 4 tboerkel 2003-04-09 08:01:13 UTC
Created attachment 9791 [details]
Errors during startup.
Comment 5 Martin Entlicher 2003-04-09 11:48:59 UTC
At the end of the errors there's:
[catch]Caused by: java.lang.OutOfMemoryError
==>
[catch]java.lang.OutOfMemoryError

The exception's stack looks pretty the same as in the first thread
dump. This bug seems to create an infinite thread, that ends with
OOME.

Comment 6 Jiri Kovalsky 2003-04-10 15:56:40 UTC
Can you reliably reproduce it Thomas ? I am afraid we won't be able to
confirm whether a fix is successful or not here in Prague.
Comment 7 Martin Entlicher 2003-04-10 16:31:14 UTC
I hope I've fixed the problem in the main trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java,v 
<--  VcsObjectIntegritySupport.java
new revision: 1.10; previous revision: 1.9
/cvs/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java,v 
<--  VcsFileSystem.java
new revision: 1.221; previous revision: 1.220
/cvs/vcscore/src/org/netbeans/modules/vcscore/FileObjectExistence.java,v 
<--  FileObjectExistence.java
initial revision: 1.1

But I'm not able to reproduce the bug (I've detected where is the
problem from the thread dump only), so I'm not able to verify whether
this fix really helps.

Thomas, can you please describe exact steps how to reproduce this?
I'll attach a binary patch, so that you will be able to verify whether
it's fixed.
Comment 8 Martin Entlicher 2003-04-10 16:38:03 UTC
Created attachment 9851 [details]
The binary patch. To apply, copy into <NB-install>\modules\autoload\patches\org-netbeans-modules-vcscore\ folder and copy Patch32731.jar into it. Verify in ide.log, that the patch was applied.
Comment 9 tboerkel 2003-04-11 08:53:28 UTC
It's a colleague, who has this problem. I'll ask him when he returns
on monday.
Comment 10 Jiri Kovalsky 2003-04-11 09:18:06 UTC
Okay, thanks. We really need it, otherwise it can't be integrated into
NetBeans 3.5, because of high resistance mode.
Comment 11 tboerkel 2003-04-14 16:03:17 UTC
The problem did not happen anymore. Seems that it has resolved itself
somehow.
Comment 12 Jiri Kovalsky 2003-04-14 16:42:02 UTC
Okay, I propose then to decrease priority accordingly and waive this
for NetBeans 3.5/Sun ONE Studio 5.0.
Comment 13 Martin Entlicher 2003-04-14 17:17:30 UTC
The problem is, that this is apparently not easily reproducible. But
when it happens it has quite bad consequences.
But when we can not reproduce the problem, we can not integrate the
fix in high resistance mode, because we're not sure that it's fixed.
So I'm downgrading this to P2 until we find steps how to reproduce it.
Comment 14 Martin Entlicher 2003-04-17 13:44:22 UTC
Adding S1S5_WAV keyword. Due to the fact that this problem is not
reproducible any more, I'm asking to waive this issue for integration
in S1S 5.0 / NB 3.5.
Comment 15 tboerkel 2003-05-30 11:22:00 UTC
I think we have this problem here with 3.5 RC3 again. We have saved
the user directory, if you need it. Should we try the patch? Attaching
new thread dump.
Reopened and raised to P1.
Comment 16 tboerkel 2003-05-30 11:29:37 UTC
Created attachment 10527 [details]
New thread dump.
Comment 17 Martin Entlicher 2003-05-30 12:10:45 UTC
This is fixed. But only in 4.0 (dev sources) - Target Milestone is set
to 4.0.

There's attached binary patch, that should fix this problem in 3.5
builds.

The fix did not get into 3.5, because we were not able to reproduce
it. Even you've said: "The problem did not happen anymore. Seems that
it has resolved itself somehow."

Thus the problem is still there, but it probably happens wery rarely.
This is why the fix was not approved for integration into 3.5 builds.
The only solution for you is to install the attached binary patch.
Comment 18 Jiri Kovalsky 2003-05-30 13:45:51 UTC
As was said, I am sorry. Anyway we still appreciate your feedback if
the patch works fine for you ...
Comment 19 tboerkel 2003-06-02 12:23:07 UTC
Tried to apply the patch in NB 3.5 RC2 and got exception:
java.lang.NoSuchMethodError:
org.netbeans.modules.vcscore.objectintegrity.VcsObjectIntegritySupport.<init>(Ljava/security/PrivilegedAction;)V
	at
org.netbeans.modules.vcscore.objectintegrity.IntegritySupportMaintainer.initVOIS(IntegritySupportMaintainer.java:81)
Comment 20 Martin Entlicher 2003-06-05 10:14:00 UTC
There were some more changes in the codebase after the patch was
created. This is why it does not work.
I'll create a new patch for NB 3.5 RC3...

Patches are not the right way how to provide fixes to users anyway. We
need a solution of issue #34132.
Comment 21 Martin Entlicher 2003-06-05 11:51:48 UTC
Created attachment 10603 [details]
The new binary patch, that should work with NetBeans 3.5 RC3.
Comment 22 Jiri Kovalsky 2003-07-08 12:53:13 UTC
I am verifying this issue on behalf of Thomas hoping the patch has
helped him.
Comment 23 tboerkel 2003-07-08 13:46:19 UTC
In the meantime, we had some more cases of this bug and the new patch
seems to fix the problem for NB 3.5 final.
Comment 24 Martin Entlicher 2003-07-24 17:22:17 UTC
Created attachment 11119 [details]
The contextual diff that fixes this issue.
Comment 25 Martin Entlicher 2003-07-24 17:23:27 UTC
Created attachment 11120 [details]
An additional file, that is necessary for this fix.
Comment 26 Martin Entlicher 2003-07-31 15:11:11 UTC
The fix is merged into release35_fixes branch:

Checking in src/org/netbeans/modules/vcscore/FileObjectExistence.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/FileObjectExistence.java,v 
<--  FileObjectExistence.java
new revision: 1.1.22.1; previous revision: 1.1
done
Checking in src/org/netbeans/modules/vcscore/VcsFileSystem.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java,v 
<--  VcsFileSystem.java
new revision: 1.207.2.14.6.1; previous revision: 1.207.2.14
done
Processing log script arguments...
More commits to come...
Checking in
src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java,v 
<--  VcsObjectIntegritySupport.java
new revision: 1.2.2.6.6.1; previous revision: 1.2.2.6
done
Comment 27 dmladek 2004-02-13 11:57:44 UTC
I can't reproduce it in Arrow SE6 2004Q1 on Solaris
The fix seems to be fine.