This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32687 - Offline mode doesn't work correctly: it doesn't display localy removed files
Summary: Offline mode doesn't work correctly: it doesn't display localy removed files
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-07 16:56 UTC by dmladek
Modified: 2003-04-09 10:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The context diff, that fix this issue. (2.07 KB, patch)
2003-04-08 12:26 UTC, Martin Entlicher
Details | Diff
The binary patch, that fix this problem. Put into <NB-install>/modules/patches/org-netbeans-modules-vcs-profiles-cvsprofiles/ folder. (5.04 KB, application/octet-stream)
2003-04-08 12:28 UTC, Martin Entlicher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dmladek 2003-04-07 16:56:01 UTC
During verification of the issue #32581
I had deal with following problem if you try to do
instructions mentioned in the issue.

Simply:
if you perform "remove" command on a few selected
files which are [up-to-date] and in G-CVS FS which
is set for off-line work, and choose proceed a
commit after thet...
The offline refresh (doesn't contains any output
in the history!!!) dismiss your selected files
which should be now marked as [Locally removed]
Thus folowing commit is not performed :-( Or is
performed only on one file!!!
That leads in the next work for big confusion of
the user...

Seems to me more P2 then P3.
Comment 1 dmladek 2003-04-07 16:58:04 UTC
Forgot: Using RH80, jdk1.4.2 #b19,
S1S5 #030406
=============================================================
Comment 2 Martin Entlicher 2003-04-08 10:17:49 UTC
This looks like a bug in CvsListOffline class in cvs-profile
sub-module (vcsgeneric/profiles/cvsprofiles).
Comment 3 Martin Entlicher 2003-04-08 10:18:43 UTC
Just a question to QA: is this a showstopper for NetBeans 3.5?
Comment 4 Martin Entlicher 2003-04-08 12:24:48 UTC
Fixed in the main trunk. The fix is simple and seems to work O.K.
Increasing the priority to P1 - this should be fixed in NB 3.5.

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListOffline.java,v 
<--  CvsListOffline.java
new revision: 1.4; previous revision: 1.3
Comment 5 Martin Entlicher 2003-04-08 12:26:12 UTC
Created attachment 9764 [details]
The context diff, that fix this issue.
Comment 6 Martin Entlicher 2003-04-08 12:28:39 UTC
Created attachment 9765 [details]
The binary patch, that fix this problem. Put into <NB-install>/modules/patches/org-netbeans-modules-vcs-profiles-cvsprofiles/ folder.
Comment 7 Richard Gregor 2003-04-08 14:13:07 UTC
Fix looks safe.Code reviewed without objections. 
Comment 8 dmladek 2003-04-08 14:35:23 UTC
Great Martin!!! It is fixed and working fine:-)
It should come to NB3.5 Beta, too !
Comment 9 _ ttran 2003-04-08 23:09:14 UTC
approved for 3.5
Comment 10 Martin Entlicher 2003-04-09 10:29:32 UTC
Thanks for the review, verification and approval. The fix is merged
into release35 branch:

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/list/CvsListOffline.java,v 
<--  CvsListOffline.java
new revision: 1.3.2.1; previous revision: 1.3