This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
When I created the 'Empty' profile in 'New Wizard - Generic VCS', the context menu of created Empty filesystem appears in English. This occurs in both Solaris 9 and Windows 2000. Tested build is Nevada build 030323 and I added _ja.jar files to it. Steps: 1. run IDE in ja locale 2. select 'Versioning' -> 'Mount Version Control' -> Generiv VCS 3. select 'Empty (Unix)' on Sol9 or select 'Empty (Windows) on win2k 4. click 'Finish' At this point, 'Empty /xxx/yyy' is mounted on Explore. 5. right-click 'Empty /xxx/yyy' on Explore The menu 'Empty' and the context menu of Empty appear in English. Empty --> Refresh Refresh Recursively Check in Check out Lock Unlock Add Remove These menu items seem to come from the following files and be hard-coded. vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyUnix.xml vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyWin.xml <command name="ROOT" displayName="Empty"> <command name="LIST" displayName="Refresh"> <command name="LIST_SUB" displayName="Refresh Recursively"> <command name="CHECKIN" displayName="Check in"> <command name="CHECKOUT" displayName="Check out"> <command name="LOCK" displayName="Lock"> <command name="UNLOCK" displayName="Unlock"> <command name="ADD" displayName="Add"> <command name="REMOVE" displayName="Remove">
Created attachment 9512 [details] I have attached the snapshot on Solaris.
That's true. However the Empty profile is there for users, who need to create a new profile for version control system that we do not support. I'm not sure whether it's really necessary to localize it, because the profile is not really functional anyway. It's expected that the user will edit the profile. However if you feel like it should be localized, it's not too hard to do it.
I am sorry that I have filed this before I understand a function of the Empty profile. I verified that I can create my profile using the Empty profile. I think it would be better that menu items of created filesystem are translated without clicking the 'Edit Commands' button (in short, withtou editing label of each properties). Is it possible the changes that displayName in emptyUnix.xml and emptyWin.xml will come from Bundle.properties? I do not know the implementation, so this may be no make sence.
> Is it possible the changes that displayName in emptyUnix.xml and > emptyWin.xml will come from Bundle.properties? Yes, it is possible. I've fixed it in the main trunk: Checking in emptyUnix.xml; /cvs/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyUnix.xml,v <-- emptyUnix.xml new revision: 1.3; previous revision: 1.2 done Checking in emptyWin.xml; /cvs/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyWin.xml,v <-- emptyWin.xml new revision: 1.3; previous revision: 1.2 done RCS file: /cvs/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/Bundle.properties,v done Checking in Bundle.properties; /cvs/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/Bundle.properties,v <-- Bundle.properties initial revision: 1.1 done I guess this is necessary for NB 3.5 as well. Considering that this is a very low risk I hope I'll get an approval. In order I can get an approval it must be a showstopper ( == P1 priority). So I'm upgrading this to P1 - our software must be localizable.
Created attachment 9552 [details] The text patch with respect to release35 branch.
Created attachment 9553 [details] The binary patch, that fix this issue.
The binary patch attached. To apply: create folder patches/org-netbeans-modules-vcs-advanced in "modules" folder in the NetBeans 3.5 installation directory and copy the attached Patch32273.jar into that folder: cp Patch32273.jar \ netbeans/modules/patches/org-netbeans-modules-vcs-advanced Then restart NetBeans.
Thank you for creating the patch. I tested with the following steps for Nevada build, but I was not able to see japanese messages. 1. create Bundle_ja.properties and add it to Patch32273.jar 2. create the directory org-netbeans-modules-vcs-advanced in /opt/studio5_se/modules/patches 3. copy Patch32273.jar that has ja file to created directory 4. run runide.sh Could you please tell me what I should do?
Created attachment 9583 [details] I have attached Bundle_ja.properties (English msg) for testing.
Hi, I have just reviewed code. Fix is ease. I built vcsegeneric module with files patched with attached patch, used attached Bundle_ja.properties and run release35 build with vcsgen.jar module and vcsgen_ja.jar. In ja locale it shows localized ja labels, so I think it is correct. I didn't try attached binary patch. Shouldn't be there localized module patch containig Bundle_ja.properties somewhere inside the locale subdir? Or there could be also problem that simply restart IDE is not enough - you usually need to change userdir to see changed profile. Anyway, from my point of view reviewed without objections.
Created attachment 9586 [details] Screenshot of localized menu
approved for 3.5
When I created vcsgen.jar and vcsgen_ja.jar and run IDE, I was able to see translated messages. When I tried this yesterday, it was not successful. I think my operation was wrong. I believe this fix works fine. Thank you very much for the fix.
Thanks for the review and approval. The issue is fixed in release35 branch: Checking in Bundle.properties; /shared/data/helm/cvs/repository/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/Bundle.properties,v <-- Bundle.properties new revision: 1.1.2.1; previous revision: 1.1 done Checking in emptyUnix.xml; /shared/data/helm/cvs/repository/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyUnix.xml,v <-- emptyUnix.xml new revision: 1.2.2.1; previous revision: 1.2 done Checking in emptyWin.xml; /shared/data/helm/cvs/repository/vcsgeneric/src/org/netbeans/modules/vcs/profiles/config/emptyWin.xml,v <-- emptyWin.xml new revision: 1.2.42.1; previous revision: 1.2 done
We verified that this was fixed in Nevada build 030331. Thank you very much for fixing this.