This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32231 - Wrong order of templates in New From Template dialog
Summary: Wrong order of templates in New From Template dialog
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: JUnit (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: junit-issues@java
URL:
Keywords:
Depends on:
Blocks: 32147
  Show dependency tree
 
Reported: 2003-03-24 11:05 UTC by Marian Mirilovic
Modified: 2003-03-28 17:05 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
diff of the fix (1.77 KB, patch)
2003-03-26 15:29 UTC, Martin Brehovsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2003-03-24 11:05:36 UTC
Please read issue 32147 and fix your part of issue.
Comment 1 Martin Brehovsky 2003-03-25 10:59:04 UTC
I'm waiting for HIE input to fix this issue.
Comment 2 Chris Ledantec 2003-03-25 14:56:05 UTC
i would recommend putting JUnit after Ant Scripts given the order
looks something like this (from referenced bug):
Folder
Java Package
-------------------- (separator)
Java Classes
Java GUI Forms
Java Beans
JSPs & Servlets
RMI
XML
JAR Archives
Ant Build Scripts
Scripting
NetBeans Extensions
Other

the rationale is that everything up to Ant Build Scripts has to do
directly with developing code. Scripting (which may now be gone?)and
NetBeans Extensions are things that deal with the IDE. other is catch
all. 

JUnit deals with the users code but isn't quite used in development so
it should come after the templates for code and building but before
the templates for working with the IDE.

does that sound reasonable?
Comment 3 Martin Brehovsky 2003-03-25 15:06:18 UTC
Hmm, I don't know, but I have a feeling that JUnit might be quite well
before Ant Build Scripts. At least, because you use templates for ant
scrips and stuff like that usually just once and then you just modify
the created template. On the other hand, creating JUnit tests via
templates (if used at all) might happen more often (not just once).
Furthermore, creating tests for your code becomes a very standard for
many projects. So what about putting JUnit templates before Ant Build
Scripts?
Comment 4 Chris Ledantec 2003-03-25 17:42:23 UTC
before ant scripts works for me. 

i should have asked how often the templates are used -thanks for
pointing that out.
Comment 5 Martin Brehovsky 2003-03-26 15:27:14 UTC
Fixed in dev. Diff is attached
Comment 6 Martin Brehovsky 2003-03-26 15:29:50 UTC
Created attachment 9539 [details]
diff of the fix
Comment 7 _ ttran 2003-03-27 07:28:58 UTC
Code review? Binary patch for release35 build?  Verification to make
sure (a) it was fixed (b) no regression
Comment 8 Martin Brehovsky 2003-03-27 09:10:09 UTC
Just wondering how should I create a binary patch if the changes were
made only in layer and bundle.properties.

The things is also complicated by the fact that JUnit is not a part of
release35 build, just of S1S build based on release35.

Also wondering how should I provide code review - the only thing
changed was that I added ordering attributes to templates defined in
layer.xml

Also who will verify it? Can I verify it on my own?
Comment 9 Marian Mirilovic 2003-03-27 09:16:17 UTC
Martin, I will verify it when I have a patch. 
Comment 10 Martin Brehovsky 2003-03-27 09:19:37 UTC
So I should post here a binary patch of junit.jar against latest S1S
build and you check it, right? I'm working on that.
Comment 11 Marian Mirilovic 2003-03-27 14:24:26 UTC
patch verified, thanks Martin :)
Comment 12 _ ttran 2003-03-27 16:39:43 UTC
approved for release35
Comment 13 Martin Brehovsky 2003-03-27 18:09:18 UTC
OK, integrated to release35 branch.
Comment 14 Marian Mirilovic 2003-03-28 17:05:32 UTC
verified in [s1s5](030327)