This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32205 - wrong bundle referenced
Summary: wrong bundle referenced
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Actions (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-21 21:55 UTC by Rich Unger
Modified: 2008-12-22 20:57 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Diff of patch (957 bytes, patch)
2003-03-24 09:32 UTC, Peter Zavadsky 		Details | Diff
patch (1.57 KB, application/zip)
2003-03-24 09:33 UTC, Peter Zavadsky 		Details
diff of patch for [release35] branch (1.87 KB, patch)
2003-03-25 09:46 UTC, Peter Zavadsky 		Details | Diff
patch for [release35] branch (3.12 KB, application/zip)
2003-03-25 09:47 UTC, Peter Zavadsky 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rich Unger 2003-03-21 21:55:15 UTC 
I'd like to make this checkin (you know, if I had
access :)
It seems as though BuildProjectAction in the
deprecated jar is refreencing the wrong bundle.

RCS file:
/cvs/openide/deprecated/src/org/openide/actions/BuildProjectAction.java,v
retrieving revision 1.3
diff -r1.3 BuildProjectAction.java
38c38
<         return
NbBundle.getBundle(BuildProjectAction.class).getString("BuildProject");
---
>         return
NbBundle.getBundle("org.openide.deprecated.Bundle",
Locale.getDefault(),
BuildProjectAction.class.getClassLoader()).getString("BuildProject");
Comment 1 Rich Unger 2003-03-21 22:08:13 UTC 
Sorry, that last diff was incomplete.  I just ran with this compiled
in, and it worked fine:

Index: src/org/openide/actions/BuildProjectAction.java
===================================================================
RCS file:
/cvs/openide/deprecated/src/org/openide/actions/BuildProjectAction.java,v
retrieving revision 1.3
diff -r1.3 BuildProjectAction.java
38c38
<         return
NbBundle.getBundle(BuildProjectAction.class).getString("BuildProject");
---
>         return NbBundle.getBundle("org.openide.deprecated.Bundle",
java.util.Locale.getDefault(),
BuildProjectAction.class.getClassLoader()).getString("BuildProject");
Index: src/org/openide/actions/CompileProjectAction.java
===================================================================
RCS file:
/cvs/openide/deprecated/src/org/openide/actions/CompileProjectAction.java,v
retrieving revision 1.3
diff -r1.3 CompileProjectAction.java
38c38
<         return
NbBundle.getBundle(CompileProjectAction.class).getString("CompileProject");
---
>         return NbBundle.getBundle("org.openide.deprecated.Bundle",
java.util.Locale.getDefault(),
CompileProjectAction.class.getClassLoader()).getString("CompileProject");
Comment 2 Peter Zavadsky 2003-03-24 09:28:20 UTC 
Fixed in [trunk]

openide/deprecated/../actions/BuildProjectAction.java 1.4
Comment 3 Peter Zavadsky 2003-03-24 09:32:01 UTC 
Needs to mark as fixed.
Comment 4 Peter Zavadsky 2003-03-24 09:32:45 UTC 
Created attachment 9493 [details]
Diff of patch
Comment 5 Peter Zavadsky 2003-03-24 09:33:22 UTC 
Created attachment 9494 [details]
patch
Comment 6 Peter Zavadsky 2003-03-24 09:35:46 UTC 
The fix is safe, points to existing bundle. without it when processing
the code, MissingResourceException would be thrown.

It occured, when was done the separation of older open API, it was
just forgotten.
Comment 7 Jesse Glick 2003-03-24 14:28:34 UTC 
Fine, but forgot to also fix CompileProjectAction.
Comment 8 _ ttran 2003-03-24 16:18:36 UTC 
> Fine, but forgot to also fix CompileProjectAction.

so fix it too, and please attach a combined diff/patch here for 3.5.  Thx
Comment 9 Peter Zavadsky 2003-03-25 09:45:55 UTC 
Fixed in [trunk] also for CompileProjectAction

openide/deprecated/../actions/CompileProjectAction.java 1.4
Comment 10 Peter Zavadsky 2003-03-25 09:46:53 UTC 
Created attachment 9510 [details]
diff of patch for [release35] branch
Comment 11 Peter Zavadsky 2003-03-25 09:47:38 UTC 
Created attachment 9511 [details]
patch for [release35] branch
Comment 12 Marian Mirilovic 2003-03-26 14:43:44 UTC 
patch verified
Comment 13 _ ttran 2003-03-26 16:36:09 UTC 
approved by release coordinator, I also reviewed the diff
Comment 14 Peter Zavadsky 2003-03-26 17:19:46 UTC 
Merged into [release35] branch

openide/deprecated/../actions/BuildProjectAction.java 1.3.34.1
                              CompileProjectAction.java 1.3.34.1
Comment 15 Marian Mirilovic 2003-03-27 10:11:37 UTC 
verified