This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 30967 - Debugger does return 'null' for servlet breakpoint lines.
Summary: Debugger does return 'null' for servlet breakpoint lines.
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: PC All
: P1 blocker (vote)
Assignee: issues@debugger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-11 17:14 UTC by Martin Grebac
Modified: 2003-02-19 15:13 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Grebac 2003-02-11 17:14:17 UTC
Reproducing steps: 

1. Create web module with a jsp in it.
2. Place a breakpoint.
3. Start debug.

Result: debugger stops, but it writes 'Breakpoint
reached on line ? in ... " and does not open the
corresponding servlet.

Expecting: debugger stops, opens the servlet (or
jsp), annotates the current line, and writes
'Breakpoint reached on line (e.g.) 53 in file ... "

 I spent quite a time on this trying to find
problem in jsp debugging line mappings, when I
found out that it's a regression caused by fix of
#27739 (in Utils and JUtils). 

 You are ignoring hidden filesystems (returning
null instead of lineset), but that's what web
module uses for servlets.
Comment 1 Jan Jancura 2003-02-12 13:21:03 UTC
This is "as designed" for me. The contract is that I do not debug
files from hidden filesystems. Can you "unhide" your filesystem? 
The correct solution is to add a new capabilities:
"visible in explorer"
"show during debugging", but I am not sure if we can change it to the
next release.
Comment 2 Martin Grebac 2003-02-12 15:24:51 UTC
 So based on a discussion with other webteam members, I'm reopening
the bug and raising the priority to P1 since this is a regression. And
as for the offered suggestions, they are not acceptable for us,
because (at least) we already passed the UI freeze date. 
 However, for later releases, I agree the additional capabilities in
the filesystem would be useful.
Comment 3 Jan Jancura 2003-02-12 17:16:33 UTC
You probably do not understand THE problem. If I change it (rewrite
impl. to show files from hidden filesystems) another P1 will occur. So
its not a solution. Your implementation is hack - you assume somethink
what is not defined and logicall. At least I can not find some
definition what FS.isHidden property should mean for debugger.

So I am asking you:
1) try to remove this hack on your side - put your sources on some not
hidded fs
or
2) try to find some other correct way how to fix it - like add some
other capability to fs, ...
or
3) try to implement some other hack on your side which will solve this
problem
or 
4) suggest some other solution

Comment 4 psuk 2003-02-13 10:19:48 UTC
Reopening the bug, until we find a reasonable solution that works for
Java and JSP debugging.

This is a regression caused by latest integration in debugger and
needs to be tracked.

It's a potential Q-build stopper, because it disallows JSP debugging
and it's going to have a big impact on functionality.
Comment 5 Martin Grebac 2003-02-13 13:30:41 UTC
 Well, as a suggestion - do we really need a new FS capability?
Couldn't the existing DEBUG capability be used for this purpose?
 The src.zip with java sources does have the DEBUG capability set to
false, and our hidden filesystems have the DEBUG capability set to true. 
 So I think this is the way it could work for both, and it would be
more logical either. Or am I missing something?
Comment 6 Jan Jancura 2003-02-13 14:50:52 UTC
DEBUG capability is for something different. It means: "should be this
fs on classpath for debugged process".

But may be its one possibility, if we do not find better solution...

BTW what about nb4.0. Will you have some regular solution?
Comment 7 Petr Jiricka 2003-02-14 09:15:35 UTC
As for the NB 4.0 solution: We expect there will be a Java 
root (created by us), which will contain the generated 
Java files. Since these files are not considered a part of 
the user's sources (they are not stored in VCS, they are 
server-dependent etc.), the Java root will somehow be 
hidden (this needs to be negotiated with the Java module 
team).

In spirit, this is similar to the current situation, when 
the filesystem containing generated files is hidden. Note 
that hiding the filesystem is NOT a hack on our side, it 
is hidden by design.
Comment 8 Jan Jancura 2003-02-18 10:04:18 UTC
Fixed on my side. I have added:
GUIManager.DEBUG_SRC - see JavaDoc comment and JavaDoc for openide
filesystems for more info how to use it.
Comment 9 Martin Grebac 2003-02-18 16:03:25 UTC
 Fixed in trunk on my side, too. Waiting for Hanz's integration into
qbuild branch.
 Btw, the javadoc comment is really consistent with the rest of the
filesystem api doc ;O) - words 'well known' are for sure the right
ones to use in documentation.
Comment 10 Martin Grebac 2003-02-18 16:31:27 UTC
Everything's commited in q-branch, too.
Comment 11 sva 2003-02-19 15:13:44 UTC
Verified with current Netbeans dev build (200302191342).