This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
If the user attempts to execute a servlet outside of a web module, an Information dialog is given which says: "Execution and debugging of Servlets and JSPs is supported within a web module. Move your servlet into an existing web module or convert current filesystem into a web module and move it to proper location under WEB-INF/classes directory." The wording of the second sentence is a little awkward. I suggest changing it to the following: "Execution and debugging of Servlets and JSPs is supported only within a web module. Move your servlet into an existing web module or convert your current filesystem into a web module. Servlets should be placed in the proper location under the WEB-INF/classes directory." I'm copying Ann on this so that she can give HIE input.
Ann, is it OK?
BTW: this is related to issue #19805
According to the following message from Trung, it sounds like UI changes for Nevada are not to be made unless they have impact on UI responsiveness. Since this issue came in after the Nevada UI freeze, we'll have to live with the current messaging, and I'd recommend to close this issue as wontfix since with the projects implementation the idea is by design the web component cannot get into this situation. -------- Original Message -------- Subject: INF is required for any UI changes in Nevada Date: Wed, 05 Feb 2003 15:08:00 +0100 From: Trung Duc Tran <Trung.Duc.Tran@sun.com> Organization: Sun Microsystems, Inc. I already communicated at this week perf meeting but to make sure: You know that Nevada is past the Functional Complete milestone (Jan/31). This usually means no UI changes are allowed after that day. I got an exception from S1S p-team that we still can make UI changes in Nevada until the Code Freeze milestone (Feb/28) if and only if these changes are required to fix UI responsiveness problems. S1S p-team gave me this exception even though it will cause troubles for Docs and QA. On my part and on behalf of Prague Eng, I promised - all those UI changes will be approved by HIE - Patrick Keegan will be notified in advance about all the UI changes - Integration Notice will be filed with UI checkbox marked If we violate these rules, troubles will follow (for me, that's it :-) Thanks for your understanding and efforts -- Trung
This is simply a text change and may not be bound by the UI freeze. As the QA representative for Web Apps, I can say that this change would have minimal impact on QA. As such, we would approve it being included in S1S5 and NetBeans 3.5 despite the UI freeze.
This change doesn't present any problem for docs. I say go ahead.
http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/Bundle.properties.diff?r1=1.4&r2=1.5 IN=11543
Below is the wording that was agreed upon by QA, docs, and HIE. (versus the wording that got put in Feb 21 2003) The wording was discussed over email conversation in the team and not recorded in the issuezilla. For Servlets: ERROR Dialog: "To execute or debug a servlet, the servlet must be in a web module. \n\n Place the servlet in the correct package under the WEB-INF/classes directory of a web module. Convert the current filesystem into a web module or place the servlet in an existing web module. Mount the web module at the directory that contains the WEB-INF directory. [OK]" And for JSPs: WARNING Dialog: "To execute this JSP, you must place it in a web module and mount the web module at the root directory. \n\n Choose Convert and Execute to convert the current filesystem into a web module and execute the JSP. [Convert and Execute][Cancel] "
P4 & we are after UI freeze -> 4.0
Fixed in trunk. http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/Bundle.properties.diff?r1=1.5&r2=1.6 http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/ServletExecPerformer.java.diff?r1=1.7&r2=1.8 http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/WebResourceExecPerformer.java.diff?r1=1.7&r2=1.8
grrr :-( still not OK. Would it be enough to use 'Choose OK to convert the current filesystem into a web module and execute the JSP.' and OK/Cancel buttons or do you insists on your wording and labels?
I'd prefer the change in wording and button label (though it's not necessary to have the buttons to be equal size, which would mean a *wide* cancel button). My main point about changing the button name is to make sure the user knows what will happen before blindly pushing OK. This agrees with the Java L&F Guidelines (See Warning Alert Box) http://java.sun.com/products/jlf/ed2/book/HIG.Dialogs5.html but if this introduces too many risky UI changes for this stage, then I'll be ok with "OK/Cancel". I am wondering if the NB architecture is not flexible enough to take this kind of alert box customizations.If this is the case, then please alert me, and I will file a bug against the appropriate module (OpenAPI?) to be able to do this.
I know this it would be better to use more descriptive button label but currently: http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/Bundle.properties.diff?r1=1.5&r2=1.5.4.1 http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/ServletExecPerformer.java.diff?r1=1.7.2.1&r2=1.7.2.2 http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/WebResourceExecPerformer.java.diff?r1=1.7.2.1&r2=1.7.2.2 and in trunk http://web.netbeans.org/source/browse/web/core/src/org/netbeans/modules/web/execution/Bundle.properties.diff?r1=1.6&r2=1.7 hopefully we will get rid of this message in 4.0
Verified in release 3.5.1.