This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Under 1.3.1_06 the relative mount point tool will only let me go about 2-3 directories deep. The tree's display is also quite messed up in that hitting + causes name changes and other weird stuff that I almost want to believe this is a custom tree because I have never seem trees do that before... It works fine under 1.4.1_01
Elevated this to p1 today as I realized I can not use CVS in 1.3.1_06 with this error. Software is 3.4.1RC1
Well, on Solaris it works O.K. for me in JDK 1.3.1_06. Jiri, can you please test it on Windows 2000? dnoyeB: Do you use a special look&feel different from the default one?
Okay, I have just installed 1.3.1_06 and am gonna check it on my Win2K box. Stay tuned ...
Hm, sorry for disappointing you, but it works fine for me too. Don't you want to attach some screenshots to this bug showing the bug ? I can select relative mountpoint using the browser no matter how deep I go in both command-line and built-in clients. Tested in development build #200301022341 of NetBeans 3.4.1 on Windows 2000 with SP2 and build #01 of JDK 1.3.1_06.
Win2000 sp3 -ui com.sun.java.swing.plaf.windows.WindowsLookAndFeel 1.3.1_06 I should have been more specific. Lets try again. MESSED UP DRAWING ERROR. Have a CVS filesystem mounted or be mounting one. Their is a "Relative Mount Point" text box there with a select button on the right of it. Hit that button. This opens the "Relative Mount Point Browser" dialog. Now start hiting the "+" and see how the graphic can mess up. Typically messes up when dialog window is not too big, I left it at default size and did not resize it. CANT TRAVERSE ERROR Start mounting a new CVS directory by right clicking on filesystem under the filesystem tab. Filesystem->Mount->VersionControl->CVS. This opens the "New Wizard-CVS" dialog. Select working directory. hit next. Now the relative mount point window is open. Hit "+" to try to get more than 3 layers deep. It won't allow it. Shut down, and restart with 1.4.1_01. No problems.
my filesystem is NTFS.
Created attachment 8434 [details] Example image
OK, for the non-traverse error, you must have already mounted a CVS directory. Then you select this CVS directory for your "working directory" because if you don't the relative mount point window is skipped. In the attached graphic, I can not go any deeper.
Created attachment 8438 [details] Garbled Tree
Do you mean that using mouse it works fine ?
Their is only one way to use the 'browser' and that is with the mouse. If your not using the mouse, your not browsing, so to speak. And no it does not work fine with the mouse. Did you look at the attached image? the first one that shows me using the window with JHotDraw selected? Well I can NOT select any of the children of the JHotDraw node. Again, if I switch to 1.4 I can. And what did you mean by command-line and built-in clients?
Good news. I was able to reproduce it with WindowsLookAndFeel. It's really not usable. However, there is very good workaround: use default look&feel. :-)
Thanks Jiri for your tests. The exactly the same code works O.K. with the default L&F and does not work with Windows L&F. So it looks like a bug of the Windows look and feel, not NetBeans. The only workaround is to use a different L&F.
Glad you found it! Their are several other JTrees in NB that do not exhibit this behavior. Thus, I am somewhat hesitant to believe it is a WindowsLookAndFeel bug. If I knew where the code was I would take a look myself. At least then I could report it to Sun if it indeed was a WLF issue. Also considering the garbled display issue, I really think someone did a bad thing with the JTree. Thats 2 issues that no other JTrees are exhibiting.
O.K., I'll look at the code. It sets the children lazily, this can be the problem. But it did not cause any problems so far. The code is in vcscore module at vcscore/src/org/netbeans/modules/vcscore/cmdline/RelativeMountPanel.java I'm reopening the issue again not to forget the examine the code.
This was the best I could do. Works-around both issues which I believe are Sun issues. retrieving revision 1.17 diff -r1.17 RelativeMountPanel.java 57a58,61 > if( UIManager.getSystemLookAndFeelClassName().equals("com.sun.java.swing.plaf.windows.WindowsLookAndFeel")){ > //workaround for WindowsLookAndFeel error. see issue 29753. dnoyeb@users.sourceforge.net > trRelMount.setLargeModel(false); > }
Created attachment 8459 [details] Source file with workaround added
Wow, thanks for the patch! I would never find this workaround.
The patch works well, so I've committed it into the main trunk. Thanks a lot! I've only limit the patch for JDK 1.3.x since according to your comment it works well under JDK 1.4.1. /cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/RelativeMountPanel.java,v <-- RelativeMountPanel.java new revision: 1.18; previous revision: 1.17
First pre-testing looks good. Can you please dnoyeB confirm this in tomorrow's development build and eventually verify ? Thanks a lot for your open source contribution !
Sure I will confirm and test it. How do I confirm it? I have seen some issues with 'diffs' attached and when I click on them, I get a colored display showing the diff. How does one create that? Seems I couldn't create a 'patch' with NB because I don't have commit access, eventhough I am not committing anything?
You can download tomorrow's (Jan 8) development build (trunk) from http://www.netbeans.org/devhome/download.html The colored display of diff is available at http://www.netbeans.org/download/source_browse.html If you navigate to the desired file, you can view diff between any two versions. How did you try to create a patch with NB? Do you mean, that 'cvs patch' does not work? Yes. This is a known bug #16119. You have to use ...cvs.netbeans.org:/shared/data/helm/cvs/repository to have working cvs patch.
So what is your judgement dnoyeB ? Is it okay now ? I am verifying instead of you.
workin on it. i dont want to download the source, id rather use cvs to update it, but its not going too well. ill probably DL later today...
Verified in build NetBeansIDE-dev-200301220100
unverified in 3.4.1. Is this supposed to be in 3.4.1? or what?
No, it's not supposed to be fixed in 3.4.1. The Target Milestone is set to 4.0 which means, that it's fixed in development builds of NetBeans 4.0.
But it also seems to be fixed in development builds of 3.4.1!?
Which development build do you mean? Provide the exact build number please. I've fixed this issue on the main trunk only, so it's a development build of 4.0 (and any other release, that follows 3.4.x).
dev builds of 3.4.1 since the date I posted. Today I have dev 200301300100, and its fixed in that. so I was surprised to see it fixed in dev but not release. But probably I dont know the realease path well enough...
All dev builds (since release of 3.4) are dev builds of upcoming release (4.0 or 3.5 or whatever it will be called). 3.4.1 is a mainenance release, that is not based on the dev builds, but on 3.4 codebase into which only selected bugfixes are merged from the dev builds to 3.4.1 builds. Every release have some "high-resistance" period in which only fixes of critical bugs are permitted to merge in, so you will always have some bugs fixed in dev builds, but not merged into the upcoming release (because there is always a risk of beaking the stability of the product, that is to be released). This bug came too late to be included in 3.4.1 release, so it is fixed only in the development builds and was not merged into 3.4.1 builds. If this bug is critical for you, a patch for 3.4.1 release can be created.
OK, thanks. Its easy enough to copy the module from the dev build and use in the older build. Didnt know 3.4 and 4.0 were from the same code base since it seems that their is an indication that 4.0 will have a different windowing system and a new project system. I have yet to see either in a dev build, or so I thought. Since NB is not for sale, lets hope they are resonable and call it 3.4.2. (unless of course it has the new project or window systems, or new interfaces etc..)