This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29712 - 3.4 instead of 3.4.1
Summary: 3.4 instead of 3.4.1
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: rbalada
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-24 16:05 UTC by _ mihmax
Modified: 2003-03-07 16:32 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot 1 (52.40 KB, image/gif)
2002-12-24 16:10 UTC, _ mihmax
Details
screenshot 2 (52.55 KB, image/gif)
2002-12-24 16:54 UTC, _ mihmax
Details
the welcome screen of the installer (45.20 KB, image/png)
2003-01-05 21:08 UTC, vbrabant
Details
the summary page of the installer (45.55 KB, image/png)
2003-01-05 21:09 UTC, vbrabant
Details
The installer where I can choose another directory. But I havn't change the proposed value (45.53 KB, image/png)
2003-01-05 21:11 UTC, vbrabant
Details
The About page of NetBeans. You can read RC2 as product info (71.50 KB, image/png)
2003-01-05 21:13 UTC, vbrabant
Details
the about with splash screen where you can read RC2 (71.50 KB, image/png)
2003-01-05 21:14 UTC, vbrabant
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ mihmax 2002-12-24 16:05:46 UTC
In the installer for 3.4.1 RC1 build the NetBeans
3.4 is displayed everywhere, see following
attachments.

I plan to fix this issue myself, since I'm the
Release Coordinator. This issue is just an
appropriate place for CVS logs in order that they
are not forgotten.
Comment 1 _ mihmax 2002-12-24 16:10:59 UTC
Created attachment 8396 [details]
screenshot 1
Comment 2 _ mihmax 2002-12-24 16:54:00 UTC
Created attachment 8397 [details]
screenshot 2
Comment 3 _ mihmax 2002-12-24 16:55:45 UTC
there're total of 6 bad screenshots, but I don't feel they're all
necessary.
Comment 4 _ mihmax 2002-12-25 10:50:22 UTC
The problem is in the installer/NB.xml:

<product id="NBbean">
        <key>
            <uid>@BUILD_NUMBER_SUBST@</uid>
            <version major="3" minor="4"/>
        </key>
        ...    

I wander, where to add "1" to get 3.4.1 ?
And/or "RC1" to get "NetBeans IDE 3.4.1 RC1" in total?
Any DTD ?
Comment 5 _ mihmax 2002-12-25 11:07:25 UTC
Google Forever!

http://www.google.com/custom?q=cache:tH9whGfC5ocC:www.installshield.com/news/newsletter/0205-articles/ISMP_XSL.pdf+%3CisjeProject&hl=ru&ie=UTF-8

maintenance is the correct place for "1" of 3.4.1, but where to place RC1?

I decided to use such a line:
<version major="3" minor="4" maintenance="1 RC1"/>

What I risk, only one broken 3.4.1dev build, that's all ;-)

Checking in installer/NB.xml;
new revision: 1.11.2.5.2.2; previous revision: 1.11.2.5.2.1
done

Still I don't close the issue because I'll need to change it to
"3.4.1" (no RC) later.
Comment 6 _ mihmax 2002-12-25 11:15:29 UTC
Sorry, but 3.4.1 RC1 is already released,
I changed version to 3.4.1 Dev:

Checking in installer/NB.xml;
new revision: 1.11.2.5.2.3; previous revision: 1.11.2.5.2.2
Comment 7 _ mihmax 2002-12-27 11:26:10 UTC
I may confirm that the changes did show them up,
at least in Linux & Windows Installers (I can't test others) in
NetBeans IDE 3.4.1 build 200212252341 (25-Dec 2002)
Comment 8 _ mihmax 2003-01-03 16:30:32 UTC
<version major="3" minor="4" maintenance="1RC2"/> is checked in for
the tomorrow's 3.4.1 RC2 build:

Checking in installer/NB.xml;
new revision: 1.11.2.5.2.4; previous revision: 1.11.2.5.2.3

Comment 9 vbrabant 2003-01-05 21:08:46 UTC
Created attachment 8443 [details]
the welcome screen of the installer
Comment 10 vbrabant 2003-01-05 21:09:27 UTC
Created attachment 8444 [details]
the summary page of the installer
Comment 11 vbrabant 2003-01-05 21:11:20 UTC
Created attachment 8445 [details]
The installer where I can choose another directory.  But I havn't change the proposed value
Comment 12 vbrabant 2003-01-05 21:13:51 UTC
Created attachment 8446 [details]
The About page of NetBeans. You can read RC2 as product info
Comment 13 vbrabant 2003-01-05 21:14:52 UTC
Created attachment 8447 [details]
the about with splash screen where you can read RC2
Comment 14 vbrabant 2003-01-05 21:17:09 UTC
Hi Maxym.
I hope that with all those PNG screenshots, you are convinced that I
see 3.4 but not 3.4.1.



Comment 15 vbrabant 2003-01-05 21:18:57 UTC
Add myself in cc
Comment 16 _ mihmax 2003-01-05 21:25:22 UTC
Strange thing, I'll download RC2.exe myself and check what went wrong
in it. OK?

I downloaded some of the dev versions and it quite surely read Install
NetBeans IDE 3.4.1Dev on your computer...

;-(
Comment 17 _ mihmax 2003-01-05 21:33:11 UTC
Vincent, could you please try out tomorrow's dev build?
We have holidays till 8th January, so I have a dialup Internet
connection, and NetBeans install downloads about 5 hours or so.

I tryed to change some bits in the installer/NB.xml, let's hope for
that to work. As you can see yourself, installer is a dead module, so
there's no help from specialists ;-(
Comment 18 vbrabant 2003-01-05 21:39:57 UTC
I can't promise you but i will try to find a moment to do it in the
evening.
Comment 19 Richard Gregor 2003-01-06 07:46:27 UTC
Hi,
there is another replacement place in NB.xml. Look at @product-key@.
This one is responsible for displaying correct IDE version. This
property is set by build itself (look at build.xml).
Comment 20 _ mihmax 2003-01-06 18:14:43 UTC
Yes, thanks Richard.
(taking back the "dead module" words, sorry.

Hi Rudolf,
Is it your error to pass "3.4" instead of "3.4.1RC2" as a product-key
for a 3.4.1 build?

Source: 
installer/build.xml
    <target name="check-nb-id" if="${product-key}" >
    	<echo message="${product-key}"/>
        <fail message="You have to specify -Dproduct-key on
commandline "/>
    </target>

Maxym
Comment 21 rbalada 2003-01-06 18:51:36 UTC
Maxym,
I've got mixed feeling if it's an error or not, but it's certain, that
I'm responsible for that as an idea author and implementator.
Installer build *shell* script takes the product key from userdir
value specified in runide_defaults.sh I will try to arrange special
installer build tomorrow to provide good installers for 3.4.1 RC2
(build #200301032341). I guess 3.4.1 is not going to change userdir so
the change is upto me.
Comment 22 _ mihmax 2003-01-06 19:10:22 UTC
Yes, Rudolf, 3.4.1 uses .netbeans/3.4 as its userdir to implement a
smooth migration.
Actually, why don't you use the <version .../> tag from installer/NB.xml?
Comment 23 _ mihmax 2003-01-06 19:14:28 UTC
If that's too much overhead, use
RegKey=Software\netbeans.org\NetBeans IDE\3.4.1 RC2
line from runide_exe_defaults.

Sincere, Max

BTW: Please replace old RC2 with the correct RC2 that will be built
tomorrow, or tell back to name it RC3

P.S. If all goes OK, we'll have RC10 the last Release Candidate for
3.4.1 ;-)
Comment 24 _ mihmax 2003-01-06 19:19:32 UTC
I'm blind!!!
I beg a huge, large and sincere pardon, everybody.

runide_defaults.sh reads:
# Note: string after last slash in value of userdir variable is used
by installer build to identify release of NetBeans and to set userdir
by "OS native" NetBeans installer.
Please change userdir only with advance notification to NB buildmasters.

userdir=${HOME}/.netbeans/3.4
Comment 25 rbalada 2003-01-07 15:30:36 UTC
Maxym,

I've changed my shell script and installshield's NB.xml (local copies
only) to use 3.4 userdir, but show as 3.4.1 RC2.

I've tested Linux installer and it looks fine.

New installers are now being uploaded and I assume the upload will
finish at about 17:45 your time (15:45 UTC). Let me know if they are
OK, so we can update release-checklist with special note.
Comment 26 _ mihmax 2003-01-08 14:54:43 UTC
Rudolf,

Sorry for the delay in answering, yesterday was a Christmas holiday.
What should I download?
Comment 27 rbalada 2003-01-08 15:40:48 UTC
Maxym, for testing, you should download a native installer.
Choose Linux, Windows, SolarisSPARC or SolarisX86.
Comment 28 _ mihmax 2003-01-08 16:13:47 UTC
What native installer?
What build?
NetBeansIDE-release341-200301072341-win32.exe shows 3.4
Comment 29 rbalada 2003-01-08 17:43:59 UTC
Get Windows installer for 3.4.1 RC2
i.e.
http://www.netbeans.org/download/milestone/200301032341/release341rc-build-exe.html
Comment 30 _ mihmax 2003-01-09 12:35:33 UTC
Rudolf, Windows build is OK too,
commit the changes to release341 branch, please.
Comment 31 rbalada 2003-03-07 16:32:06 UTC
Fixed