This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29295 - Tooltip and editor tab show incorrect revision #
Summary: Tooltip and editor tab show incorrect revision #
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: Other OpenVMS
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-04 18:42 UTC by lingram
Modified: 2009-11-07 13:34 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Patch file generated by cvs diff for RevisionNode.java (753 bytes, patch)
2002-12-04 18:44 UTC, lingram 		Details | Diff
Patch file generated by cvs diff for RevisionEditorSupport.java (724 bytes, patch)
2002-12-04 18:45 UTC, lingram 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lingram 2002-12-04 18:42:49 UTC 
For VCS profiles that don't use 
revision numbers in the form "x.y",
the revision numbers for the tooltip 
and the editor tab (if the file
is opened) are incorrect. In both 
cases, it is because
the method getRevision() is used 
instead of getRevisionVCS().

The affected module to fix the tooltip 
is RevisionNode.java and for
the editor tab it is 
RevisionEditorSupport.java. Both are 1 
line fixes.
Comment 1 lingram 2002-12-04 18:44:16 UTC 
Created attachment 8171 [details]
Patch file generated by cvs diff for RevisionNode.java
Comment 2 lingram 2002-12-04 18:45:08 UTC 
Created attachment 8172 [details]
Patch file generated by cvs diff for RevisionEditorSupport.java
Comment 3 Martin Entlicher 2002-12-05 09:06:31 UTC 
Maxym, do you agree with adding this into 3.4.1? It seems, that this
is necessary for 3rd party VCS profiles.
The patch is trivial and should not cause any problems.
Comment 4 _ mihmax 2002-12-06 12:31:47 UTC 
Do I agree or not is NOT an issue.
If it's a BUGFIX, feel free to include it into 3.4.1 codebase (after
reviewing).

BTW: What 3rd party VCS profiles are under attack ;-) ?

Sincere Max
Comment 5 Martin Entlicher 2002-12-10 14:43:01 UTC 
Fixed in the main trunk and release341 branch.

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionEditorSupport.java,v 
<--  RevisionEditorSupport.java
new revision: 1.3.100.1; previous revision: 1.3
/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionNode.java,v 
<--  RevisionNode.java
new revision: 1.10.52.1; previous revision: 1.10
Comment 6 dmladek 2003-01-24 13:17:43 UTC 
Martin, easy fixing, isn't it?;-)
Isn't it what hurt us for long time....?

verified only on DEV.
OK on NetBeans IDE Dev (Build 200301240100)