This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29165 - CVS doesn't escape special characters in strings passed to a shell (eg. '$'-sign)
Summary: CVS doesn't escape special characters in strings passed to a shell (eg. '$'-s...
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker with 1 vote (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-28 21:31 UTC by puce
Modified: 2003-07-11 14:25 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description puce 2002-11-28 21:31:48 UTC
I have a file "JFontChooser.properties" in my cvs
repostiory. Now I want to add the file
"JFontChooser$FontStyle.properties" to the
repository but it fails with following statement:

cvs server: JFontChooser.properties already
exists, with version number 1.3

I think the source of the problem is:  When I
access the file on command line (eg. with 'less')
the '$'-sign is escaped
("JFontChooser\$FontStyle"). So I think netscape
should escape the '$'-sign before it passes it to
the shell. Otherwise the shell treats it like a
environment variable and tries to substitue it
(this would be an empty string, if the variable is
not defined, as I think it was the case in the
example above). Note that also other characters
probably shoud be escaped and that not all
characters are escaped with a '\' (eg. a '%' is
escaped with another '%'; this may be different on
different OSs)
Comment 1 puce 2002-11-28 21:41:00 UTC
"So I think netscape should escape the '$'-sign before it passes it to
the shell."

Of course NetBeanse, not Netscape ;-)

Note: Forget the thing with the different escape sign for '%'. This
was a Konqueror problem!
Comment 2 Martin Entlicher 2003-01-09 13:33:08 UTC
Some escaping logic was already implemented in 3.4, I'm going to
verify it...
Comment 3 Martin Entlicher 2003-01-09 13:47:20 UTC
This seems to be a regression. Working on a fix...
Comment 4 Martin Entlicher 2003-01-10 16:35:40 UTC
It's probably not a regression, escape of '$' probably never worked
correctly. Fixed in the main trunk.

/cvs/vcscore/src/org/netbeans/modules/vcscore/Variables.java,v  <-- 
Variables.java
new revision: 1.14; previous revision: 1.13
Comment 5 puce 2003-07-11 14:25:41 UTC
As described in the EMail from qa@netbeans.org "Request for issue
verification" I set the status to "VERIFIED" as the bug seems to be
fixed (it worked so far).