This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28981 - allow other modules to obtain contained links
Summary: allow other modules to obtain contained links
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Group (show other bugs)
Version: 3.x
Hardware: All All
: P1 blocker with 1 vote (vote)
Assignee: Marian Petras
URL:
Keywords: API, T9Y
Depends on:
Blocks: 28859
  Show dependency tree
 
Reported: 2002-11-25 10:01 UTC by Adam Sotona
Modified: 2004-02-18 17:24 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Sotona 2002-11-25 10:01:40 UTC
It is important to be able to obtain contained
links from .group data object.
Please provide some public API for this.
Comment 1 Jesse Glick 2002-11-26 23:03:05 UTC
IMHO a dupe of issue #28422.
Comment 2 _ tboudreau 2003-01-17 14:09:41 UTC
I just removed the this issue's dependance on 
http://www.netbeans.org/issues/show_bug.cgi?id=28623

Is there a use case in which group contents are necessary other
than that issue, or should this issue be closed?
Comment 3 Adam Sotona 2003-01-20 08:48:11 UTC
Yes,
TestTools module use GroupShadow for templates and needs to know the
contents.

Currently source of getLinks() functionality is ugly copied from
GroupShadow data object :-(
Comment 4 Marian Petras 2003-11-04 16:04:50 UTC
I cannot find what is (was?) wrong. Method getLinks() was public at
the time this feature request was entered. Please explain whether
there is still need for some change or this issue is outdated.

Contents of GroupShadow.java on 25 November 2002:
http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/group/Attic/GroupShadow.java?rev=1.32&content-type=text/x-cvsweb-markup&showattic=1
Comment 5 Jiri Skrivanek 2003-11-05 14:09:43 UTC
The GroupShadow class from group.jar cannot be used because group
module has disabled all possible dependencies in manifest:

OpenIDE-Module-Public-Packages: -

It is discussed in issue 28859. Jesse Glick said that it should be
solved when the issue 28422 is fixed. I don't know. If it is true,
then make this issue dependent on 28422. Otherwise suggest a solution.
Comment 6 Marian Petras 2003-11-10 10:00:42 UTC
According to Jiri Skrivanek, it should be sufficient to provide
_valid_ contained links, using interface DataObject.Container (as
Jesse Glick suggested in issue #28422). I am going to implement it.
Comment 7 Marian Petras 2003-11-14 13:09:59 UTC
Integrated into the trunk.

Class

    org.netbeans.modules.group.GroupShadow

now implements interface

    org.openide.loaders.DataObject.Container

which provides method

    DataObject[] getChildren().

GroupShadow implements this method such that it returns a list of
DataObjects the group contains. Any broken links in the group are ignored.

The interface also allows to listen for changes of contents.
Comment 8 Jiri Skrivanek 2004-02-18 17:24:12 UTC
Verified. Testtools module fixed as suggested.