This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28285 - Layout in JSP breakpoint dialog is odd
Summary: Layout in JSP breakpoint dialog is odd
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Debugger (show other bugs)
Version: -FFJ-
Hardware: All All
: P4 blocker (vote)
Assignee: Martin Grebac
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-25 20:02 UTC by Rochelle Raccah
Modified: 2005-12-14 14:49 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch created against 35 branch (5.69 KB, patch)
2003-04-04 03:05 UTC, Rochelle Raccah
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rochelle Raccah 2002-10-25 20:02:10 UTC
Many test tools/frameworks access the position of
the text field in order to populate it during ui
testing.  The expected behavior is that they are
added to the layout manager in the same
configuration as they are shown on the screen.

The JSP text field appears to be first, but is
actually in position 1 according to the layout. 
The line number field appears to be second, but is
actually in position 0 according to the layout.

This oddness makes writing test cases more
difficult.
Comment 1 _ rkubacki 2002-10-29 09:13:36 UTC
If this really bothers you creating a patch may be the best way as we
don't have resources to fix such minor issues. If the time spent with
finding working way is comparable to writing patch please do the latter.
Comment 2 Damian Frach 2002-10-29 16:57:07 UTC
fixed in the NB34
Comment 3 sva 2003-02-27 12:56:57 UTC
Verified with Netbeans dev build 030227.
Comment 4 Rochelle Raccah 2003-03-31 22:26:55 UTC
This is still broken.  I just checked the code at
<http://www.netbeans.org/source/browse/web/jspdebug/src/org/netbeans/modules/web/debug/JspBreakpointPanel.java?rev=1.6&content-type=text/x-cvsweb-markup>
and I still see that tfLineNumber is added to the panel before
cboxClass.  I also tried running my test case without the workaround
and it still fails.
Comment 5 _ rkubacki 2003-04-01 06:57:19 UTC
What you describe is not a defect. So if it is a *real* problem try to
submit a patch.
Comment 6 Rochelle Raccah 2003-04-04 03:04:21 UTC
Okay, I'm submitting a patch.
Comment 7 Rochelle Raccah 2003-04-04 03:05:23 UTC
Created attachment 9694 [details]
patch created against 35 branch
Comment 8 _ tboudreau 2003-04-04 08:44:14 UTC
Wouldn't it make much more sense to use components' name property
to find them for tests?  If the test relies on the order in which
components are added, this seems like an singularly easy way to
make brittle, often-broken tests.

We could create a naming convention for components and raise
awareness that for UI tests it is important to give GUI components
names.  I for one, would not mind at all if someone 
surreptitiously added a name property to some GUI form
of mine so they could write a good test - they wouldn't
even need to ask my permission - just go check it in.

It strikes me as well worth it - a persistent string
name is infinitely more reliable than depending on 
consistent ordering.
Comment 10 Rochelle Raccah 2003-12-18 20:29:16 UTC
Hello?  You asked for a patch and I submitted one almost 9 months
ago.  Can someone review and apply it please?
Comment 11 Petr Jiricka 2004-02-04 19:07:47 UTC
Martin, can you please look at this and apply Rochelle's patch? Thanks.

Comment 12 Martin Grebac 2004-02-11 13:01:35 UTC
I believe it's fixed now. Please reopen if I missed something.
Comment 13 Jiri Skrivanek 2005-12-14 14:49:27 UTC
Verified.