This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 270400 - Wizard doesn't close on window close
Summary: Wizard doesn't close on window close
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Templates (show other bugs)
Version: Dev
Hardware: PC Linux
: P3 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-14 10:44 UTC by Jaroslav Tulach
Modified: 2017-04-23 01:49 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2017-04-14 10:44:47 UTC 
The new JavaFX WebView app project wizard downloads Maven bits from internet on Finish and may freeze - user shall be able to close it. Alas that doesn't currently work.

I expect that to be a bug in core.windows.NbPresenter...
Comment 1 Jaroslav Tulach 2017-04-14 10:46:06 UTC 
netbeans$ hg diff
diff -r aaa11c0fda00 core.windows/src/org/netbeans/core/windows/services/NbPresenter.java
--- a/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java      Fri Apr 14 12:05:58 2017 +0200
+++ b/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java      Fri Apr 14 12:45:42 2017 +0200
@@ -53,7 +53,6 @@
 import java.awt.Dimension;
 import java.awt.EventQueue;
 import java.awt.FlowLayout;
-import java.awt.FocusTraversalPolicy;
 import java.awt.Frame;
 import java.awt.GraphicsDevice;
 import java.awt.GridBagConstraints;
@@ -1280,6 +1279,7 @@
         // #81938: special handling WizardDescriptor to avoid close wizard during instantiate
         if (!descriptor.isNoDefaultClose() ) {
             descriptor.setValue(NotifyDescriptor.CLOSED_OPTION);
+            buttonListener.actionPerformed(new ActionEvent(NotifyDescriptor.CLOSED_OPTION, -1, ""));
         }
     }
     public void windowActivated(final java.awt.event.WindowEvent p1) {
Comment 2 Jaroslav Tulach 2017-04-14 10:47:10 UTC 
The above patch makes sure clicking "close"icon results in same action as pressing regular close button...
Comment 3 Jaroslav Tulach 2017-04-22 05:21:25 UTC 
I guess I integrate. People I talked to seem to believe this is not a bad fix:
https://hg.netbeans.org/ergonomics/rev/426cf49d9cea
Comment 4 Quality Engineering 2017-04-23 01:49:43 UTC 
Integrated into 'main-silver', will be available in build *201704230002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/426cf49d9cea
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #270400: Emulate behavior of CLOSED_OPTION when dialog is closing