This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 269823 - "Overriden" annotation is not shown for overriden methods of a nested class
Summary: "Overriden" annotation is not shown for overriden methods of a nested class
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Model (show other bugs)
Version: Dev
Hardware: All All
: P3 normal (vote)
Assignee: ilia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-14 14:13 UTC by ilia
Modified: 2017-04-24 19:32 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Partial fix (2.98 KB, patch)
2017-03-02 08:24 UTC, ilia
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ilia 2017-02-14 14:13:02 UTC
Code:
------------8<------------
class AAA {
public:
    class inner;
};

class AAA::inner {
    virtual void foo() = 0;
};

class BBB : public AAA::inner {
    void foo();
};

class CCC : public BBB {
    void foo();
};
------------8<------------
Annotations on glyph:
[No annotation here]        virtual void foo() = 0; // at AAA::inner
[Overrides and overriden]   void foo();             // at BBB
[Overrides...]              void foo();             // at CCC

Expectations:
The overriden annotation should be shown in AAA::inner

Note that annotations to code below are shown correctly
------------8<------------
class AAA {
public:
    class inner {
        virtual void foo() = 0;
    };
};

class BBB : public AAA::inner {
    void foo();
};

class CCC : public BBB {
    void foo();
};
------------8<------------
Comment 1 ilia 2017-02-28 10:44:11 UTC
Code:
------------8<------------
class AAA {
public:
    class inner;
};

class AAA::inner {
    virtual void foo() = 0;
};

class BBB : public AAA::inner {
    void foo();
};
------------8<------------

class AAA::inner does not have "Is Extended" annotation
Comment 2 ilia 2017-03-02 08:24:07 UTC
Created attachment 163743 [details]
Partial fix
Comment 3 ilia 2017-03-02 08:24:42 UTC
Partial fix still has issues (click on annotation: 3 BBB links).
Comment 4 Quality Engineering 2017-03-15 02:50:33 UTC
Integrated into 'main-silver', will be available in build *201703150002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/9201c8ab0d1e
User: Ilia Gromov <ilia@netbeans.org>
Log: Fixing #269823 - "Overriden" annotation is not shown for overriden methods of a nested class
(transplanted from 17f3dcc300dcfea664dca3eb4630625391992530)
Comment 5 ilia 2017-04-13 11:14:40 UTC
https://netbeans.org/bugzilla/show_bug.cgi?id=269823 Changesets:
    http://hg.netbeans.org/releases/rev/17f3dcc300dc # Fixing #269823 - "Overriden" annotation is not shown for overriden methods of a nested class
    http://hg.netbeans.org/releases/rev/5da13682257a # Tests for #269823 - "Overriden" annotation is not shown for overriden methods of a nested class
Comment 6 Alexander Pepin 2017-04-24 19:32:09 UTC
Verified in netbeans-8.2-20170421.