This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 268981 - Improve performance of ModelUtils.wasProcessed method
Summary: Improve performance of ModelUtils.wasProcessed method
Status: RESOLVED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Editor (show other bugs)
Version: Dev
Hardware: PC Linux
: P3 normal (vote)
Assignee: Petr Pisl
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 268745
  Show dependency tree
 
Reported: 2016-11-14 22:09 UTC by Petr Pisl
Modified: 2016-12-08 14:20 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2016-11-14 22:09:41 UTC 
The current implementation of wasProcessed method uses ArrayList for finding an object that was already precessed. It would be better to use a HashSet.
Comment 1 Petr Pisl 2016-11-15 12:23:49 UTC 
This is one of the suggestions from issue #268745. After fixing this the time spend in the method is decreased from 1 300ms to 30ms on my machine, when less-rhino-4.js is opened. 

Fixed in web-main http://hg.netbeans.org/web-main/rev/533b8bb064f3
Comment 2 Quality Engineering 2016-11-17 02:50:18 UTC 
Integrated into 'main-silver', will be available in build *201611170001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/533b8bb064f3
User: Petr Pisl <ppisl@netbeans.org>
Log: #268981 - Improve performance of ModelUtils.wasProcessed method
Comment 3 Petr Pisl 2016-12-08 14:20:47 UTC 
The fix was transplanted to the releases/release82