This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 268980 - Improve performance of NodeJsRequireFunctionInterceptor
Summary: Improve performance of NodeJsRequireFunctionInterceptor
Status: RESOLVED FIXED
Alias: None
Product: javascript
Classification: Unclassified
Component: Editor (show other bugs)
Version: Dev
Hardware: PC Linux
: P3 normal (vote)
Assignee: Petr Pisl
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 268745
  Show dependency tree
 
Reported: 2016-11-14 20:59 UTC by Petr Pisl
Modified: 2016-12-08 14:21 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2016-11-14 20:59:27 UTC 
This is one of the suggested improvements by NukemBy. 

'createSnapshot()' per each 'intercept()' is most probably not needed - at least this very CPU consuming to be a working implementation
Comment 1 Petr Pisl 2016-11-14 21:03:44 UTC 
I have tested it and before fix NodeJsRequireFunctionInterceptor.intercept took about 8s on the tested project from issue #268745. After the fix it takes about 30 ms.
Comment 2 Petr Pisl 2016-11-14 21:07:19 UTC 
Fixed by this change: http://hg.netbeans.org/web-main/rev/ef238f36b2cf
Comment 3 Quality Engineering 2016-11-16 02:51:52 UTC 
Integrated into 'main-silver', will be available in build *201611160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/ef238f36b2cf
User: Petr Pisl <ppisl@netbeans.org>
Log: #268980 - Improve performance of NodeJsRequireFunctionInterceptor
Comment 4 Petr Pisl 2016-12-08 14:21:24 UTC 
The fix was transplanted to the releases/release82