This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 267954 - Warnings in encapsulate field refactoring
Summary: Warnings in encapsulate field refactoring
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: Dev
Hardware: PC Solaris
: P3 normal (vote)
Assignee: Vladimir Voskresensky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-09 13:31 UTC by Alexander Simon
Modified: 2017-04-13 10:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2016-09-09 13:31:33 UTC
Steps:
- Create C++ Application
- create new class
- add field
- invoke Encapsulate Field refactoring.
See exception in log:
INFO [dlight.libs.common.logger]: no any active cache transaction:class org.netbeans.modules.cnd.api.model.services.CsmSelect$ClassMembersKey
java.lang.Exception: no any active cache transaction:class org.netbeans.modules.cnd.api.model.services.CsmSelect$ClassMembersKey
	at org.netbeans.modules.cnd.api.model.services.CsmCacheManager$CsmCacheStorage.getEntry(CsmCacheManager.java:303)
	at org.netbeans.modules.cnd.api.model.services.CsmCacheManager.getClientCache(CsmCacheManager.java:189)
	at org.netbeans.modules.cnd.api.model.services.CsmSelect.getClassMembers(CsmSelect.java:139)
	at org.netbeans.modules.cnd.refactoring.support.GeneratorUtils.getAllOutOfClassMethodDefinitions(GeneratorUtils.java:135)
	at org.netbeans.modules.cnd.refactoring.support.GeneratorUtils.getDeclarationDefinitionFiles(GeneratorUtils.java:559)
	at org.netbeans.modules.cnd.refactoring.plugins.EncapsulateFieldsPlugin.initRefactorings(EncapsulateFieldsPlugin.java:238)
	at org.netbeans.modules.cnd.refactoring.plugins.EncapsulateFieldsPlugin.fastCheckParameters(EncapsulateFieldsPlugin.java:132)
	at org.netbeans.modules.refactoring.api.AbstractRefactoring.pluginsFastCheckParams(AbstractRefactoring.java:535)
	at org.netbeans.modules.refactoring.api.AbstractRefactoring.fastCheckParameters(AbstractRefactoring.java:288)
	at org.netbeans.modules.cnd.refactoring.ui.EncapsulateFieldUI.setParameters(EncapsulateFieldUI.java:105)
	at org.netbeans.modules.cnd.refactoring.ui.EncapsulateFieldUI.checkParameters(EncapsulateFieldUI.java:132)
	at org.netbeans.modules.refactoring.spi.impl.ParametersPanel.recheck(ParametersPanel.java:1000)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
	at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:109)
	at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:184)
	at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:229)
	at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:227)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:227)
	at java.awt.Dialog.show(Dialog.java:1084)
	at org.netbeans.core.windows.services.NbPresenter.superShow(NbPresenter.java:1086)
	at org.netbeans.core.windows.services.NbPresenter.doShow(NbPresenter.java:1136)
	at org.netbeans.core.windows.services.NbPresenter.run(NbPresenter.java:1108)
	at org.netbeans.core.windows.services.NbPresenter.run(NbPresenter.java:131)
	at org.netbeans.modules.openide.util.NbMutexEventProvider$Event.doEventAccess(NbMutexEventProvider.java:138)
	at org.netbeans.modules.openide.util.NbMutexEventProvider$Event.readAccess(NbMutexEventProvider.java:98)
	at org.netbeans.modules.openide.util.LazyMutexImplementation.readAccess(LazyMutexImplementation.java:94)
	at org.openide.util.Mutex.readAccess(Mutex.java:218)
	at org.netbeans.core.windows.services.NbPresenter.show(NbPresenter.java:1093)
	at java.awt.Component.show(Component.java:1671)
	at java.awt.Component.setVisible(Component.java:1623)
	at java.awt.Window.setVisible(Window.java:1014)
	at java.awt.Dialog.setVisible(Dialog.java:1005)
	at org.netbeans.modules.refactoring.spi.impl.ParametersPanel.showDialog(ParametersPanel.java:699)
	at org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.refresh(RefactoringPanel.java:685)
	at org.netbeans.modules.refactoring.spi.impl.RefactoringPanel.<init>(RefactoringPanel.java:169)
	at org.netbeans.modules.refactoring.spi.ui.UI.openRefactoringUI(UI.java:86)
	at org.netbeans.modules.cnd.refactoring.actions.RefactoringActionsProvider$5.run(RefactoringActionsProvider.java:266)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
	at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:159)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
Comment 1 Alexander Simon 2016-09-09 13:32:34 UTC
Next step:
- apply refactoring
See exception in log:
INFO [org.netbeans.spi.lexer.MutableTextInput]: !!WARNING!! Missing READ-LOCK when accessing TokenHierarchy: input-source:org.netbeans.modules.editor.NbEditorDocument@7406c7ac, mimeType='text/x-h', kitClass=null, length=469, version=12, file=org.netbeans.modules.cnd.source.HDataObject@17ae0fbe[/export1/home/alsimon/NetBeansProjects/CppApplication_12/newClass.h@de897efb:5ca2f2c0]
java.lang.Exception
[catch] at org.netbeans.lib.lexer.TokenHierarchyOperation.ensureReadLocked(TokenHierarchyOperation.java:407)
	at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:431)
	at org.netbeans.lib.lexer.TokenHierarchyOperation.tokenSequence(TokenHierarchyOperation.java:427)
	at org.netbeans.lib.lexer.TokenHierarchyOperation.embeddedTokenSequences(TokenHierarchyOperation.java:459)
	at org.netbeans.api.lexer.TokenHierarchy.embeddedTokenSequences(TokenHierarchy.java:265)
	at org.netbeans.cnd.api.lexer.CndLexerUtilities.getCppTokenSequence(CndLexerUtilities.java:137)
	at org.netbeans.modules.cnd.editor.indent.CppIndentTask.getLineIndentation(CppIndentTask.java:998)
	at org.netbeans.modules.cnd.editor.api.FormattingSupport.getLineIndentation(FormattingSupport.java:75)
	at org.netbeans.modules.cnd.editor.api.FormattingSupport.getFormattedText(FormattingSupport.java:144)
	at org.netbeans.modules.cnd.refactoring.plugins.EncapsulateFieldRefactoringPlugin.addDiff(EncapsulateFieldRefactoringPlugin.java:227)
	at org.netbeans.modules.cnd.refactoring.plugins.EncapsulateFieldRefactoringPlugin.processFile(EncapsulateFieldRefactoringPlugin.java:627)
	at org.netbeans.modules.cnd.refactoring.plugins.EncapsulateFieldsPlugin.processFile(EncapsulateFieldsPlugin.java:356)
	at org.netbeans.modules.cnd.refactoring.plugins.CsmModificationRefactoringPlugin.processFiles(CsmModificationRefactoringPlugin.java:138)
	at org.netbeans.modules.cnd.refactoring.plugins.CsmRefactoringPlugin.processFiles(CsmRefactoringPlugin.java:116)
	at org.netbeans.modules.cnd.refactoring.plugins.CsmRefactoringPlugin.createAndAddElements(CsmRefactoringPlugin.java:127)
	at org.netbeans.modules.cnd.refactoring.plugins.CsmModificationRefactoringPlugin.prepare(CsmModificationRefactoringPlugin.java:95)
	at org.netbeans.modules.refactoring.api.AbstractRefactoring.pluginsPrepare2(AbstractRefactoring.java:442)
	at org.netbeans.modules.refactoring.api.AbstractRefactoring.pluginsPrepare(AbstractRefactoring.java:426)
	at org.netbeans.modules.refactoring.api.AbstractRefactoring.prepare(AbstractRefactoring.java:237)
	at org.netbeans.modules.refactoring.spi.impl.ParametersPanel$Prepare.run(ParametersPanel.java:1090)
	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1443)
	at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:68)
	at org.openide.util.lookup.Lookups.executeWith(Lookups.java:303)
	at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2058)
Comment 2 Vladimir Voskresensky 2017-03-30 14:13:47 UTC
fixed on enum/release82
changeset: 314989:0e5eeb08759d [release82] 
changeset: 314990:ce2d76f147a9 [release82]
Comment 3 Vladimir Voskresensky 2017-03-30 15:57:59 UTC
*** Bug 254043 has been marked as a duplicate of this bug. ***
Comment 4 Quality Engineering 2017-04-02 02:38:09 UTC
Integrated into 'main-silver', will be available in build *201704020002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/fb00d60678fc
User: Vladimir Voskresensky <vv159170@netbeans.org>
Log: fixing #267954 - Warnings in encapsulate field refactoring
- more info in warning message
(transplanted from 0e5eeb08759d28aaa321e8485a12a04a180c1153)
Comment 5 ilia 2017-04-13 10:56:41 UTC
https://netbeans.org/bugzilla/show_bug.cgi?id=267954 Changesets:
    http://hg.netbeans.org/releases/rev/0e5eeb08759d # fixing #267954 - Warnings in encapsulate field refactoring
    http://hg.netbeans.org/releases/rev/ce2d76f147a9 # fixed #267954 - Warnings in encapsulate field refactoring