This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 267511 - SQL Log window has unwanted blank lines and does not have click-links for successful statements
Summary: SQL Log window has unwanted blank lines and does not have click-links for suc...
Status: RESOLVED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 8.2
Hardware: All All
: P3 normal (vote)
Assignee: matthias42
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 20:03 UTC by NukemBy
Modified: 2017-03-23 02:47 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
sample SQL output (32.29 KB, image/png)
2016-08-09 20:03 UTC, NukemBy 		Details
SQLExecutionLoggerImpl.java (11.77 KB, application/octet-stream)
2016-08-09 20:03 UTC, NukemBy 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NukemBy 2016-08-09 20:03:21 UTC 
Created attachment 161608 [details]
sample SQL output

There are 2 problems in current implementation of output of SQL execution logs which get especially annoying for SQL scripts having large number of statements

1. Each successful statement is logged, but it is not possible to click-navigate to a particular one - for example in the case when I have 100 consecutive statements and some of them in-between runs significantly longer then others, it is not possible to quickly locate it in source code.

2. Current output format is too long - takes at least 5 lines per statement (one of them is just excessive blank line). It will rather readable without blank lines  - each statement can be visually separated by the 'link' to source code at the beginning of corresponding log message.

Please take a look onto attached image of how it may look like.

I also attach vesion of "db.core\src\org\netbeans\modules\db\sql\loader\SQLExecutionLoggerImpl.java" as my attempt to make output look better. Feel free to 'compare' and copy/paste code as needed.
Comment 1 NukemBy 2016-08-09 20:03:45 UTC 
Created attachment 161609 [details]
SQLExecutionLoggerImpl.java
Comment 2 matthias42 2017-01-28 16:38:50 UTC 
Thank you - I integrated your patch but modified it slightly. So there is still one blank line between statements.

The changeset is pushed as:

http://hg.netbeans.org/core-main/rev/0a396c2f9d6f
Comment 3 Quality Engineering 2017-03-23 02:47:36 UTC 
Integrated into 'main-silver', will be available in build *201703230002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/0a396c2f9d6f
User: Matthias Blaesing <matthias42@netbeans.org>
Log: #267511: Print location of executed statement as hyperlink and reduce printed lines

Based on patch from NukemBy@netbeans.org