This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26620 - NB3.4 does not recognize JSP files if the freestyle browser is installed
Summary: NB3.4 does not recognize JSP files if the freestyle browser is installed
Status: CLOSED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P2 blocker (vote)
Assignee: _ rkubacki
URL:
Keywords:
: 31706 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-08-19 18:39 UTC by Ana.von Klopp
Modified: 2003-07-02 08:29 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ana.von Klopp 2002-08-19 18:39:15 UTC
See posts below. I have asked them to state
whether they did an import settings or not. We
need to follow up on these.
http://www.netbeans.org/servlets/ReadMsg?msgId=365306&listName=nbusers

Normally I would ask QA to follow up on this, but
since they are busy with Sierra it would be good
if the engineer who is responsible for the module
installation of the core could follow up on this. 

From: "Colic, Alex" <alex.colic@rbc.com>
Date: Fri, 16 Aug 2002 08:20:31 -0400
Subject: [nbusers] Problem with JSP Icons


Hi,

I recently upgraded my Netbeans to Netbeans 3.4
RC2. I opened one of my
projects and now when I look at the tree
underneath the web module I see a
lot of white basic icons. They are my JSP's. I
can't click on them to see
the source. They are just there.

From: Razvan Gliga <razvan.gliga@mcr.ro>
Subject: Re: [nbusers] Problem with JSP Icons
Date: Sat, 17 Aug 2002 12:04:09 +0300

Hi Ana,
also I have same problem.
JSP files aren't recognized, and only normal file
icons are displayed. 
Nor the name of the file. In templates JSP types
are also disabled and 
only normal file icons without any explanation are
displayed.
This problem was appeared in NB 3.4 RC1 I upgraded
to RC2 and problem 
still remain. I disabled and remove all
JSP/Servlets modules and 
redownloaded using autoupdate feature and problem
still remain.
I work on Win2K PC and have JDK 1.4.0-b92.

On same station JSP/Servlet modules work ok on
Forte 4 Comunity edition.
Comment 1 Ana.von Klopp 2002-08-20 01:04:13 UTC
From: "Colic, Alex" <alex.colic@rbc.com>
To: nbusers@netbeans.org
Subject: RE: [nbusers] Problem with JSP Icons
Date: Mon, 19 Aug 2002 15:38:33 -0400


Hi,

I am work so I can't verify all of this but here goes.

I had a project running fine in Netbeans 3.3. I upgraded 
to 3.4 RC1 and
selected the import settings check box.

I noticed that my jsp icons were not showing up. I new 
this was not the
final version of Netbeans so I lived with it. I then 
upgraded to RC2 using
the same method as above and the icons were still messed 
up.

What I will do when I go home is reinstall Netbeans Rc2 to 
a different
directory, create a new project and then move all of my 
files from the old
project directory to the new. Hopefully this will fix 
things.

Alex
Comment 2 Ana.von Klopp 2002-08-20 01:25:12 UTC
From: "Colic, Alex" <alex.colic@rbc.com>
To: nbusers@netbeans.org
Subject: RE: [nbusers] Problem with JSP Icons
Date: Mon, 19 Aug 2002 15:38:33 -0400


Hi,

I am work so I can't verify all of this but here goes.

I had a project running fine in Netbeans 3.3. I upgraded 
to 3.4 RC1 and
selected the import settings check box.

I noticed that my jsp icons were not showing up. I new 
this was not the
final version of Netbeans so I lived with it. I then 
upgraded to RC2 using
the same method as above and the icons were still messed 
up.

What I will do when I go home is reinstall Netbeans Rc2 to 
a different
directory, create a new project and then move all of my 
files from the old
project directory to the new. Hopefully this will fix 
things.

Alex
Comment 3 Milan Kuchtiak 2002-08-20 09:03:36 UTC
Radim. Were there any changes in JSPDataLoader comparing to 
the Netbeans3.3? Or is it a problew with JSP Settings 
deserialization ?
Comment 4 Ana.von Klopp 2002-08-20 18:00:59 UTC
I got some more information today. I think many of the 
users installed first RC1 and then RC2. Could it be that 
there is something with the user directory that causes 
this? 

I would suggest trying to install RC1 and then RC2 without 
importing any data, and without importing any settings. 

Here is today's crop of messages: 

From: Razvan Gliga <razvan.gliga@mcr.ro>
Subject: Re: [nbusers] Problem with JSP Icons
Date: Tue, 20 Aug 2002 09:47:57 +0300

First I installed NB 34 RC1 without importing settings 
from NB32. I have both versions installed on same pc. When 
RC2 become available I remove NB32 and installing with 
import setings from NB34 RC1.

Also explorer icons without names that seem to take place 
for JSP files have no action at double click and throw 
exception at Enter key. 

Check out the following as well:

From: "Chuong Huynh Ngoc" <Chuonghuynh@Cybersoft-VN.com>
Subject: RE: [nbusers] Problem with JSP Icons
Date: Tue, 20 Aug 2002 13:58:39 +0700

I faced the same problem. The reason is maybe you have 
installed freestyle browser module (via autoupload). When 
I remove it, it worked fine.



Comment 5 Ana.von Klopp 2002-08-20 18:02:37 UTC
BTW, Milan, I wasn't sure if the bug should be assigned to 
you or not. Feel free to reassign it if I got it wrong 
(and if so, thanks for having started to look into it 
anyway). 
Comment 6 Jason Rush 2002-08-20 23:01:57 UTC
I did some investigation into this bug today and it looks like it is
NOT related to importing settings from previous versions or having
installed RC1 before installing RC2.  As suggested , this is a problem
with the Free Style Browser module available via the Update Center. 
The following are the steps I went through with RC2 with a new user
directory.

1. Created a new web module.
2. Added three JSPs to the web module.
3. From the Update Center, installed the Free Style Browser module
(it's either Alpha or Beta, don't remember which).
4. After the IDE restarted, my JSPs had null icons.
5. From the Options window, I disabled the Free Style Browser module.
6. After either restarting the IDE or remounting the web module, the
JSP nodes are back to normal.
Comment 7 Ana.von Klopp 2002-08-21 01:59:21 UTC
Thanks to Chuong and Jason for nailing down the problem. 
We probably wouldn't have found it without Chuong's 
report, at least not within reasonable time. 

I emailed nbdev to see if there is anything the update 
center can do about warning users that the freestyle 
browser is not compatible with the web apps functionality. 

There doesn't seem to be an appropriate resolution state 
to put this bug in ("not our fault"). Or maybe there's 
something that we can do about being really proactive 
about the data loader? 

Milan, I'll reassign this back to me for the purposes of 
negotiating with the update center, though anybody else 
who wishes to take this part should be free to chip in. 

Ana

Comment 8 Milan Kuchtiak 2002-08-21 16:07:37 UTC
Both Petr Hrebejk and me investigated the problem. It's 
only the good lack that Jsp Nodes are working correctly 
without Free Style Browser Module. The problem is that the 
Jsp Nodes are implemented using openidex-Looks 
infrastructure and there is a bug in 
JspDataObject:createNodeDelegate() method.We fixed this 
problem - here is the Diff file which should solve the 
problem :

diff -u -r1.10 JspDataObject.java
--- JspDataObject.java	24 Jul 2002 08:13:57 -0000	1.10
+++ JspDataObject.java	21 Aug 2002 14:55:32 -0000
@@ -160,10 +160,10 @@
             } else if (CompositeLook.class.equals
(look.getClass())
                    &&  "Web-Look".equals (look.getName 
())) {   // NOI18N
                 wellKnown = look;                    
+                break;
             } else {
                 // System.out.println ("\tand using as 
default"); // NOI18N
                 defaultLook = look;
-                break;
             }
         } 

I fixed this for the trunk, but I have no 100% confidence 
that this is the best fix for Netbeans3.4 release. Radim 
Kubacki is the best person to look at it detailly and 
review the code.

Milan
Comment 9 Ana.von Klopp 2002-08-22 18:52:35 UTC
This issue has been resolved at the Netbeans 3.4 level 
(MDR and freestyle browser modules will be removed from 
the autoupdate center. 

We should fix the bug and provide our module for 
autoupdate with the fix. Milan has integrated a fix into 
the trunk, but indicated that he would like Radim to check 
it so I'm reassigning the bug to Radim. 

Thanks everybody who helped with this issue. 
Comment 10 _ rkubacki 2002-08-26 17:20:23 UTC
Fix is OK and now is applied also to ServletDataObject and DDDataObject.
Comment 11 _ rkubacki 2002-08-28 15:14:41 UTC
updated version of module is uploaded to AU for NB3.4
Comment 12 _ mihmax 2003-01-05 21:01:50 UTC
Well, this particular fix didn't come to NetBeans IDE 3.4, because it
was applyed after the release, so I'm reseting Target Milestone to 4.0
and adding 3.4.1_CANDIDATE.

Well, people, haven't you hear all that buzz about 3.4.1? ;-)
This is 100% candidate for 3.4.1, and you just set the target
milestone to 3.4 and want this particular fix not to be included into
3.4.1?!! Shame on you, people.

If not Vincent Brabant who noticed that 3.4.1 JSP/Servlet module has
1.8.1 version and AU somehow contains 1.8.2, we would never discover
this fix, and then it would be lost in ages.

Max, Merak Release Coordinator

P.S. Don't be too much offended with my talkings, I was grinning all
the time, but it's no good to set target milestone to the version that
doesn't actually contain a fix.
Comment 13 _ mihmax 2003-01-05 21:50:01 UTC
Found CVS log:

http://web.netbeans.org/servlets/ReadMsg?msgId=370048&listName=cvs

People! Comrads! Gentlemen! Sirs! please, please, please, leave the
CVS logs after you.
Comment 14 _ mihmax 2003-01-05 21:54:03 UTC
I think that was a in-trunk fix log,
correct (in strange release34_fixes branch) CVS log is:

http://web.netbeans.org/servlets/ReadMsg?msgId=370345&listName=cvs

Commit that tomorrow
Comment 16 Jason Rush 2003-03-04 03:20:00 UTC
Verified in NetBeans dev build 200303030100.
Comment 17 Jason Rush 2003-03-07 07:25:23 UTC
*** Issue 31706 has been marked as a duplicate of this issue. ***
Comment 18 Quality Engineering 2003-07-02 08:29:25 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.