Created attachment 160361 [details]
Patch to correct not log exceptions

I've also removed the deprecated call deprecated DataObject#getCookie.

You mention the exception is not thrown but what you are actually doing is removing the log call and ignoring that null-null situation. (A minimal patch would just remove the Logger.getLogger line).

Why do you believe this is not important?

Aren't you hiding some potential relevant debugging info for an unknown situation?

I think what's interesting here is the underlying situation that is causing on your machine enough of these messages that you felt like providing a patch.

Is the fix for 262780 incomplete perhaps?

Also, should we lower the level perhaps?

If you don't want to see those messages, you could also edit your netbeans.conf and add -J-Dname.of.the.Logger.level=$LEVEL$

(In reply to emi from comment #2)
> You mention the exception is not thrown but what you are actually doing is
> removing the log call and ignoring that null-null situation. (A minimal
> patch would just remove the Logger.getLogger line).

That's correct, and effectively what I have done. As the null check contained a `return` statement this was simplified by adding an `else if` to (1) make the intent clearer and (2) preserve behaviour.

> Why do you believe this is not important?

It is simply unnecessary. As a point the logged error is informational, if anything it should be a debug message. There's no hint in the logged message as to the cause or any way of tracking this down in the first place. The question should be "what does the logged statement achieve?".

> Aren't you hiding some potential relevant debugging info for an unknown
> situation?

As it stands, there's not much the logged exception provides and gives the false impression there is something wrong, which; there probably is, but it's not traceable from this point. At present this is occurring every time I open a JSP in Build 20160712-16457b922100.

java.lang.IllegalStateException
	at org.netbeans.modules.web.core.jsploader.BaseJspEditorSupport$4.propertyChange(BaseJspEditorSupport.java:190)
	at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
	at org.openide.text.CloneableEditorSupport.firePropertyChange(CloneableEditorSupport.java:484)
	at org.openide.text.CloneableEditorSupport.fireDocumentChange(CloneableEditorSupport.java:1778)
	at org.openide.text.DocumentOpenClose$DocumentClose.run(DocumentOpenClose.java:999)
	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1443)
	at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:68)
	at org.openide.util.lookup.Lookups.executeWith(Lookups.java:303)
	at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2058)


> I think what's interesting here is the underlying situation that is causing
> on your machine enough of these messages that you felt like providing a
> patch.

This occurs for opening any JSP file where a taglib is referenced int he JSP that points to the local jar within the NetBeans IDE installation. As default copies are installed in paths that contain spaces the exceptions do add up.

Yes, it's a simple and low priority patch, but I did think it helpful.

> Is the fix for 262780 incomplete perhaps?

Indeed, as no fix presently exists. I first submitted this one while I will soon be providing a patch for 262780. The fix for 262780 will correctly return the File object with spaces of the correct scheme (space for `file`, %20 for others).

> Also, should we lower the level perhaps?

My bad, I thought I raised as P4, didn't mean it to be any higher.

> If you don't want to see those messages, you could also edit your
> netbeans.conf and add -J-Dname.of.the.Logger.level=$LEVEL$

That's the point, this message is "info", if anything it should be "debug" if it absolutely must remain.

I have supplied a patch to [1] (issue: 262780) which I can confirm was the cause of this exception being thrown.

However, I still feel this issue is still valid as while related does not indicate within the logged info message of the relationship.

 [1]: https://netbeans.org/bugzilla/show_bug.cgi?id=262780