This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26191 - ZIPException's during module system startup can cause main thread to halt
Summary: ZIPException's during module system startup can cause main thread to halt
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Module System (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on:
Blocks: 27320
  Show dependency tree
 
Reported: 2002-08-01 17:24 UTC by Jesse Glick
Modified: 2008-12-23 08:33 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Proposed 3.4.1 patch (908 bytes, patch)
2002-11-29 14:34 UTC, Jesse Glick 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-08-01 17:24:11 UTC 
The exception is caught and rethrown, but the
rethrown exception is missing the module name. A
catch clause a bit further down is expecting to
know what the module was and when it doesn't find
it, it chokes. Easy fix. Improves robustness if
some module JARs are corrupted etc.
Comment 1 Jesse Glick 2002-08-01 17:25:06 UTC 
committed     Up-To-Date  1.34       
core/src/org/netbeans/core/modules/ModuleManager.java
Comment 2 Jesse Glick 2002-11-29 14:34:39 UTC 
Created attachment 8114 [details]
Proposed 3.4.1 patch
Comment 3 Jesse Glick 2002-11-29 14:35:09 UTC 
Review requested.
Comment 4 Jesse Glick 2002-12-02 19:16:42 UTC 
Still awaiting review.
Comment 5 Jaroslav Tulach 2002-12-03 09:55:26 UTC 
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be
integrated into release341 one branch. The plan at
http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be
produced on Dec01. That did not happen due to a lot of outstanding not
integrated candidates like this one. 

Would it be possible to spend few minutes by backporting this fix? Thank you in
advance.
Comment 6 Jaroslav Tulach 2002-12-03 10:20:07 UTC 
Ok, rethrown exception seems to have better name.
Comment 7 Jesse Glick 2002-12-03 16:33:30 UTC 
"Ok, rethrown exception seems to have better name." - that was a
review I guess?
Comment 8 Jesse Glick 2002-12-03 23:02:37 UTC 
In release341.

Checking in core/src/org/netbeans/core/modules/ModuleManager.java;
/cvs/core/src/org/netbeans/core/modules/ModuleManager.java,v  <-- 
ModuleManager.java
new revision: 1.31.24.1; previous revision: 1.31
done

To verify:

1. Create empty file
modules/patches/org-apache-tools-ant-module/bogus.jar.

2. Make it unreadable. (chmod a-r)

3. Start up. W/o patch, startup would halt. W/ patch, ZIPException
thrown and reported; startup continues; Ant module disabled (with
error badge in the Modules node).
Comment 9 Marian Mirilovic 2005-07-12 09:05:35 UTC 
closed