This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25961 - PVCS: Can't "Get" a file with lock.
Summary: PVCS: Can't "Get" a file with lock.
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-24 12:01 UTC by Jiri Kovalsky
Modified: 2003-07-01 13:05 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2002-07-24 12:01:21 UTC 
RC1 build #200207232340 of NetBeans 3.4
Windows 2000 with JDK 1.4.1 RC build #17

Description:
============
Basic switch of "PVCS|Get" command allowing to
lock a file does not work. Although there is a
workaround, it is not easy. This is serious
regression in functionality and we can't release
RC with this bug.

Steps to reproduce:
===================
1. Mount PVCS filesystem and add new [Local]file
to archive.
2. Invoke "PVCS|Get" on that [Current] file.
3. Check both checkboxes and push "OK" button.
4. The file won't be locked after status
refreshing is over.
Comment 1 Martin Entlicher 2002-07-24 12:14:05 UTC 
Starting to work on it.
This bug became visible after fix of issue #25488.
Comment 2 Martin Entlicher 2002-07-24 15:29:30 UTC 
The bug is fixed in the main trunk.

Description of the problem:
The DO_CHECKOUT_BY_DATE checkbox component defined in the input
descriptor have "false" default value. This value was wrongly set to
the DO_CHECKOUT_BY_DATE variable, where non-empty values are
interpreted as TRUE and empty values as FALSE.
This conversion is correctly performed when the component is
displayed, but not if it's value is propagated without showing this
component.

Diff:
http://vcscore.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDescriptor.java.diff?r1=1.10&r2=1.11
Comment 3 Jiri Kovalsky 2002-07-24 15:55:13 UTC 
The fix seems safe to me.
Comment 4 Martin Entlicher 2002-07-25 09:44:24 UTC 
Thanks for the review.
The fix was merged into release34 branch.
Comment 5 Jiri Kovalsky 2002-07-25 09:57:12 UTC 
I have just verified the fix in development build #200207250200 of
NetBeans 4.0.
Comment 6 Quality Engineering 2003-07-01 13:05:40 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.