This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 259007 - [regression] debug sessions are missed in debug history
Summary: [regression] debug sessions are missed in debug history
Status: RESOLVED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 8.2
Hardware: All All
: P2 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2016-04-25 12:31 UTC by Vladimir Voskresensky
Modified: 2016-07-14 01:52 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
debug history (13.25 KB, image/png)
2016-04-27 09:43 UTC, Vladimir Voskresensky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2016-04-25 12:31:31 UTC
I think it's a regression, but anyway:
Launchers are missed in Debug Project dropdown history.

(they are present in Run dropdown history)
Comment 1 Vladimir Voskresensky 2016-04-25 12:32:20 UTC
I mean main toolbar "Debug Project" action which has "v" on right side to access history of debug sessions
Comment 2 Alexander Simon 2016-04-26 12:07:50 UTC
It is not a defect.
The class projectui/src/org/netbeans/modules/project/ui/actions/BuildExecutionSupportImpl.java is not designed to keep debug history (see bug #193873).
Make project register debug actions (see usages of the class org.netbeans.modules.cnd.makeproject.launchers.actions.LauncherAction.LauncherExecutableAction).
Please file enhancement against appropriate component.
Comment 3 Vladimir Voskresensky 2016-04-27 09:07:38 UTC
Alexander, what is INVALID in my issue?
Have you ever used Launchers yourself? I do it all the time.
This lost of the functionality is [regression], definitely no "invalid".

This was implemented previously based on
https://netbeans.org/bugzilla/show_bug.cgi?id=193872

But we have lost is at some point.
Comment 4 Vladimir Voskresensky 2016-04-27 09:08:47 UTC
Sorry, it is regression not for launchers only. It is regression for any native session no more kept in debug history.
Comment 5 Vladimir Voskresensky 2016-04-27 09:43:05 UTC
Created attachment 159447 [details]
debug history
Comment 6 Vladimir Voskresensky 2016-04-29 21:30:28 UTC
Alexander, could you have a look, please, at this regression.
Comment 7 Alexander Simon 2016-04-30 07:59:51 UTC
Apparently it is regression that was introducing while fixing the bug #256161 ( Debug drop-down carries duplicates and shows deleted project).
Reassign to evaluation.
Comment 8 Alexander Simon 2016-04-30 08:04:49 UTC
The class DebugActionItem (see change set 4fdb63703dbb) has equals method that does not differ two different items with same project.
Comment 9 Martin Entlicher 2016-05-19 07:42:39 UTC
This can not be caused by the fix of bug #256161, I'm able to reproduce the problem in NetBeans 8.1 as well.

When Java project finish execution, org.netbeans.spi.project.ui.support.BuildExecutionSupport.registerFinishedItem() is called.
When C/C++ project finish execution, it's not called and this is the cause of the problem.
Comment 10 Vladimir Voskresensky 2016-06-14 10:11:00 UTC
Martin,
We've checked and 
org.netbeans.modules.cnd.makeproject.ui.launchers.actions
class LauncherAction {
.........
  private class ExecutionListenerImpl implements ExecutionListener {

    @Override
    public void executionStarted(int pid) {
        BuildExecutionSupport.registerRunningItem(runActionItem);
    }

    @Override
    public void executionFinished(int rc) {
        BuildExecutionSupport.registerFinishedItem(runActionItem);
    }

  }
....
}
the above code is called as on Run the same as on Debug, but appears only in Run history, not in Debug history
Comment 11 Martin Entlicher 2016-07-13 09:33:34 UTC
Thanks Vladimir for a better insight into the issue, it should be fixed by
changeset:   299178:0e75b59b09c5
Comment 12 Quality Engineering 2016-07-14 01:52:04 UTC
Integrated into 'main-silver', will be available in build *201607140002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/0e75b59b09c5
User: mentlicher@netbeans.org
Log: #259007: Compare DebugActionItems not only for project roots, but also for display name to assure that actions with different projects configurations are not considered the same.